Re: Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

> On 2012-03-13 20:44:46, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js, > > line 312 > > > > > > Is the name of this

Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

> On 2012-03-13 20:28:04, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 74 > > > > > > Before when this wasn't be

Re: Review Request: Cleanup NOTICE and LICENSE files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5918 --- http://svn.apache.org/repos/asf/shindig/trunk/NOTICE

Re: Review Request: Cleanup NOTICE and LICENSE files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5912 --- http://svn.apache.org/repos/asf/shindig/trunk/NOTICE

Re: Review Request: Cleanup NOTICE and LICENSE files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5904 --- http://svn.apache.org/repos/asf/shindig/trunk/NOTICE

Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5896 --- Ship it! LGTM echo Stanton's question - Ryan On 2012-03-13 18:36:3

Re: Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4321/#review5893 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5892 --- LGTM, just the one question inline. http://svn.apache.org/repos/asf/

Re: Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4321/#review5889 --- Ship it! LGTM - Stanton On 2012-03-13 20:12:36, Dan Dumont wrote:

Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4321/ --- Review request for shindig. Summary --- Now passing along the calling site

Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ --- (Updated 2012-03-13 18:36:35.048131) Review request for shindig. Changes -

Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ --- Review request for shindig. Summary --- Updated sample gadgets. Added a dum

Re: Review Request: gadgets.io.makeRequest supports PUT but the PUT body is not passed along

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4273/#review5880 --- Ship it! LGTM - Dan On 2012-03-09 19:23:05, Stanton Sievers wrote:

Re: Review Request: Cleanup NOTICE and LICENSE files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5879 --- http://svn.apache.org/repos/asf/shindig/trunk/NOTICE

Re: [PING] SHINDIG-1689: Cleanup NOTICE and LICENSE files

On 03/13/2012 05:14 PM, Henry Saputra wrote: HI Ate, Sorry for the tardiness. I thought this case has been committed. I'll take a look at it today Thanks Henry, appreciated! Regards, Ate - Henry On Tue, Mar 13, 2012 at 5:20 AM, Ate Douma wrote: Anyone willing to review the patch I submi

Re: [PING] SHINDIG-1689: Cleanup NOTICE and LICENSE files

HI Ate, Sorry for the tardiness. I thought this case has been committed. I'll take a look at it today - Henry On Tue, Mar 13, 2012 at 5:20 AM, Ate Douma wrote: > Anyone willing to review the patch I submitted about 4 weeks ago? > > I think this issue should be considered a blocker for the 2.5.0

[PING] SHINDIG-1689: Cleanup NOTICE and LICENSE files

Anyone willing to review the patch I submitted about 4 weeks ago? I think this issue should be considered a blocker for the 2.5.0 release. See: https://issues.apache.org/jira/browse/SHINDIG-1689 and https://reviews.apache.org/r/3887/ and http://mail-archives.apache.org/mod_mbox/shindig-dev/201