Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

2012-03-14 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5935 --- Ship it! LGTM - Stanton On 2012-03-13 18:36:35, Dan Dumont wrote:

Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

2012-03-14 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5936 --- Ship it! Committed r1300552 - Dan On 2012-03-13 18:36:35, Dan

Re: Problem with latest shindig

2012-03-14 Thread daviesd
Paul, I¹m trying to track down this LocalCache problem that was introduced on commit r1290973. What I¹ve noticed is that it fails when it thinks two methods have the same signature. For example I see this list of methods: [ public static org.oclc.platform.opensocial.spi.ApplicationId

Re: Review Request: Cleanup NOTICE and LICENSE files

2012-03-14 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5944 --- Extra comments and will let some other people to chime in. ETA is end

Re: Review Request: Cleanup NOTICE and LICENSE files

2012-03-14 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5976 ---

Re: Review Request: Cleanup NOTICE and LICENSE files

2012-03-14 Thread Ryan Baxter
On 2012-03-15 00:21:21, Ryan Baxter wrote: Oops meant to add some context here before I published :) I am OK with these changes, Henry has asked the obvious changes. I am not really that familiar with some of the implications of these changes, so not sure how useful my review is. Just