Good advice Jesse and Henry :)
Looks like Paul already committed the change, but it will still be good to
grant the license to the patch and close the JIRA and the review. Thanks.
-Ryan
From: daviesd
To: ,
Date: 03/21/2012 03:17 PM
Subject:Re: Review Request: Fix for SHIND
On 03/22/2012 01:57 AM, Paul Lindner wrote:
I can 2.5. beta1 tonight.
Paul,
Please note Henry said he'd commit the patch for SHINDIG-1689 today which IMO is
a blocker before a release.
I would like to get someone to be backup RM though, ping me if you're
interested. Also you'll need to
I can 2.5. beta1 tonight.
I would like to get someone to be backup RM though, ping me if you're
interested. Also you'll need to get your GPG key signed.
On Wed, Mar 21, 2012 at 10:22 AM, Henry Saputra wrote:
> I think if Paul is not available for release we need temp RM for 2.5 Beta
> 1.
>
> A
Thanks Stanton. So no rpc_relay setup etc.? Seems last time I did this I ran
into that.
Doug
Sent from my iPhone
On Mar 21, 2012, at 3:43 PM, "Stanton Sievers" wrote:
> Hi Doug,
>
> Yes, things work just fine running the container page and shindig on
> different domains. You can set the
> On 2012-03-21 22:09:24, Henry Saputra wrote:
> > Actually I just noticed something when trying to commit. What is the
> > appended-resources directory for? Is it automatically generated by your
> > build? Seems like aggregation of the NOTICE and LICENSE files
The appended-resources directory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
---
Actually I just noticed something when trying to commit. What is the
On 03/21/2012 10:04 PM, Henry Saputra wrote:
Ate,
Since you contributed the patch, could you attach the patch to
https://issues.apache.org/jira/browse/SHINDIG-1689 for legal purpose?
Done.
Kind of funny to grant ASF license for legal purpose on a patch with the intend
to fix and cleanup the c
Ate,
Since you contributed the patch, could you attach the patch to
https://issues.apache.org/jira/browse/SHINDIG-1689 for legal purpose?
I will commit the patch attached to the JIRA instead of the one from
code review site.
- Henry
On Wed, Mar 21, 2012 at 4:37 AM, Ate Douma wrote:
> As no fur
Thanks for the patch! :)
>-Original Message-
>From: daviesd [mailto:davi...@oclc.org]
>Sent: Wednesday, March 21, 2012 3:11 PM
>To: dev@shindig.apache.org
>Subject: Re: Review Request: Fix for SHINDIG-1736
>
>Thanks for the "newbie" info. :)
>
>
>On 3/21/12 2:34 PM, "Ciancetta, Jesse E."
Hi Doug,
Yes, things work just fine running the container page and shindig on
different domains. You can set the osapi.container.ServiceConfig.API_HOST
and osapi.container.ServiceConfig.API_PATH when creating your
osapi.container.Container object to get the right pointers in place.
Best rega
Thanks for the "newbie" info. :)
On 3/21/12 2:34 PM, "Ciancetta, Jesse E." wrote:
> And you also need to be sure to select the radio option for:
>
> "Grant license to ASF for inclusion in ASF works"
>
> when uploading the patch -- otherwise we can't legally apply it. It doesn¹t
> look like y
It is a good catch. This is needed for legality issue for the patches
- Henry
On Wed, Mar 21, 2012 at 11:34 AM, Ciancetta, Jesse E. wrote:
> And you also need to be sure to select the radio option for:
>
> "Grant license to ASF for inclusion in ASF works"
>
> when uploading the patch -- otherwis
And you also need to be sure to select the radio option for:
"Grant license to ASF for inclusion in ASF works"
when uploading the patch -- otherwise we can't legally apply it. It doesn’t
look like you did that when attaching the current patch to the JIRA ticket.
Sorry for the extra hoops to
Dont want to be party pooper but Doug could you attach the patch to
the JIRA associated with this review?
- Henry
On Wed, Mar 21, 2012 at 6:38 AM, Ryan J Baxter wrote:
> I can commit it. I was also waiting for Paul to take a look at it. If he
> doesn't get to it by the end of the day I will co
I think if Paul is not available for release we need temp RM for 2.5 Beta 1.
Any volunteer?
- Henry
On Tue, Mar 20, 2012 at 1:35 PM, Franklin, Matthew B.
wrote:
> Once the patch Ate submitted for the LICENSE & NOTICE files is applied, I
> would like to request a Beta release for 2.5. There a
About a year ago there was a discussion about shindig running on a different
domain than the container.
http://permalink.gmane.org/gmane.comp.web.shindig.devel/6824
Up till this point we have been running our shindig servers and our
container webapps on the same domain. We¹d like to move away fr
Hi David,
In Shindig, gadgets.io.getProxyUrl(url)
returns a url through the content proxy. By default this is
http:///gadgets/proxy. For instance, gadgets.io.getProxyUrl("
http://shindig.apache.org";) will return this:
http:///gadgets/proxy?container=default&refresh=3600&url=http%3A%2F%2Fshin
Can someone help me understand what the gadgets.io.getProxyUrl does ?
I've seen it discussed in the mailing lists, but the OpenSocial
specification only says:
Type: {String} gadgets.io.getProxyUrl(url, opt_params)
Description: Gets the proxy version of the passed-in URL.
I fo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4284/#review6171
---
Ship it!
lgtm
- Dan
On 2012-03-21 01:28:55, Ryan Baxter wrote:
>
Good questionnot really sure what we would call it since we switch
versions. I would assume Beta 1.
From: daviesd
To: ,
Date: 03/20/2012 11:04 PM
Subject:Re: [REQUEST] Beta Release for 2.5
+1 for a 2.5 beta release.
On 3/20/12 4:35 PM, "Franklin, Matthew B." wrote:
I can commit it. I was also waiting for Paul to take a look at it. If he
doesn't get to it by the end of the day I will commit it.
-Ryan
From: daviesd
To: , Paul Lindner ,
Cc: Ryan Baxter
Date: 03/20/2012 11:04 PM
Subject:Re: Review Request: Fix for SHINDIG-1736
Th
As no further comments were given on SHINDIG-1689 and Henry indicated he wanted
to wait until end of week (last week), maybe this patch now can be applied?
Regards, Ate
On 03/15/2012 02:10 PM, Ate Douma wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4284/#review6169
---
Ship it!
+1
- Henry
On 2012-03-21 01:28:55, Ryan Baxter wrote:
>
23 matches
Mail list logo
