Re: update shindig-caja integration (issue 6304061)

I think JS compiler decorate the incoming request to always treat it as debug mode On 2012/06/21 21:29:17, felix8a wrote: On 2012/06/11 15:22:41, Jasvir wrote: > LGTM > > http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js > File features/src/mai

Re: update shindig-caja integration (issue 6304061)

On 2012/06/11 15:22:41, Jasvir wrote: LGTM http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js File features/src/main/javascript/features/caja/taming.js (right): http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

> On June 21, 2012, 7:56 p.m., Adam Clarke wrote: > > I think in the event that there's no encrypter available we should set the > > encrypted secret to be the unencrypted secret that was passed in. The > > persistence layer should be storing the encrypted secret, so if that was > > null the

Re: Adding additional APIs to Shindig

Adam, So I suppose sometime in the future this would be something shindig might expose? (even though it's not in the spec) I guess rather than boxing myself in, I'm just wondering if the shindig project did expose an api for this would it do it like current apis and provide a REST and RPC interfa

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8462 --- I think in the event that there's no encrypter available we should set

Re: Adding additional APIs to Shindig

Generally speaking there was nothing done to address the management of gadget bindings and clients externally. On Thu, Jun 21, 2012 at 2:38 PM, Matthew G Marum wrote: > Client Credentials flow was implemented in OAuth 2.0 service provider and > the OAuth 2.0 consumer within Shindig. The clien

Re: Adding additional APIs to Shindig

Client Credentials flow was implemented in OAuth 2.0 service provider and the OAuth 2.0 consumer within Shindig. The client credentials flow is 2 legged. http://docs.opensocial.org/display/OSREF/Running+the+Demo+Gadgets https://cwiki.apache.org/confluence/display/SHINDIG/OAuth+2.0+Service +Provi

Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/ --- Review request for shindig. Description --- Add check for non-null encrypte

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated June 21, 2012, 3:56 p.m.) Review request for shindig and Brian Lillie.

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

> On June 19, 2012, 4:31 p.m., Ryan Baxter wrote: > > Adam I noticed we are lacking some unit tests for this method (and most of > > the class in general). This might be a good opportunity to add some unit > > tests. I agree with you that we need some unit tests here, but (as you're probably

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

> On June 19, 2012, 1:39 p.m., Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java, > > line 182 > > > > > > Could you

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated June 21, 2012, 3:53 p.m.) Review request for shindig and Brian Lillie.

Re: Shindig 2.5.0-beta2 RC3 - Third Time Is A Charm

+1 Smoke tested the sample common container page. Will verify signatures later. Thanks, -Stanton From: Ryan J Baxter/Westford/IBM@Lotus To: dev@shindig.apache.org, Date: 06/20/2012 21:19 Subject:Re: Shindig 2.5.0-beta2 RC3 - Third Time Is A Charm +1 from me I hate to ask