Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8765 --- Ship it! Committed revision 1355574. Thanks Chris. Please close this

Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8756 --- Ship it! Better fix. Like! +1 - Henry Saputra On June 29, 2012, 3

Re: Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe

2012-06-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/#review8754 --- To make it easier to review, please format the patch following the Apa

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8753 --- Ship it! Committed revision 1355476. Please close this review. - St

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/#review8752 --- Ship it! Committed revision 1355472. Please close this review. - St

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8751 --- Ship it! Committed revision 1355468. Please close the review. - Sta

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-29 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/ --- (Updated June 29, 2012, 1:12 p.m.) Review request for shindig, Stanton Sievers a

Re: Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe

2012-06-29 Thread Stanton Sievers
> On March 1, 2012, 7:04 p.m., Henry Saputra wrote: > > I think the scenario is not what the rpc mechanism intend to do. The > > communication between container and gadgets happen between one parent > > window and a child window via iframe. > > Yao Zhang wrote: > Hi Henry, > There is t

Re: Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe

2012-06-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/#review8743 --- Can you look at adding some JUnits around this functionality? I'm alw