Re: Review Request: Refactor oauthpopup feature to use rpc to the container

2012-08-24 Thread Dan Dumont
> On Aug. 24, 2012, 3:16 p.m., Matt Franklin wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js, > > line 132 > > > > > > Is there ever a case where

Re: Review Request: Refactor oauthpopup feature to use rpc to the container

2012-08-24 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6754/ --- (Updated Aug. 24, 2012, 5:56 p.m.) Review request for shindig. Changes ---

Re: Shindig 3.0.0 mobile support Query

2012-08-24 Thread Ryan Baxter
Prashant, next release will actually be 2.5 not 3.0, we changed the version number of the next release to align with the version number of the OpenSocial spec. There is nothing that I can think of off the top of my head that specifically targets mobile in the next release, but that does not mean t

Re: Review Request: Refactor oauthpopup feature to use rpc to the container

2012-08-24 Thread Dan Dumont
> On Aug. 24, 2012, 3:16 p.m., Matt Franklin wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js, > > line 132 > > > > > > Is there ever a case where

Re: Review Request: Refactor oauthpopup feature to use rpc to the container

2012-08-24 Thread Matt Franklin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6754/#review10737 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/java

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

2012-08-24 Thread Adam Clarke
> On Aug. 16, 2012, 8:12 p.m., Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java, > > line 152 > > > > > > Could yo

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

2012-08-24 Thread Adam Clarke
> On Aug. 15, 2012, 12:13 p.m., Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java, > > line 54 > > > > > > Smal

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

2012-08-24 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6436/ --- (Updated Aug. 24, 2012, 1:04 p.m.) Review request for shindig, Stanton Sievers,