> On Aug. 24, 2012, 3:16 p.m., Matt Franklin wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js, > > line 132 > > <https://reviews.apache.org/r/6754/diff/1/?file=145042#file145042line132> > > > > Is there ever a case where a gadget is going to create multiple OAuth > > popups simultaneously? I might be missing something, but it seems like > > this callback management mechanism is only useful in the case that there > > are multiple popups being managed by a single gadget.
If a gadget uses more than 1 endpoint (google and twitter apis), it will process callbacks from the container for both of them. > On Aug. 24, 2012, 3:16 p.m., Matt Franklin wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js, > > line 27 > > <https://reviews.apache.org/r/6754/diff/1/?file=145040#file145040line27> > > > > Under what circumstances is cbid ever expected to be a map? Aren't you > > controlling all ids from here? I messed something up here. Will post an update soon. Thanks for catching that. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6754/#review10737 ----------------------------------------------------------- On Aug. 23, 2012, 9:41 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6754/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2012, 9:41 p.m.) > > > Review request for shindig. > > > Description > ------- > > The container will now handle the launching of oauth requests and fire onopen > and onclose events back into the requesting gadgets. This will allow > container implementations to override the default behavior and possibly > surface them in liteboxes rather than relying on window.open which is often > prevented by popup blockers. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1373834 > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.base/base.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/feature.xml > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/oauthpopup/oauthpopup-test.js > 1373834 > > Diff: https://reviews.apache.org/r/6754/diff/ > > > Testing > ------- > > Fixed up tests for the changes. > > > Thanks, > > Dan Dumont > >
