Re: Emeritus status for inactive members

+1 On Thu, Dec 15, 2011 at 11:58 PM, Mark Weitzel wrote: > +1 > > On Wed, Dec 14, 2011 at 10:49 AM, Henry Saputra >wrote: > > > +1 > > > > On Tuesday, December 13, 2011, Paul Lindner wrote: > > > Hi, > > > > > > I'd like to suggest that people >2y inactive on Shindig move to > Emeritus > > >

Re: [VOTE] Jesse Ciancetta as Apache Shindig Committer

+1 On Wed, Oct 26, 2011 at 6:23 AM, Ate Douma wrote: > +1 (non-binding) > > Ate > > > On 10/25/2011 04:50 PM, Ryan J Baxter wrote: > >> Hello, >> >> I would like to propose that Jesse Ciancetta be granted committer access >> to Shindig along with PMC membership. I have reached out to Jesse >> p

Re: Is Shindig head currently broken?

Try upgrading to maven 3, i was also having problems compiling shindig a few days ago. ~ $ mvn --version Apache Maven 3.0.3 (r1075438; 2011-02-28 23:01:09+0530) 2011/6/29 ๏̯͡๏ Jasvir Nagra > I am unable to build a pristine checkout of trunk. > Hudson appears to be disabled: https://builds.apach

Re: Root webapp?

Hi Davies I've never deployed shindig using the root.war approach, but heres what i have started shindig server as: $ svn co http://svn.apache.org/repos/asf/shindig/trunk/ $ vi shindig.properties container.js web.xml # Make watever changes $ mvn -Prun I don't know how other people deploy shindig

Re: preparing for shindig 3.0.0

+1 But that means Guice 3.0 is not integrated in this? On Thu, Mar 24, 2011 at 10:37 PM, John Hjelmstad wrote: > On Thu, Mar 24, 2011 at 9:01 AM, Paul Lindner wrote: > > > I'd like to get a beta build of shindig 3.0.0 ready soon. > > > > We've gone quite some time on trunk without a release an

Re: guice 3.0-rc3

+1 I vaguely remember some1 pointing out a few bugs in 2.0 where Modules.override() didn't work as expected. The bug fix was checked in and should be available in 3.0. Lets use the new guice. On Thu, Mar 10, 2011 at 10:16 PM, Paul Lindner wrote: > Guice 3.0 is very close to release. To help us

Fwd: [ACTION REQUIRED] www.apache.org/dist/ housekeeping

Please correct me if im wrong. Shindig seems to have 1.0.1 and 2.0.0 releases, so i guess we are ok. Or should we be removing 1.0.1 as 2.0.0 is quite stable ? -- Forwarded message -- From: Mark Thomas Date: Thu, Mar 10, 2011 at 1:46 PM Subject: [ACTION REQUIRED] www.apache.org/dis

Re: Unit Tests For Features

These 2 links might be of some use to you if you have isolated the missing test: http://maven.apache.org/plugins/maven-surefire-plugin/examples/single-test.html http://maven.apache.org/plugins/maven-surefire-plugin/examples/debugging.html On Thu, Mar 3, 2011 at 4:29 AM, Ryan J Baxter wrote: > I

Re: SVN server is down ?

works for me as well. On Wed, Mar 2, 2011 at 8:12 PM, Xandeco, Maxwell wrote: > > It's ok for me. > > De: Evgeny Bogdanov [evgeny.bogda...@epfl.ch] > Enviado: quarta-feira, 2 de março de 2011 11:18 > Para: dev@shindig.apache.org > Assunto: SVN server is do

Re: [VOTE] Approve Jacobo Tarrio as Shindig Committer

+1 On Tue, Feb 8, 2011 at 4:00 AM, Ziv Horesh wrote: > +1 > > > On Mon, Feb 7, 2011 at 2:00 PM, John Hjelmstad wrote: > > > +1 > > > > Voting on own proposal. > > > > On Mon, Feb 7, 2011 at 1:58 PM, Michael Hermanto > >wrote: > > > > > +1 > > > > > > On Mon, Feb 7, 2011 at 1:57 PM, John Hjelms

Re: [VOTE] Approve Mat Mannion for Shindig Commiter/PMC

+1 Thanks Gagan -- The only thing missing in life is background music. -- Gagandeep Singh On Mon, Feb 7, 2011 at 10:28 PM, Han Nguyen wrote: > +1 > > > > From: Paul Lindner > To: dev@shindig.apache.org > Date: 02/07/2011 11:47 AM > Subject:[VOTE]

Re: HTTP ERROR 404

Paste the log of mvn -Prun, most likely some exception is being thrown. On Sat, Jan 29, 2011 at 9:14 PM, Xue-Feng Yang wrote: > > I use Jetty. After build shindig, I copied and pasted > > shindig-server-3.0.0-SNAPSHOT.war > > to webapps directory. > > I move your test.html to webapps/root. http

Re: Question about changing the default container.js file

Does this work: ? Adding your container config to view-source:http://svn.apache.org/repos/asf/shindig/trunk/java/common/pom.xm as an include (like the way container.js is included): container.js my_container.js And giving its path

Re: Build failed in Hudson: Shindig #2131

Sorry i broke the build. Fixing it by removing the extra @Override annotation. On Wed, Jan 19, 2011 at 5:05 PM, Apache Hudson Server < hud...@hudson.apache.org> wrote: > See > > Changes: > > [gagan] Patch by nikhilmadan23 | Issue 378004

Re: what controls the URL rewriting of the embed tag...

Is AbsolutePathReferenceRewriter acting on your gadget? Could be AbsolutePathReferenceRewriter is converting the img to the full src, but not the embed src, which is getting resolved by browser. On Fri, Jan 7, 2011 at 6:53 AM, Mark Weitzel wrote: > Quick question… > > I've got the following html

Re: Build failed in Hudson: Shindig #2087

Sorry, i broke the build because String.isEmpty is present only in java 1.6 Satya is working on a fix. On Tue, Dec 28, 2010 at 4:23 PM, Apache Hudson Server < hud...@hudson.apache.org> wrote: > See > > Changes: > > [gagan] Patch by satya

Re: Creating and submitting a patch

Hi Ryan If you set the reviewers correctly at the time of codereview creating from the web interface, a mail is sent out to the reviewers. dev-remai...@shindig.apache.org is automatically supposed to send the mail to d...@shindig, it might take some time though because of some routing problems. I

Re: Creating a new empty project.

I have not tried a separate setup, but if your getting Guice errors with your current setup, then some bindings must not be available. Try looking at the modules installed in view-source:http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml . Or post some of the

Fwd: Issue 3213042: Injecting Provider allowing it to be overridden

Reviewers: dev@shindig.apache.org Description: Use case: - per container overriding of DefaultConfig. Currently not possible, but with this patch, one should be able to add a provider which can provide different values for DefaultConfig (say for different containers). Here is a sample snippet w

Issue 3146042: Changing mapBinder variable to protected for reuse in subclasses

Reviewers: *...@shindig.apache.org* Description: Another small nit missing in previous submit:http://codereview.appspot.com/3175041/ Please review this at http://codereview.appspot.com/3146042/ Affected files: M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java

Re: Small enhancements to RewriteModule to make it reusable (issue3175041)

I was in a hurry to submit :) On Thu, Nov 18, 2010 at 2:06 AM, wrote: > LGTM (I was curious about the RewritePath not being public) > > > http://codereview.appspot.com/3175041/ >

Issue 3175041: Small enhancements to RewriteModule to make it reusable

Reviewers: dev@shindig.apache.org, fargo >, zhoresh Description: This cl: 1) Makes RewritePath class public (I missed it inhttp://codereview.appspot.com/2058042/) 2) Makes some of the helper methods of RewriteModule protected so other classes that extend RewriteModule can reuse these. Please re

Issue 2770041: Refactoring StyleTagProxyEmbeddedUrlsRewriter to use DefaultConfig instead

Reviewers: dev@shindig.apache.org, Description: Currently StyleTagProxyEmbeddedUrlsRewriter uses the featureConfigFactory to fetch the gadget spec. However, since accel html web pages don't really have a gadget (In AccelHandler.getProxyUri(), we create a dummy gadget object based on the origina

Re: How to append custom rewriter for Shindig?

not enough, you still need to do other same work as DefaultGuiceModule > in your module.Please note that RewriterModule installed in > DefaultGuiceModule is not configured in web.xml. > > Any comments? Thanks a lot. > > Thanks, > > Kevin Zhang (凯峰) > Gtalk: kf.zh...@gma

Re: How to append custom rewriter for Shindig?

Hi Kai, Paul You are both right :) The order of rewriters matters. I have a patch (which JohnH has been reviewing and providing ideas for) which does something simi

Re: Upgrade Caja (issue2737042)

Thanks Jasvir :) On Wed, Oct 27, 2010 at 10:07 PM, wrote: > LGTM++ > > > On 2010/10/27 22:03:04, jasvir wrote: > > > > http://codereview.appspot.com/2737042/ >

Issue 2727042: Making AccelHandler.fetch() public

Reviewers: *...@shindig.apache.org* Description: Please review this at http://codereview.appspot.com/2727042/ Affected files: M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java Thanks Gagan

Issue 2646041: Setting return-original-content-on-error for accel container

Reviewers: *...@shindig.apache.org* Description: Setting returnOriginalContentOnError true for accel container so that ProxyHandler does not throw exceptions and returns original content. When using VanillaCajaHtmlParser, we see the following exception on some pages: org.apache.shindig.gadgets.

Re: container "accel"

. > I'll admit to not digging in this area of the code, so take that with a > grain of salt b/c it may already be like this. > > -Mark W. > > On Sun, Oct 24, 2010 at 12:21 PM, Gagandeep singh >wrote: > > > Hi Chirag > > > > Sorry for the late response,

Re: container "accel"

2/cache-win > http://www.squid-cache.org/ > http://trafficserver.apache.org/docs/v2/admin/reverse.htm > http://trafficserver.apache.org/docs/v2/admin/http.htm > > Thanks, > Chirag > > > > On Mon, Oct 18, 2010 at 6:36 PM, Gagandeep singh > wrote: > > Hi Geral

Re: Build failed in Hudson: Shindig » Apache Shindi g Gadget Renderer #1924

Sorry this cl broke the build because of @Override annotation on ImageAttributeRewriter.revisit(). Committed a fix as r1024097. General doubt: Can we move shindig to java1.6 ? I think this problem occurs because of java 1.5. Alternately, is there an easy way of pointing maven to java 1.5 installat

Re: container "accel"

On Thu, Oct 14, 2010 at 7:55 PM, Zhenhua Guo wrote: > Thanks! > Any brief description (not detailed description, but from high level) > about how content acceleration works in Shindig? Caching? Prefetch? > > Gerald > > On Wed, Oct 13, 2010 at 10:13 PM, Gagandeep singh &g

Re: Different subdomains for each gadget

I don't know understand locked domains much, but one doubt: Do you also disallow scripts from setting document.domain to the parent domain ? Usually the Same Origin policy which prevents different documents from interacting with each other allows interactions once document.domain when set to a par

Re: container "accel"

Hi Zhenhua Like John mentioned, accel container encompasses rewriters and servlets that can be used to accelerate served content. Currently there are some optimizing rewriters like proxying embedded content through shindig host and more are on their way. Maybe once we have some more rewriters, we

Re: Issue 2058042: Refactoring ResponseRewriterRegistry to take into account container

+ d...@shindig as the mail doesn't seem to have gone. On Wed, Oct 13, 2010 at 10:36 AM, Gagandeep singh wrote: > Reviewers: dev@shindig.apache.org > > Description: > > Refactoring ResponseRewriterRegistry to take into account the container of the > request being processed.

Re: Refactor the container configuration (issue2350042)

+ cool-shindig-committers On Sat, Oct 9, 2010 at 1:28 AM, wrote: > Looks good, here are some preliminary comments, I am still looking > > > > http://codereview.appspot.com/2350042/diff/14001/java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java > File > > java/common/src/

Re: Adding an html parser router (issue2119043)

Hi guys Thanks for your valuable comments. I realize that the motivation for this change was not communicated correctly. To give you more insight, we have overridden the GadgetHtmlParser with a similar router which is capable of routing to caja / neko depending on the request context. This is very

Re: Updated few checks in ConcatVisitor, to increase its coverage. (issue2085042)

http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.javahas nice tests for conditional and non conditional comments. On Mon, Oct 4, 2010 at 9:05 PM, wrote: > lgtm, if you could add a follow-on test for conditional comme

Issue 1987047: Forwarding all http request headers when fetching a resource via ProxyHandler

Reviewers: *...@shindig.apache.org*, Description: Currently ProxyHandler just takes in the proxyUri to fetch and totally ignores the http request headers like "User-Agent". This change passes on the HttpRequest object which has all the headers present in original request - Host and Content-Lengt

Issue 2119043: Adding an html parser router

Reviewers: dev-remai...@shindig.apache.org, Description: Adding a GadgetHtmlParserRouter which can route to Caja / Neko parser based on how its is configured. This allows us to do stuff like: @Override public Document parseDomForEncodingDetection(String source) throws GadgetException { f

Re: Debugging shindig in eclipse succeeded with problems

On a side not, i have a pretty decent intellij workflow described here: https://docs.google.com/document/d/1uMf17Bli-CdOnfQGvJhpWED827noikrXBtrP5cb3b9s/edit?hl=en&pli=1# On Mon, Oct 4, 2010 at 1:25 PM, Paul Lindner wrote: > I've seen this in the past where Eclipse will reference the jar files >

Re: Multiple hot deploys and shindig

Hi Pablo I couldn't understand the memory leak you found in Guice. Hopefully crazy bob will fix it soon (it has been 3 months already). As for the shindig shutdown hook, it looks like an innocent hook which tries to stop the executor service which is where all the threads are scheduled. Did you fi

Re: Shindig 2.0 PHP - where to get it?

/shindig/trunk is the latest trunk which is the head where every1 submits changes. It is currently at version 3. If you want version 2, try this page: http://shindig.apache.org/download/index.html On Thu, Sep 23, 2010 at 6:13 PM, Justin Wyllie wrote: > > Just to confirm: > http://svn.apache.org/r

Re: Did not receive emails to dev-remai...@shindig.apache.org for codereview requests

t; > On Mon, Sep 20, 2010 at 9:44 PM, Gagandeep singh >wrote: > > > Maybe Mike did not send out the mail to dev-remailer. When you add a > > reviewer on codereview site, it does not send out the mail. I usually end > > up > > forwarding the original mail (when the cod

Re: Did not receive emails to dev-remai...@shindig.apache.org for codereview requests

Maybe Mike did not send out the mail to dev-remailer. When you add a reviewer on codereview site, it does not send out the mail. I usually end up forwarding the original mail (when the codereview is created) to dev@ To explicitly send out the mail, i think upload.py --send_mail must be used. Other

Re: Issue 2136044: Adding static files back to shindig jar

Reverting this change. Lets find a way to get the important files under content/ directory moved to under features/ directory. Thanks for the review. Gagan On Tue, Sep 14, 2010 at 12:58 AM, Gagandeep singh wrote: > Or are you suggesting keeping content/ directory as is, but adding it

Issue 2220044: Adding cookiebaseduserprefstore.js to gadgets.jar as it is also getting used

Reviewers: dev , Description: Adding back cookiebaseduserprefstore.js to gadgets.jar as it is also getting used in gadgets server. This is a temporary fix whereby we are just making sure that we retain all the files that are currently getting used. A better long term fix would be to move the file

Re: Shindig host/port questions

It might be tough to change the assumption that shindig host and port are not static and could change at runtime with the http request. It might be easier to just add a rewriter that moves the proxied resources from shindig authority to the host/port you want (which is the host port of the HttpRequ

Re: Issue 2136044: Adding static files back to shindig jar

Or are you suggesting keeping content/ directory as is, but adding it to features/pom.xml as resources so gadgets.jar still remains lightweight and features.jar gets these files ? On Sat, Sep 11, 2010 at 11:35 AM, Gagandeep singh wrote: > Hi Paul > > I don't have much idea about

Re: Issue 2136044: Adding static files back to shindig jar

r the old shindig container, the > other bits would make sense to move there as well. > > > On Thu, Sep 9, 2010 at 12:31 PM, Gagandeep singh wrote: > >> Hi Paul >> >> After some investigation, it seems we do use more files. It seems >> cookiebaseduserprefs

Re: Cleaning up javascript with Closure Linter

The patch looks good. A script to split all the files into multiple codereviews could be helpful here. Thanks Gagan On Fri, Sep 10, 2010 at 4:33 PM, Paul Lindner wrote: > A while back I had started cleaning up the javascript code base to use > improved JsDoc annotations. > > Recently the Clo

Re: Issue 2136044: Adding static files back to shindig jar

dig-gadget jar. Let us know if > that helps. > > > On Sat, Sep 4, 2010 at 9:49 AM, Gagandeep singh wrote: > >> We have a test that fails because its not able to find >> container/rpc_relay.html. Not sure if any other files are being actively >> used as well. >>

Re: Last call for 2.0.0

Hi Janusz On Mon, Sep 6, 2010 at 2:55 PM, Janusz Dziemidowicz < janusz.dziemidow...@nasza-klasa.pl> wrote: > On Sat, Sep 4, 2010 at 1:41 AM, Paul Lindner wrote: > > I'll be working on releasing 2.0.0 over the long weekend. There are a > few > > small issues that I'll deal with, but I don't see

Re: Issue 2136044: Adding static files back to shindig jar

We have a test that fails because its not able to find container/rpc_relay.html. Not sure if any other files are being actively used as well. On Sat, Sep 4, 2010 at 9:11 PM, Gagandeep singh wrote: > Sorry for the short and confusing mail. I am not sure whether static files > should be in

Re: Issue 2136044: Adding static files back to shindig jar

not mind this change and indicate what i should be doing instead. Any information would be greatly appreciated. Thanks Gagan On Sat, Sep 4, 2010 at 8:33 PM, Gagandeep singh wrote: > Reviewers: dev@shindig.apache.org, lindner, zhoresh > > Description: > > Adding back static f

Issue 2136044: Adding static files back to shindig jar

Reviewers: dev@shindig.apache.org, lindner, zhoresh Description: Adding back static files removed in revision 991493. See here:http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/pom.xml?r1=991493&r2=...

Re: Adding gagan as a shindig committer :) (issue2106044)

It worked :) Please take a look now. On Thu, Sep 2, 2010 at 9:31 AM, wrote: > LGTM! The COMMITTERS file needs to be updated too. I think this can be > done by running mvn -Pto-committers > > > On 2010/09/02 03:36:07, gagan.goku wrote: > >> On 2010/09/02 03:35:31, anupama.dutta wrote: >> > LGTM :

Re: Issue 2106044: Adding gagan as a shindig committer :)

Thanks Henry :) On Thu, Sep 2, 2010 at 9:36 AM, Henry Saputra wrote: > Welcome Gagan > > - Henry > > On Wed, Sep 1, 2010 at 8:37 PM, Gagandeep singh >wrote: > > > Reviewers: *...@shindig.apache.org* > > * > > * > > Description: > > > > A

Issue 2106044: Adding gagan as a shindig committer :)

(revision 991793) +++ pom.xml (working copy) @@ -347,6 +347,16 @@ PMC Member + + gagan + Gagandeep Singh + ga...@apache.org + ASF + +PMC Member + + + fitz Thanks Gagan

Re: Last call for 2.0.0

Hopefully the container percolation bugs are all fixed now. So one less pain point to worry about. Thanks Gagan 2010/9/1 Pablo Graña > is there anyone out there planning a near future release of a site based on > 2.0.0? > > On Wed, Sep 1, 2010 at 7:21 AM, Paul Lindner wrote: > > > I don't see

Re: Removing charset information from meta http-equiv content type (issue1841045)

Tested by putting the following content-type response header in a gbk encoded website and removing the charset information from Content-Type meta http-equiv tag in firefox: Response header: Content-Type: text/html; charsett=gb2312 Firefox does not render the page correctly (but renders it correct

Re: Hudson build is back to normal : Shindig #1793

params. Isn't that better than LinkedHashMap> ? Thoughts ? On Mon, Aug 30, 2010 at 1:31 PM, Gagandeep singh wrote: > Nice debugging. > > > On Mon, Aug 30, 2010 at 7:42 AM, Paul Lindner wrote: > >> The test output showed that the problem was incorrectly ordered query

Re: Move the style related nodes to top of the head node instead of appending at the end. (issue2013046)

Thanks Paul. -- The only thing missing in life is background music. -- Gagandeep Singh On Tue, Aug 31, 2010 at 1:55 AM, wrote: > committed. > > > > http://codereview.appspot.com/2013046/ >

Issue 1949051: Refactoring ProxyingVisitor so that its functionality can be extended by other visitors

Reviewers: dev@shindig.apache.org Description: Refactoring ProxyingVisitor so that its functionality can be extended by other visitors like: - proxying resources - making url's absolute - prefetching images - domain balancing etc. Please review this at http://codereview.appspot.com/1949051/ Af

Re: shouldn't json-simple jar be removed from shindig?

I remember adding json-simple back by mistake when i was debugging some issues. Turned out my client was not synced correctly. I think its okay to remove it. On Mon, Aug 30, 2010 at 8:29 PM, Paul Lindner wrote: > is it a transitive dependency perhaps? > > On Mon, Aug 30, 2010 at 6:56 AM, Han Ngu

Re: Hudson build is back to normal : Shindig #1793

poked around > UriBuilder and found one remaining use of HashMap and replaced it with > LinkedHashMap. > > On Sun, Aug 29, 2010 at 6:54 PM, Gagandeep singh >wrote: > > > Could you also tell us how you found and fixed the problem ? > > > > On Mon, Aug 30, 2010 at 7:24

Re: Hudson build is back to normal : Shindig #1793

Could you also tell us how you found and fixed the problem ? On Mon, Aug 30, 2010 at 7:24 AM, Gagandeep singh wrote: > Thanks for fixing this Paul. > > > On Mon, Aug 30, 2010 at 2:46 AM, Apache Hudson Server < > hud...@hudson.apache.org> wrote: > >> See <htt

Re: Hudson build is back to normal : Shindig #1793

Thanks for fixing this Paul. On Mon, Aug 30, 2010 at 2:46 AM, Apache Hudson Server < hud...@hudson.apache.org> wrote: > See > > >

Re: Hudson build became unstable: Shindig #1787

This is strange. In my local client synced to head without any modifications, shindig seems to build fine without any breakages (im on Windoze). Why is the CajaCssSanitizerTest failing on hudson machine ? https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/1787/testRepor

Re: [BugFix]: Followup change to pass on container information correctly in all CajaCssSanitizer usages (issue2045041)

Thanks Paul. On Sat, Aug 28, 2010 at 2:31 AM, wrote: > committed > > > On 2010/08/27 16:05:49, jcian wrote: > >> On 2010/08/27 13:45:45, anupama.dutta wrote: >> > Neat change with good tests :) >> > LGTM. >> > Please send to dev@, jcian@, zhoresh@, lindner@ for commit/review. >> > > LGTM too. >

Re: [BugFix] Modifying JsonContainerConfig to add SERVER_HOST and SERVER_PORT env. to all containers (issue2000043)

Thanks for submitting this change as well Paul. Gagan On Fri, Aug 27, 2010 at 6:36 PM, wrote: > yes, you got it. adding the host/port to the default container before > the merge gets you the desired behavior. > > > > http://codereview.appspot.com/243/ >

Issue 2045041: [BugFix]: Followup change to pass on container information correctly in all CajaCssSanitizer usages

Reviewers: dev, jcian, Paul Lindner, zhoresh, mhermanto Description: This is a followup change (following already committed change http://codereview.appspot.com/2004042/). The goal is to pass on the correct gadget context (which includes container) throughout the path of request serving. Current

Re: Adding the html tag context for the ProxyUri resource (issue1966043)

Thanks Paul :) On Fri, Aug 27, 2010 at 6:43 PM, wrote: > lgtm, committing > > http://codereview.appspot.com/1966043/ >

Re: Inline patch available on Shindig trunk version

When codereview.appspot.com throws up and you need to send out your comments, you can go to publish page and copy the comments and paste it in mail :) On Fri, Aug 27, 2010 at 6:34 PM, Paul Lindner wrote: > Hi, > > codereview.appspot.com is acting up on me -- throwing a 500 error when I > try > t

Issue 2006042: Vanilla Caja html parser

Reviewers: *...@shindig.apache.org* Description: Adding a vanilla caja html parser which relies on caja DomParser() and does no fancy business on top of what caja DomParser does. Please review this at http://codereview.appspot.com/2006042/ Affected files: M java/common/conf/shindig.properti

Modifying JsonContainerConfig to add SERVER_HOST and SERVER_PORT environment to all containers (issue2000043)

Reviewers: dev@shindig.apache.org Description: Currently JsonContainerConfig adds SERVER_HOST and SERVER_PORT environment variables only to default container. This change makes it add these variables to all containers configs. Please review this at http://codereview.appspot.com/243/ Affected

Moving HtmlAccelServlet from "default" container to "accel" container (issue1949048)

Reviewers: dev@shindig.apache.org Description: Currently the container for accelerate use case is hardcoded as "default". This change adds a new "accel" container and points HtmlAccelServlet and AccelUriManager to use this container. This change should go in after the bug for percolating container

Fwd: [RESULT] Approve Gagandeep singh as Shindig Committer

=evil-smiley-face.jpg ) On Mon, Aug 23, 2010 at 11:42 AM, Paul Lindner wrote: > The votes are in and Gagandeep singh is approved as an Apache Shindig > Committer > > Congratulations Gagan! > > Votes: +7 binding (Paul, Jasvir, Bastian, Chirag, Michael, Ziv, John), +2 > no

Issue 1841045: Removing charset information from meta http-equiv content type

Reviewers: dev@shindig.apache.org, dev-remai...@shindig.apache.org Description: Adding a rewriter that removes charset information from meta http-equiv content type tag in html. An html document can specify its charset encoding in the html itself which is used by the browsers in case the content t

Issue 1966043: Adding the html tag context for the ProxyUri resource

Reviewers: dev@shindig.apache.org, dev-remai...@shindig.apache.org Description: This change: 1) Adds the html tag (called htmlTagContext) for which the resource is being proxied. 2) Propogates html tag context all the way to HttpRequest. 3) Rewrite html pa

Re: Exceptions when building shindig

Thanks. Its working now :) On Thu, Aug 19, 2010 at 8:47 PM, Paul Lindner wrote: > This issue was fixed this morning. Apologies for the breakage. > > On Thu, Aug 19, 2010 at 8:14 AM, Gagandeep singh >wrote: > > > Hi Maven experts > > > > Im getting the f

Exceptions when building shindig

Hi Maven experts Im getting the following exceptions when building shindig: Is anyone else also getting this error: [INFO] nb warnings: 0, nb errors: 0 [INFO] [compiler:compile {execution: default-compile}] [INFO] No sources to compile [INFO] [resources:testResources {execution: default-testResou

Re: [VOTE] Release Apache Shindig Version 2.0.0-RC2

Hi Jesse * *We have also found similar issues, and started on a similar codereview to address the issue. As you rightly mentioned, the problem is that makeGadget(Uri) does not have the gadget context, and hence the container information. We were pondering ove

Catching recoverable errors in ProxyHandler and returning original results (issue1696059)

Reviewers: zhoresh, johnfargo, chirag Done. Description: Proxy servlet should not throw INTERNAL_SERVER_ERRORS whenever there is a rewriting exception. If it is possible to return the original content and the RETURN_ORIGINAL_CONTENT_ON_ERROR is set as "true", ProxyHandler should return the origin

Issue 1962045: Changes that were reverted in r982090

Reviewers: ,, < zhor...@gmail.com>, "John Hjelmstad" , Description: Small changes that Anupama made in this patch:http://codereview.appspot.com/1855044/show which got reverted in this cl:http://codereview.appspot.com/1696056/show Please review this at http://codereview.appspot.com/1962045/show

Fwd: Fixing ServletUtil.fromHttpServletRequest to take multiple header values for same header name (issue1944044)

Reviewers: dev@shindig.apache.org Description: Currently ServletUtil.fromHttpServletRequest() iterates over all the header names and add the header value returned by getHeader(headerName). But this is buggy because getHeader() method returns only 1 header value, which is almost always the first he

Re: Scheme-less proxy/concat URIs

others): > > > > protected String getScheme(Gadget gadget, String container) { > >// Scheme-relative by default. Override for specific use cases. > >return null; > > } > > > > > > --j > > > > On Thu, Aug 12, 2010 at 5:07 P

Re: Scheme-less proxy/concat URIs

8080%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&debug=0&nocache=0&url=http%3A%2F%2Flocalhost%3A8080%2Fsamplecontainer%2Fexamples%2Fbubble.gif'); > > >> > > > >> > background-repeat: no-repeat; > > >> > > > >> > width: 2

Re: Shindig Is Caching makeRequest Calls

er so that the cache gets invalidated after some time. -- The only thing missing in life is background music. -- Gagandeep Singh On Wed, Aug 11, 2010 at 7:26 AM, Ryan Baxter wrote: > Hi, > > I am using the makeRequest API to make API calls to a URL that returns > an Atom feed, howe

Re: Caja RewriteHtmlStage fails on HTML entities in the URL

> On Thu, Aug 5, 2010 at 9:13 AM, Gagandeep singh > wrote: > > +fargo, zhoresh > > > > Hi Chirag > > > > I have had similar doubts some time back when i thought that proxied / > > concatenated url's emitted by shindig should not have & in th

Re: revisiting @ImplementedBy

Maybe you should vote a +1 here :) On Fri, Aug 6, 2010 at 5:25 AM, Henry Saputra wrote: > Hi Henning, > > Any update about the code review for this proposal? > > - Henry > > On Wed, Jun 16, 2010 at 11:11 AM, Henning Schmiedehausen <

Re: Caja RewriteHtmlStage fails on HTML entities in the URL

+fargo, zhoresh Hi Chirag I have had similar doubts some time back when i thought that proxied / concatenated url's emitted by shindig should not have & in them. However, somewhere i read that when emitting html content, & should be escaped to &

Re: Scheme-less proxy/concat URIs

Hi Mat You could post a snippet of the html which has the scheme-less link, the iframe you are talking about and the culprit in gadget html. That should help dev@ community understand the problem better. Also, you might want to take a look at AbsolutePathReferenceRewriter

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

>From my chat with Mat, he means that patching in http://codereview.appspot.com/1869052/show fixes the problem. Thanks Gagan On Wed, Aug 4, 2010 at 2:08 PM, Mat Mannion wrote: > Thanks; can confirm my problem is now resolved. > > Mat > > On 3 August 2010 22:01, Gaga

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

ses a NullPointerException at DefaultProxyUriManager:92. This change ignores the uri's (and corresponding nodes) which fail to parse. http://codereview.appspot.com/1869052/show On Tue, Aug 3, 2010 at 10:50 PM, Gagandeep singh wrote: > Probably something along these lines would be better: > http://codere

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Probably something along these lines would be better: http://codereview.appspot.com/1869052/show ? <http://codereview.appspot.com/1869052/show> On Tue, Aug 3, 2010 at 9:04 PM, Gagandeep singh wrote: > Hi Mat > > I think this was done to ensure that the node list and reservedUris

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Hi Mat I think this was done to ensure that the node list and reservedUris list stay in sync. But you raise a good point, its probably better to ignore the failing uri and its corresponding node altogether. On Tue, Aug 3, 2010 at 8:27 PM, Mat Mannion wrote: > Hi all, > > The BBC news gadget > (

Re: 406-forbidden error-Japanese Character

Hi Aslum Please give us some more information on how to reproduce the error you are seeing. Recently a bug was fixed in shindig which handled content encodingcorrectly, im wondering if that has something to do with the error your seeing. Please give some

Re: Remove unneeded @imports handling (issue1852041)

On Mon, Jul 26, 2010 at 9:21 AM, wrote: > > StyleTagProxyEmbeddedUrlsVisitorTest.testImportsAndBackgroundUrlsInStyleTag() > is incorrect. According the W3C CSS2 spec > http://www.w3.org/TR/CSS2/syndata.html#at-rules: CSS 2.1 user agents > must ignore any '@import' rule that occurs inside a bloc

Re: Fixing small error in PropertiesModule (issue1883042)

Thanks Paul On Sat, Jul 24, 2010 at 9:42 AM, Paul Lindner wrote: > I broke this, but was, waiting for apache svn to go read/write... It's > back now -- committed. > > > On Fri, Jul 23, 2010 at 8:48 PM, wrote: > >> Reviewers: dev-remailer_shindig.apache.org, >> >> >> >> Please review this at ht

  1   2   >