gt;
>
> Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and
> Stanton Sievers.
>
>
> Summary
> ---
>
> As a general rule, any time anyone is writing a feature using RPC, those
> endpoints should never expect to get a function (or someth
;
> (Updated 2011-11-18 21:56:17)
>
>
> Review request for shindig, Matthew Hatem and Igor Belakovskiy.
>
>
> Summary
> ---
>
> I have added additional lifecycle handlers. My primary use case here is to
> be able to time the different events that take pla
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/
---
(Updated 2011-10-18 19:16:00.617784)
Review request for shindig, Ryan Baxter and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2424/
---
Review request for shindig, Ryan Baxter and Jason Chiang.
Summary
---
Conta
> How does this ever get called? Shouldn't this be called when the
> > gadget calles removeListener? If so it should be called from your router
> > function...right?
>
> Matthew Hatem wrote:
> This allows the container to add and remove listeners, h
> Shouldn't there be a test for removeListener as well?
Yes I will add one.
- Matthew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1615/#review1604
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1615/
---
Review request for shindig and Ryan Baxter.
Summary
---
https://issues.apac
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
(Updated 2011-08-21 03:17:07.524460)
Review request for shindig and Ryan Baxter.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
(Updated 2011-08-20 17:31:02.792917)
Review request for shindig and Ryan Baxter.
t; Same here the function is called registerHidActionsListener
>
> Matthew Hatem wrote:
> The Core Gadget spec is wrong and inconsistent. The API should be
> symmetric with the CommonContainer API which uses 'Handler' not 'Listener'.
>
>
eed to change the name of these as well
Done
- Matthew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1547
-------
On 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
(Updated 2011-08-19 13:56:41.695019)
Review request for shindig and Ryan Baxter.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
(Updated 2011-08-19 01:53:08.369683)
Review request for shindig and Ryan Baxter.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
(Updated 2011-08-19 00:33:54.116967)
Review request for shindig and Ryan Baxter.
che.org/r/1533/diff/2/?file=32941#file32941line584>
> >
> > Same here put takes 2 parameters
should be push(), sorry
- Matthew
---
This is an automatically generated e-mail. To reply, visit:
https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
(Updated 2011-08-16 19:17:05.813686)
Review request for shindig and Ryan Baxter.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
---
Review request for shindig and Ryan Baxter.
Summary
---
Fixes to actions fe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1201/
---
(Updated 2011-08-15 15:08:16.073843)
Review request for shindig, Ryan Baxter and
We have a use case where I have my own instance of the Common Container and
I need access to a gadgets' metadata outside the context of gadget
navigation. Currently the common container keeps a cache/map of gadget
metadata.
We see two potential solutions:
1) Create a lifecycle callback and cache
19 matches
Mail list logo
