Hi guys
Thanks for your valuable comments. I realize that the motivation for this
change was not communicated correctly.
To give you more insight, we have overridden the GadgetHtmlParser with a
similar router which is capable of routing to caja / neko depending on the
request context. This is very
http://codereview.appspot.com/2119043/diff/63001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParserRouter.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParserRouter.java
(right):
http://codereview.appspot.com/2119043/diff/63001/java/gad
Another option is to use a MapBinder. This would allow other modules to
add a custom parser to this independently of the router class.
http://google-guice.googlecode.com/svn/trunk/javadoc/com/google/inject/multibindings/MapBinder.html
http://codereview.appspot.com/2119043/
On 2010/10/05 01:02:01, chirag wrote:
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties
File java/common/conf/shindig.properties (right):
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties#newcode155
java/common/conf/shindi
Wouldn't Google Guice annotations[1] would solve this problem. Example
Bind:
bind(GadgetHtmlParser.class)
.annotatedWith(Names.named("parser-accel"))
.to(CajaHtmlParser.class);
Inject:
@Inject
public Accel(@Named("parser-acce") GadgetHtmlParser parser, ...
http://code.goog
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties
File java/common/conf/shindig.properties (right):
http://codereview.appspot.com/2119043/diff/63001/java/common/conf/shindig.properties#newcode155
java/common/conf/shindig.properties:155: shindig.html.parser=neko
