Re: OAuth2 token expiration and issue times broken

2012-06-12 Thread Ryan J Baxter
OK I checked in the changes to the javadoc. -Ryan From: A Clarke To: dev@shindig.apache.org, Date: 06/12/2012 11:28 AM Subject:Re: OAuth2 token expiration and issue times broken Yes. On Tue, Jun 12, 2012 at 9:36 AM, Ryan J Baxter wrote: > Adam is it just the java

Re: OAuth2 token expiration and issue times broken

2012-06-12 Thread A Clarke
: 06/12/2012 09:04 AM > Subject: Re: OAuth2 token expiration and issue times broken > > > > Looks like I forgot to update the interface javadoc. > > The intention is to use milliseconds now, this made it easier for other > teams to persist and compare values as timestamp

Re: OAuth2 token expiration and issue times broken

2012-06-12 Thread Ryan J Baxter
Adam is it just the javadoc for OAuth2Token.getIssueAt and OAuth2Token.getExpiresAt that needs to be updated? -Ryan From: A Clarke To: dev@shindig.apache.org, Date: 06/12/2012 09:04 AM Subject:Re: OAuth2 token expiration and issue times broken Looks like I forgot to

Re: OAuth2 token expiration and issue times broken

2012-06-12 Thread A Clarke
n't remember the reason > exactly. Adam and Brian, can explain the logic behind this decision. > > > > -Ryan > > > > > From: daviesd > To: shindig , > Date: 06/11/2012 04:15 PM > Subject: OAuth2 token expiration and issue times broken > &g

Re: OAuth2 token expiration and issue times broken

2012-06-12 Thread Ryan J Baxter
Doug, this was intentional I believe, although I can't remember the reason exactly. Adam and Brian, can explain the logic behind this decision. -Ryan From: daviesd To: shindig , Date: 06/11/2012 04:15 PM Subject: OAuth2 token expiration and issue times broken Th

OAuth2 token expiration and issue times broken

2012-06-11 Thread daviesd
The fix for SHINDIG-1732 introduces a bug with the oauth2 token expires and issue times (or at least a documentation change). The time stored in OAuth2Token use to be in seconds (and is documented that way). Now it¹s storing them in milliseconds in TokenAuthorizationResponseHandler. This causes