Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8751 --- Ship it! Committed revision 1355468. Please close the review. -

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-27 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8650 --- Ship it! Ship It! - Adam Clarke On June 26, 2012, 8:33 p.m.,

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-27 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8658 --- Ship it! Please update the JIRA and I'll get this committed.

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-27 Thread Stanton Sievers
On June 27, 2012, 4:54 p.m., Stanton Sievers wrote: Please update the JIRA and I'll get this committed. Thanks. Sorry. Update the JIRA with the patch and grant ASF. - Stanton --- This is an automatically generated e-mail. To

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-26 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/ --- (Updated June 26, 2012, 8:33 p.m.) Review request for shindig. Changes

Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-21 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/ --- Review request for shindig. Description --- Add check for non-null

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-21 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8462 --- I think in the event that there's no encrypter available we should

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-21 Thread Brian Lillie
On June 21, 2012, 7:56 p.m., Adam Clarke wrote: I think in the event that there's no encrypter available we should set the encrypted secret to be the unencrypted secret that was passed in. The persistence layer should be storing the encrypted secret, so if that was null the

OAuth2TokenPersistence

2011-12-21 Thread daviesd
I¹ve implemented my own OAuth2Encrypter and wired it up. However, I never see the secret being encrypted in my persistent store. I noticed OAuth2TokenPersistence has a encryptedSecret (and encryptedMacSecret), but they don¹t really seem to serve any purpose. When my persister¹s insertToken