Re: Review Request: A patch that enables API for updating person data

2012-02-09 Thread Evgeny Bogdanov
16:49 Subject: Re: Review Request: A patch that enables API for updating person data Evgeny, Could you upload the final patch to JIRA for legal purpose? - Henry On Wed, Feb 8, 2012 at 5:26 AM, Stanton Sievers wrote: --- This

Re: Review Request: A patch that enables API for updating person data

2012-02-08 Thread Stanton Sievers
Beat me to it! I just remembered I forgot that step. Evgeny, can you also close the review if you haven't done so already. Thanks, -Stanton From: Henry Saputra To: dev@shindig.apache.org, Date: 02/08/2012 16:49 Subject: Re: Review Request: A patch that enables AP

Re: Review Request: A patch that enables API for updating person data

2012-02-08 Thread Henry Saputra
Evgeny, Could you upload the final patch to JIRA for legal purpose? - Henry On Wed, Feb 8, 2012 at 5:26 AM, Stanton Sievers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3544/#r

Re: Review Request: A patch that enables API for updating person data

2012-02-08 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4900 --- Ship it! Committed r1241890 Thanks! - Stanton On 2012-02-08 12:49

Re: Review Request: A patch that enables API for updating person data

2012-02-08 Thread Evgeny Bogdanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/ --- (Updated 2012-02-08 12:49:18.692350) Review request for shindig. Changes -

Re: Review Request: A patch that enables API for updating person data

2012-02-08 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4898 --- Regarding whitespace, you should not have any trailing whitespace or w

Re: Review Request: A patch that enables API for updating person data

2012-02-08 Thread Evgeny Bogdanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/ --- (Updated 2012-02-08 10:27:44.989959) Review request for shindig. Changes -

Re: Review Request: A patch that enables API for updating person data

2012-02-07 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4864 --- Ship it! lgtm -- modulo trailing whitespace. - Paul On 2012-02-07

Re: Review Request: A patch that enables API for updating person data

2012-02-07 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4862 --- Ship it! Fix the whitespace and you are good to go! - Ryan On 2012

Re: Review Request: A patch that enables API for updating person data

2012-02-07 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4858 --- Ship it! Looks like some whitespace is still popping up, but other th

Re: Review Request: A patch that enables API for updating person data

2012-02-07 Thread Evgeny Bogdanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/ --- (Updated 2012-02-07 10:42:50.013242) Review request for shindig. Changes -

Re: Review Request: A patch that enables API for updating person data

2012-02-02 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4769 --- See inline comments. http://svn.apache.org/repos/asf/shindig/trunk

Re: Review Request: A patch that enables API for updating person data

2012-02-02 Thread Evgeny Bogdanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/ --- (Updated 2012-02-02 10:53:21.630237) Review request for shindig. Changes -

Re: Review Request: A patch that enables API for updating person data

2012-01-24 Thread Ryan Baxter
> On 2012-01-20 16:35:55, Stanton Sievers wrote: > > Small nits on whitespace. > > > > I do have some bigger questions regarding the implementation and maybe > > these are more for the spec group. What's to stop one person from updating > > another person? The rest API says that the User-Id

Re: Review Request: A patch that enables API for updating person data

2012-01-23 Thread Dan Dumont
> On 2012-01-20 16:35:55, Stanton Sievers wrote: > > Small nits on whitespace. > > > > I do have some bigger questions regarding the implementation and maybe > > these are more for the spec group. What's to stop one person from updating > > another person? The rest API says that the User-Id

Re: Review Request: A patch that enables API for updating person data

2012-01-23 Thread Evgeny Bogdanov
> On 2012-01-20 16:35:55, Stanton Sievers wrote: > > Small nits on whitespace. > > > > I do have some bigger questions regarding the implementation and maybe > > these are more for the spec group. What's to stop one person from updating > > another person? The rest API says that the User-Id

Re: Review Request: A patch that enables API for updating person data

2012-01-23 Thread Stanton Sievers
> On 2012-01-20 16:35:55, Stanton Sievers wrote: > > Small nits on whitespace. > > > > I do have some bigger questions regarding the implementation and maybe > > these are more for the spec group. What's to stop one person from updating > > another person? The rest API says that the User-Id

Re: Review Request: A patch that enables API for updating person data

2012-01-23 Thread Evgeny Bogdanov
> On 2012-01-20 16:35:55, Stanton Sievers wrote: > > Small nits on whitespace. > > > > I do have some bigger questions regarding the implementation and maybe > > these are more for the spec group. What's to stop one person from updating > > another person? The rest API says that the User-Id

Re: Review Request: A patch that enables API for updating person data

2012-01-20 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4491 --- Small nits on whitespace. I do have some bigger questions regarding t

Review Request: A patch that enables API for updating person data

2012-01-19 Thread Evgeny Bogdanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/ --- Review request for shindig. Summary --- A patch that enables API for updati