Review Request: Abstracted 2 methods out.

2011-07-29 Thread chris . cal . berkeley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/ --- Review request for shindig, johnfargo and Ziv Horesh. Summary ---

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Ziv Horesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1231 ---

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1232 --- Is there requirement or scenario where these need to be exposed as

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Henry Saputra
Thanks for the reply John. Just want to make sure we add customization point to Shindig as necessary =) - Henry On Fri, Jul 29, 2011 at 2:36 PM, John Hjelmstad fa...@google.com wrote: For various reasons, we happen to use different global symbol names in our use of the config lib. That in turn

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread John Hjelmstad
Agreed, well worth asking. On Fri, Jul 29, 2011 at 4:50 PM, Henry Saputra henry.sapu...@gmail.comwrote: Thanks for the reply John. Just want to make sure we add customization point to Shindig as necessary =) - Henry On Fri, Jul 29, 2011 at 2:36 PM, John Hjelmstad fa...@google.com wrote:

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1234 --- Ship it! Just connect with John with email. LGTM (with changes to

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread johnfargo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1235 --- Committed as r1152402. - johnfargo On 2011-07-30 00:12:24, csong

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread chrissong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/ --- (Updated 2011-07-30 00:12:24.555729) Review request for shindig, johnfargo and