Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2012-01-09 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4265 --- Ship it! Removed extra white space and committed. Thanks Matt! Commi

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2012-01-08 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- (Updated 2012-01-08 23:08:29.278791) Review request for shindig. Changes -

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2012-01-07 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4240 --- /trunk/content/samplecontainer/examples/commoncontainer/index.html

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- (Updated 2011-12-21 17:24:41.770174) Review request for shindig. Changes -

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Ryan Baxter
> On 2011-12-20 14:00:30, Ryan Baxter wrote: > > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, > > line 207 > > > > > > I believe jQuery provides a function that we can use instead of eval >

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
> On 2011-12-20 14:00:30, Ryan Baxter wrote: > > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, > > line 207 > > > > > > I believe jQuery provides a function that we can use instead of eval T

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4040 --- /trunk/content/samplecontainer/examples/commoncontainer/viewControlle

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- (Updated 2011-12-21 16:05:37.642013) Review request for shindig. Changes -

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-20 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4011 --- Matt there is some good cleanup here, thanks! I am just wondering whe

Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-13 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- Review request for shindig. Summary --- As we start to build (and promote t