Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-09-16 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/#review1926 --- Ship it! Committed revision 1171551. - Ryan On 2011-08-12 14:44:17

Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-09-15 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/#review1910 --- Ship it! I'm inclined to add this. It's really hard to test this sin

Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-09-15 Thread Dan Dumont
> On 2011-09-14 22:16:56, Ryan Baxter wrote: > > LGTM Dan. My one concern is that there is existing code that depends on > > the old behavior. Are there any unit tests around this code? Can you > > think of any way to figure out if there is any code that depends on the old > > behavior? Ju

Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-09-14 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/#review1898 --- LGTM Dan. My one concern is that there is existing code that depends

Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-09-07 Thread Dan Dumont
> On 2011-08-08 17:41:59, Dan Dumont wrote: > > Bump for reviewers. I think this one slipped through the cracks. Can I trouble some of you to review this change? - Dan --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-08-12 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/ --- (Updated 2011-08-12 14:44:17.063813) Review request for shindig. Summary -

Re: Review Request: Change osapi._registerMethods to 'last one in wins'

2011-08-08 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/#review1321 --- Bump for reviewers. - Dan On 2011-07-27 21:57:05, Dan Dumont wrote:

Review Request: Change osapi._registerMethods to 'last one in wins'

2011-07-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/ --- Review request for shindig. Summary --- While debugging using a container c