Re: Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-06 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3006/#review3660 --- Committed revision 1210933. - Ryan On 2011-12-04 21:04:16, Ryan Bax

Re: Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-06 Thread Jesse Ciancetta
> On 2011-12-05 19:15:25, Brian Lillie wrote: > > In doFetchConcatResources, if one of the 2nd through nth requests > > encounters an error such that false would be returned, we still have the > > content from the 1st up to the failing request in the > > VerbatimConcatOutputStream, and when we

Re: Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-05 Thread Ryan Baxter
> On 2011-12-05 19:15:25, Brian Lillie wrote: > > In doFetchConcatResources, if one of the 2nd through nth requests > > encounters an error such that false would be returned, we still have the > > content from the 1st up to the failing request in the > > VerbatimConcatOutputStream, and when we

Re: Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-05 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3006/#review3629 --- Ship it! Never seen this one happening but good catch - Henry On 2

Re: Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-05 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3006/#review3628 --- In doFetchConcatResources, if one of the 2nd through nth requests enco

Re: Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-05 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3006/#review3619 --- Ship it! LGTM - Jesse On 2011-12-04 21:04:16, Ryan Baxter wrote: >

Review Request: ConcatProxyServlet sets the HTTP response status after writing the response

2011-12-04 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3006/ --- Review request for shindig, Jesse Ciancetta and Brian Lillie. Summary --- A