Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-24 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1620 --- Ship it! Committed revision 1161323. Please close the JIRA as well.

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-24 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ --- (Updated 2011-08-24 20:14:29.491196) Review request for shindig, Paul Lindner, H

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1603 --- One more thing Li, please create a JIRA and attach the patch to it. T

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-23 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ --- (Updated 2011-08-23 21:47:22.758827) Review request for shindig, Paul Lindner, H

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1598 --- Overall this looks good! Thanks for doing this. Only small nits on e

Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-22 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ --- Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. Summar