Re: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread Ryan J Baxter
o:henry.sapu...@gmail.com] >> Sent: Wednesday, March 21, 2012 1:31 PM >> To: dev@shindig.apache.org >> Subject: Re: Review Request: Fix for SHINDIG-1736 >> >> Dont want to be party pooper but Doug could you attach the patch to >> the JIRA associated with this review? >>

RE: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread Ciancetta, Jesse E.
Thanks for the patch! :) >-Original Message- >From: daviesd [mailto:davi...@oclc.org] >Sent: Wednesday, March 21, 2012 3:11 PM >To: dev@shindig.apache.org >Subject: Re: Review Request: Fix for SHINDIG-1736 > >Thanks for the "newbie" info. :) > > >

Re: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread daviesd
il.com] >> Sent: Wednesday, March 21, 2012 1:31 PM >> To: dev@shindig.apache.org >> Subject: Re: Review Request: Fix for SHINDIG-1736 >> >> Dont want to be party pooper but Doug could you attach the patch to >> the JIRA associated with this review? >> >> - He

Re: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread Henry Saputra
[mailto:henry.sapu...@gmail.com] >>Sent: Wednesday, March 21, 2012 1:31 PM >>To: dev@shindig.apache.org >>Subject: Re: Review Request: Fix for SHINDIG-1736 >> >>Dont want to be party pooper but Doug could you attach the patch to >>the JIRA associated with this review

RE: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread Ciancetta, Jesse E.
extra hoops to jump through... --Jesse >-Original Message- >From: Henry Saputra [mailto:henry.sapu...@gmail.com] >Sent: Wednesday, March 21, 2012 1:31 PM >To: dev@shindig.apache.org >Subject: Re: Review Request: Fix for SHINDIG-1736 > >Dont want to be party pooper bu

Re: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread Henry Saputra
day I will commit it. > > -Ryan > > > > > From:   daviesd > To:     , Paul Lindner , > Cc:     Ryan Baxter > Date:   03/20/2012 11:04 PM > Subject:        Re: Review Request: Fix for SHINDIG-1736 > > > > Thanks Ryan.  How do I go about getting a com

Re: Review Request: Fix for SHINDIG-1736

2012-03-21 Thread Ryan J Baxter
I can commit it. I was also waiting for Paul to take a look at it. If he doesn't get to it by the end of the day I will commit it. -Ryan From: daviesd To: , Paul Lindner , Cc: Ryan Baxter Date: 03/20/2012 11:04 PM Subject: Re: Review Request: Fix for SHINDIG

Re: Review Request: Fix for SHINDIG-1736

2012-03-20 Thread daviesd
Thanks Ryan. How do I go about getting a committer to commit this? I was hoping Paul would review before then, but I'd love to see this get in before the next 2.5 beta. doug On 3/19/12 9:09 AM, "Ryan Baxter" wrote: > > --- > This is an

Re: Review Request: Fix for SHINDIG-1736

2012-03-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4366/#review6070 --- Ship it! LGTM - Ryan On 2012-03-15 17:47:31, Doug Davies wrote: >

Review Request: Fix for SHINDIG-1736

2012-03-15 Thread Doug Davies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4366/ --- Review request for shindig and Paul Lindner. Summary --- This is a fix for