Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-04 Thread Nuwan Bandara
On Wed, Oct 5, 2011 at 12:02 AM, Ryan Baxter wrote: > You just need to add GadgetAminModule to the list of guice modules in the > web.xml. It should be there in trunk, let me know if you are still having > problems. Great Thanks /Nuwan > > > On Tue, Oct 4, 2011 at 2:28 PM, Nuwan Bandara wro

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-04 Thread Ryan Baxter
You just need to add GadgetAminModule to the list of guice modules in the web.xml. It should be there in trunk, let me know if you are still having problems. On Tue, Oct 4, 2011 at 2:28 PM, Nuwan Bandara wrote: > Hi, > > Am getting the following error, anything to do with recent modifications ?

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-04 Thread Nuwan Bandara
Hi, Am getting the following error, anything to do with recent modifications ? I belive we have to bind the GadgetAdminStore to BasicGadgetAdminStore at DefaultGuiceModule ? Regards, /Nuwan 1) No implementation for org.apache.shindig.gadgets.admin.GadgetAdminStore was bound. while locating org

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-02 Thread Ryan Baxter
> On 2011-10-02 01:59:29, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java, > > line 54 > > > > > > Hey Ryan, sorry

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-02 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/ --- (Updated 2011-10-02 19:38:29.569273) Review request for shindig, Paul Lindner, H

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-01 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2247 --- Ship it! With last review comment +1 http://svn.apache.org/repos/as

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-10-01 Thread Ryan Baxter
> On 2011-09-30 22:37:19, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java, > > line 54 > > > > > > Why do we inject

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-30 Thread Henry Saputra
> On 2011-09-30 22:37:19, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java, > > line 54 > > > > > > Why do we inject

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-30 Thread Ryan Baxter
> On 2011-09-30 22:37:19, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java, > > line 54 > > > > > > Why do we inject

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-30 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2240 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-30 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/ --- (Updated 2011-09-30 19:21:13.986376) Review request for shindig, Paul Lindner, H

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-29 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2166 --- We also had some conversation about simplifying the deny allow lists

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2160 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/ --- (Updated 2011-09-27 13:45:13.184769) Review request for shindig, Paul Lindner, H

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-27 Thread Stanton Sievers
> On 2011-09-27 01:03:34, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java, > > line 78 > > > > > > Certainly could,

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-26 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/ --- (Updated 2011-09-27 01:03:42.045590) Review request for shindig, Paul Lindner, H

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-26 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2073 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-23 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2051 --- Feedback inline. http://svn.apache.org/repos/asf/shindig/trunk/conte

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/ --- (Updated 2011-09-23 14:29:37.603780) Review request for shindig, Paul Lindner, H