Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-09 14:25:51, Jesse Ciancetta wrote: > > LGTM > > > > This is an interesting capability -- its too bad we couldn't find a way to > > get it done without two requests though. > > > > I did actually have one other thought about an alternative that could work > > (but again has its o

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3779 --- Ship it! LGTM This is an interesting capability -- its too bad we co

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-08 15:24:35, Jesse Ciancetta wrote: > > Sorry for being late to the review -- this is the first chance I've had to > > really look this over. I have a few concerns with this approach that make > > me wonder if an alternate approach might be more appropriate -- although > > the al

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- (Updated 2011-12-08 17:58:33.234403) Review request for shindig, Dan Dumont and

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-08 15:24:35, Jesse Ciancetta wrote: > > Sorry for being late to the review -- this is the first chance I've had to > > really look this over. I have a few concerns with this approach that make > > me wonder if an alternate approach might be more appropriate -- although > > the al

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3739 --- Sorry for being late to the review -- this is the first chance I've ha

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- (Updated 2011-12-08 15:07:59.683892) Review request for shindig, Dan Dumont and

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- (Updated 2011-12-07 22:41:10.141656) Review request for shindig, Dan Dumont and

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- (Updated 2011-12-07 22:35:19.458402) Review request for shindig, Dan Dumont and

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-06 23:03:02, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 934 > > > > > > I'd rather be checking for a statu

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-07 17:08:05, Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 922 > > > > > > Disclaimer: I don't fully understand th

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3702 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-06 23:03:02, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 934 > > > > > > I'd rather be checking for a statu

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-06 23:03:02, Stanton Sievers wrote: > > Overall this seems OK. > > > > Have you looked at the performance impact here using lifecycle logging? > > > > The extra HTTP round trip could be costly, especially none of the HEAD > > request can be cached and reused by the subsequent

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-06 23:03:02, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 934 > > > > > > I'd rather be checking for a statu

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3687 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-06 23:03:02, Stanton Sievers wrote: > > Overall this seems OK. > > > > Have you looked at the performance impact here using lifecycle logging? > > > > The extra HTTP round trip could be costly, especially none of the HEAD > > request can be cached and reused by the subsequent

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

> On 2011-12-06 23:15:05, Henry Saputra wrote: > > I am not too sure about extra http request to check for existence for URL. > > Can we just check for status code? Henry, what request would you check the status code of? - Ryan --- Thi

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3683 --- I am not too sure about extra http request to check for existence for

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3681 --- Overall this seems OK. Have you looked at the performance impact he

Review Request: Navigating to URLs in the common container has no indication of success or failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/ --- Review request for shindig, Dan Dumont and Stanton Sievers. Summary --- Whe