Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-13 Thread Ryan Baxter
> On 2012-04-12 12:09:52, Ryan Baxter wrote: > > LGTM, have you signed up for Apache/s JIRA deployment? I want to assign > > the JIRA to you and have you upload the final patch to the JIRA granting > > the ASF license before I submit the code. I tried to look for you to > > assign the JIRA t

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-12 Thread Yao Zhang
> On 2012-04-12 12:09:52, Ryan Baxter wrote: > > LGTM, have you signed up for Apache/s JIRA deployment? I want to assign > > the JIRA to you and have you upload the final patch to the JIRA granting > > the ASF license before I submit the code. I tried to look for you to > > assign the JIRA t

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-12 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/#review6873 --- Ship it! LGTM, have you signed up for Apache/s JIRA deployment? I wa

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-11 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/ --- (Updated 2012-04-12 01:47:45.851337) Review request for shindig, Ryan Baxter, Er

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-10 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/#review6825 --- Code looks good. I would suggest you add some unit tests to some of t

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-09 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/ --- (Updated 2012-04-10 03:17:11.958169) Review request for shindig, Ryan Baxter, Er

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-09 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/#review6790 --- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/mai

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-08 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/ --- (Updated 2012-04-09 06:54:36.602784) Review request for shindig, Ryan Baxter, Er

Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-08 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/ --- Review request for shindig, Ryan Baxter, Eric Woods, and Stanton Sievers. Summar

Re: Review Request: Need to support query parameter for Social REST API.

2012-02-06 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/#review4854 --- /trunk/java/social-api/src/main/java/org/apache/shindig/social/openso

Re: Review Request: Need to support query parameter for Social REST API.

2012-02-06 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/ --- (Updated 2012-02-06 21:47:43.400978) Review request for shindig and Eric Woods.

Re: Review Request: Need to support query parameter for Social REST API.

2012-02-06 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/#review4831 --- There seems to be trailing whitespace and some tabs in this patch. Ca

Review Request: Need to support query parameter for Social REST API.

2012-02-06 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/ --- Review request for shindig and Eric Woods. Summary --- We have a use case