Re: Review Request: Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl

2012-03-05 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4135/#review5615 --- Committed as 1297157 - Henry On 2012-03-02 19:56:52, Henry Saputra

Re: Review Request: Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl

2012-03-04 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4135/#review5604 --- Ship it! LGTM - Stanton On 2012-03-02 19:56:52, Henry Saputra wrot

Re: Review Request: Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl

2012-03-02 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4135/ --- (Updated 2012-03-02 19:56:52.007316) Review request for shindig. Changes -

Re: Review Request: Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl

2012-03-02 Thread Henry Saputra
> On 2012-03-02 12:52:49, Stanton Sievers wrote: > > Hi Henry, > > > > You should also remove the logic in > > org.apache.shindig.auth.BlobCrypterSecurityToken.fromToken(SecurityToken) > > where we eat the UnsupportedOperationException when calling getActiveUrl(). > > > > > > I'm also look

Re: Review Request: Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl

2012-03-02 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4135/#review5556 --- Hi Henry, You should also remove the logic in org.apache.shindig.aut

Review Request: Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl

2012-03-01 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4135/ --- Review request for shindig. Summary --- Simplify the SecurityToken.getActiv