Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-28 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/#review2907 --- Ship it! Committed revision 1190438. - Ryan On 2011-10-27 21:05:02

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-27 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/ --- (Updated 2011-10-27 21:05:02.721746) Review request for shindig, Ryan Baxter and

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-27 Thread Dan Dumont
> On 2011-10-27 19:22:25, Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js, > > line 81 > > > > > > The way I like to write this is: > >

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/#review2883 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-27 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/ --- (Updated 2011-10-27 14:00:05.456824) Review request for shindig, Ryan Baxter and

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-27 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/ --- (Updated 2011-10-27 15:45:02.188499) Review request for shindig, Ryan Baxter and

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/#review2879 --- LGTM just one small nit http://svn.apache.org/repos/asf/shindig/trun

Re: Review Request: Selection Service doesn't work correctly in IE8

2011-10-26 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/#review2872 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Review Request: Selection Service doesn't work correctly in IE8

2011-10-26 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/ --- Review request for shindig, Ryan Baxter and Dan Dumont. Summary --- IE8 doe