Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-15 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3937 --- Ship it! Committed r1215011 - Dan On 2011-12-16 00:39:18, Dan Dumo

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-15 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/ --- (Updated 2011-12-16 00:39:18.474507) Review request for shindig, Ryan Baxter, Ja

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-13 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3877 --- Thanks all for the reviews. I plan on committing this on Wednesday, s

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-12 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3861 --- Ship it! Looks good to me. - Stanton On 2011-12-07 16:53:27, Dan D

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-12 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3847 --- LGTM - Jason On 2011-12-07 16:53:27, Dan Dumont wrote: > > ---

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3747 --- Ship it! LGTM - Ryan On 2011-12-07 16:53:27, Dan Dumont wrote: >

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Ryan Baxter
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Dan Dumont
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Ryan Baxter
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3740 --- Spec change: http://code.google.com/p/opensocial-resources/issues/deta

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-08 Thread Dan Dumont
> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > > > > > I thought we were going to allot

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-07 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3718 --- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-07 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/ --- (Updated 2011-12-07 16:53:27.609819) Review request for shindig, Ryan Baxter, Ja

Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

2011-12-07 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/ --- Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers. Summ