Re: Review Request: change if condition in actions_container.js due to runAction function receives an empty array when it calls the registry.getGadgetSites instead of "undefined"

2012-03-08 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4216/#review5728 --- Ship it! Thanks for the patch! committed with revision 1298423. - l

Re: Review Request: change if condition in actions_container.js due to runAction function receives an empty array when it calls the registry.getGadgetSites instead of "undefined"

2012-03-07 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4216/#review5685 --- Please attach your patch to the JIRA and grant apache license. - Dan

Re: Review Request: change if condition in actions_container.js due to runAction function receives an empty array when it calls the registry.getGadgetSites instead of "undefined"

2012-03-07 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4216/#review5684 --- Ship it! LGTM, nice catch. - Dan On 2012-03-07 06:44:46, Yao Zhang

Review Request: change if condition in actions_container.js due to runAction function receives an empty array when it calls the registry.getGadgetSites instead of "undefined"

2012-03-06 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4216/ --- Review request for shindig and Henry Saputra. Summary --- runAction functio