[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wangwei resolved SINGA-21.
--
Resolution: Fixed
> Code Review
> ---
>
> Key: SINGA-21
>
mmit f50d293ff550d5b8ccace9f7e6992865474d0d29 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=f50d293 ]
SINGA-21 Code review 5
review worker.h, worker.cc
- format code
- change shared_ptr to raw ptr for neuralnet objec
mmit 0c6e5c692bb07b481baca004b07b08b2a0601c6e in incubator-singa's branch
refs/heads/master from [~flytosky]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=0c6e5c6 ]
SINGA-21 Code review 5
Move the implementation of template functions back to driver.h from driver.cc.
Otherwise th
mmit 31611759c474826cbc4592841ad653e8aed04bc1 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=3161175 ]
SINGA-21 Code review 5
review neuralnet.h, neuralnet.cc
- format code
- remove unused varaibles: dat
mmit 366e6a82684aff9c0b31e904e3c45dcca2163490 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=366e6a8 ]
SINGA-21 Code review 5
review trainer.cc/h, driver.cc/.h, singa.h, main.cc
- rewrite headers in driver.h
- move
mmit d3e1fca38b97e06ca113369d9a4f583750105a39 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=d3e1fca ]
SINGA-21 Code review 5
review server.h, server.cc
- format code
- remove thread_id field
- rename variables
mmit 134c891abf07b28ed75c2ee403d4698164c12c3e in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=134c891 ]
SINGA-21 Code review 4
review base_layer.h/cc, layer.h/cc, optional_layer.h/cc
- change basic functions in L
mmit 63adbdabbdd22c4a4750819780b8c9f370b7e5d5 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=63adbda ]
SINGA-21 Code review 4
update Makefile.am to support new neurualnet dir layout
>
mmit f99246e7840eb5fcec2918b37736cba0344db19e in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=f99246e ]
SINGA-21 Code review 4
review param.h, param.cc
- ShareFrom(): init vectors by resizing instead of assignning
mmit ae20303620a952033be67cc005765dd985fe5fe2 in incubator-singa's branch
refs/heads/master from [~zhaojing]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=ae20303 ]
SINGA-21 Code review 4
Update layers for RBM.
The CD algorithm follows Hinton's science paper to do samplin
mmit 53de92b7fdf7e6eac58fe86663738377bedfbd36 in incubator-singa's branch
refs/heads/master from Wei Wang
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=53de92b ]
SINGA-21 Code review 4
categorize all layers into 5 types: input, loss, output, neuron and
connection layers.
r
mmit b24f0a32dd55c43b274e021ab4a53011943f83c7 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=b24f0a3 ]
SINGA-21 Code review 3
review cluster.h, cluster.cc
-- change the first Get() of cluster to Setup()
-- chan
mmit 04b24e7fb538e182ad9df6c940189ff0b78c05fe in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=04b24e7 ]
SINGA-21 Code review 3
format following files:
- msg.h, msg.cc
- socket.h, socket.cc
- common.h,
mmit e28b0394c0831b4c6b0933cedc070d4cd000fb47 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=e28b039 ]
SINGA-21 Code review 3
review blob.h, blob.cc
-- wrap all classes/functions into singa namespace
-- remove
mmit d0438b42c9649a480789b5cbd1bdc4dfabf2b63e in incubator-singa's branch
refs/heads/master from Wei Wang
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=d0438b4 ]
SINGA-21 Code review 3
fix a bug in Msg::ParseFormatFrame().
> Code Review
> ---
>
>
mmit 8bf975cbc8fc55a69561d0ae59e232a81923a542 in incubator-singa's branch
refs/heads/master from wang wei
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=8bf975c ]
SINGA-21 Code review
Fix compile warnings and bugs from create_shard.cc of cifar10 example
>
mmit ffa2d66034cef5cb81f73e73b1874736373209bd in incubator-singa's branch
refs/heads/master from [~zhongle]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=ffa2d66 ]
SINGA-21 fix aclocal version problem
> Code Review
> ---
>
> Key: SINGA-21
mmit cfde4718ad2e554425705623830568fb488c in incubator-singa's branch
refs/heads/master from wang wei
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=cfde471 ]
SINGA-21 Code review - 2
Fix a bug caused by gflags version by adding a macro at main.cc to redefine the
namespa
mmit aefc2d4930c22846d4811424eb1b2016f85d86e6 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=aefc2d4 ]
SINGA-21 Code review
review common.h, common.cc
-- remove unused functions
-- refine Metric class
* user do
mmit 28ac509830adda0b26d09526fa4a1e2c2e82a07a in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=28ac509 ]
SINGA-21 Code review
review data_shard.h, data_shard.cc
-- refine Next() functions for reading data shards
--
mmit 7d39f8813d057565224402e230afacb98c8c366b in incubator-singa's branch
refs/heads/master from wang wei
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=7d39f88 ]
SINGA-21 Code Review-2
Rebase to lastest master. This pull request should be at the frontest.
Tested with mnist an
ewing the code should then check if it follows the style.
> If you can setup build tools to do style checks that would be even better.
>
>
> On Wed, Jun 17, 2015 at 1:35 AM, Wang Wei wrote:
> > Hi guys,
> >
> > Please do a code review when you are getting familiar with
roup --> grp, nservers_per_group --> grp_size, target -->
trgt {noformat}.
> Code Review
> ---
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
mmit 0f3a8ff4827d927a0d05b6dc23c2647530aa0f2e in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=0f3a8ff ]
SINGA-21 Code Review
add cpplint tool
> Code Review
> ---
>
> Key: SINGA-21
mmit 767bad29e4362e14341dfdf4e921c07591f88c75 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=767bad2 ]
SINGA-21 Code Review
clean msg.h msg.cc
-- remove BaseMsg interface in msg.h
-- move zmq-related implementation
[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sheng Wang reassigned SINGA-21:
---
Assignee: Sheng Wang
> Code Review
> ---
>
> K
Sheng Wang created SINGA-21:
---
Summary: Code Review
Key: SINGA-21
URL: https://issues.apache.org/jira/browse/SINGA-21
Project: Singa
Issue Type: Task
Reporter: Sheng Wang
Clean the
setup build tools to do style checks that would be even better.
On Wed, Jun 17, 2015 at 1:35 AM, Wang Wei wrote:
> Hi guys,
>
> Please do a code review when you are getting familiar with the current code.
> It is important to make the code clean and easy to read for our first
> releas
Hi guys,
Please do a code review when you are getting familiar with the current code.
It is important to make the code clean and easy to read for our first
release.
We tried to follow the Google's C++ code style initially. But didn't do it
exactly.
If no other suggestions for the co
29 matches
Mail list logo
