[GitHub] zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser

zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser URL: https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359153634 As the parser moved to individual database plugin . The original test case in jdbc common is no longer valid. Should I re

[GitHub] wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question

wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770#issuecomment-359147904 cc @zone1511 ![image](https://user-images.githubusercontent.com/5441976/35180308-80db6564-fde8-11e7-9e03-2d8a

[GitHub] wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question

wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770#issuecomment-359147737 @zone1511 Before anything happens, I recommend you set your GitHub right. Make your avatar display in commit logs her

[GitHub] wu-sheng commented on issue #763: Decouple JDBCURL parser logic from URLParser

wu-sheng commented on issue #763: Decouple JDBCURL parser logic from URLParser URL: https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359147436 > So I just pull request and it will trigger the test or I run junit test locally? but I didnt see any junit test cover sprin

[GitHub] wu-sheng commented on issue #763: Decouple JDBCURL parser logic from URLParser

wu-sheng commented on issue #763: Decouple JDBCURL parser logic from URLParser URL: https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359147348 @zone1511 Sorry for misleading you. You need to push the SPI init later, maybe use a double-check lock in Interceptor can av

[GitHub] wu-sheng commented on issue #720: access AbstractTracerContext from ContextManager

wu-sheng commented on issue #720: access AbstractTracerContext from ContextManager URL: https://github.com/apache/incubator-skywalking/issues/720#issuecomment-359145329 @peng-yongsheng The vote is going to end so. Please take a vote. ---

[GitHub] zone1511 opened a new pull request #770: Decouple JDBCURL parser logic from URLParser question

zone1511 opened a new pull request #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New featu

[GitHub] zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser

zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser URL: https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359024172 @wu-sheng I found if I use `AgentClassLoader.getDefault()` in the service loader, it will throws ```java java.util.Ser

[GitHub] aiqing2171 opened a new issue #769: java.lang.AbstractMethodError: oracle.jdbc.driver.T4CPreparedStatement.unwrap

aiqing2171 opened a new issue #769: java.lang.AbstractMethodError: oracle.jdbc.driver.T4CPreparedStatement.unwrap URL: https://github.com/apache/incubator-skywalking/issues/769 Bug?can not run my application when using skywalking-agent. - Which version of SkyWalking, OS and JRE?

[GitHub] zone1511 commented on issue #720: access AbstractTracerContext from ContextManager

zone1511 commented on issue #720: access AbstractTracerContext from ContextManager URL: https://github.com/apache/incubator-skywalking/issues/720#issuecomment-358904533 current filter approach can work on url filtering only. If i want to filter from MVC framework point of view, it is not

[GitHub] zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser

zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser URL: https://github.com/apache/incubator-skywalking/issues/763#issuecomment-358903320 So I just pull request and it will trigger the test or I run junit test locally? but I didnt see any junit test cover spring