Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-17 Thread Juan Pan
Hi folks E2e test with MySQL storage provider was added, please refer to PR[1]. Look forwards to your review and suggestion. Best wishes, Trista - [1] https://github.com/apache/skywalking/pull/3648 Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 10/14/2019

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-13 Thread Sheng Wu
d be change > through system env, not just values of config items, but including provider > names. You could read skywalking-docker about this. > > > This file should be merged into application.yaml, and it is open to > change. Please submit pull request if you want. > > > &

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-13 Thread Juan Pan
Thanks for your help and review, my next step is to finish related e2e tests. Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 10/10/2019 22:08,Sheng Wu wrote: You have the review comments already. :P Super fast. Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-10 Thread Sheng Wu
r application.yml are two > 1. It could be overrided by system env, which is much more friendly than > config file change. > 2. In our container definition, application yaml file could be change > through system env, not just values of config items, but including provider > names. You

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-10 Thread Juan Pan
Hi, I modified the design and implementation for this improvement based community’s suggestion, and the Pr[1] has been updated, welcome your review. [1] https://github.com/apache/skywalking/pull/3564 Best wishes, Trista Juan Pan panj...@apache.org Juan Pan(Trista), Apache

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-06 Thread Juan Pan
Got it, not yet. Thanks for your prompt reply. :) Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 10/6/2019 18:31,kezhenxu94 wrote: BTW, when i run the integrated tests, i got the following exception, can anyone give me some ideas? As for the exception in

Re:Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-06 Thread kezhenxu94
lication.yaml, and it is open to change. >Please submit pull request if you want. > > > > >ShengWu >ApacheSkyWalking,ShardingSphere,Zipkin > >FromWuSheng'sphone. > > > >-- Original -- >From: Juan Pan Date: Fri,Sep 27,2019 7:14 P

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-10-06 Thread Juan Pan
Hi I raised a pr[1] to do this performance, waiting for your review. BTW, when i run the integrated tests, i got the following exception, can anyone give me some ideas? Regards, Trista [1] https://github.com/apache/skywalking/pull/3564 ``` [ERROR] Failed to execute goal

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-09-30 Thread Sheng Wu
request if you want. > > > > > ShengWu > ApacheSkyWalking,ShardingSphere,Zipkin > > FromWuSheng'sphone. > > > > -- Original -- > From: Juan Pan Date: Fri,Sep 27,2019 7:14 PM > To: dev Subject: Re: Why is `datasource-settings.pr

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-09-30 Thread Juan Pan
Hi everyone, If all properties in the `datasource-settings.properties` are moved into `application.yml`, any property for database could be changed through system env. > How to do that? Given skyWalking use `HikariCP` for JDBC connection, my initial idea is to put all the configurations for

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-09-28 Thread Juan Pan
Thanks for your rely. I will consider about your `better things`. (^_^) Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 09/27/2019 19:20, Sheng Wu wrote: datasource-settings.properties file is loaded by codes, through file name only. But the better things for

Re: Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-09-27 Thread ???? Sheng Wu
datasource-settings.properties file is loaded by codes, through file name only. But the better things for application.yml are two 1. It could be overrided by system env, which is much more friendly than config file change. 2. In our container definition, application yaml file could be change

Why is `datasource-settings.properties` necessary when storage is `MySQL`

2019-09-27 Thread Juan Pan
Hi everyone, I am exploring SkyWalking, and i find when storage is`MySQL, `datasource-settings.properties` is needed to set properties, while all the properties of H2 storage can be set through `application.yml`. Why is `datasource-settings.properties` necessary for MySQL storage? Do