[
https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164249#comment-13164249
]
Alexander Klimetschek commented on SLING-2251:
--
Probably not important, but
We've got some Mock... classes in org.apache.sling.commons.testing.
Generally speaking, these mock the methods the original author needed, and
return null/false for all the rest.
However, there comes a time when someone else needs a Mock of the same class,
but with a few more of the methods
Hi,
I'm not against enhancing the current mocks, however I ran into
similar problems as you and decided to copy the code or create new
mocks. This reduces dependencies and ensures that the mock really
behaves as you expect.
In addition I prefer using jmock (or similar libs) to create mocks on the
Carsten,
Agreed on a preference for runtime mocks (although I find Mockito's syntax much
more readable than JMock, which turns my brain into a pretzel).
But the compile-time mocks I needed in this particular case already existed
(for the most part), so it seemed better to extend them.
Jeff.
OrderedQueue: remove all might leave a stale entry
--
Key: SLING-2323
URL: https://issues.apache.org/jira/browse/SLING-2323
Project: Sling
Issue Type: Bug
Components: Extensions
[
https://issues.apache.org/jira/browse/SLING-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2323.
-
Resolution: Fixed
Fixed in revision 1211442
OrderedQueue: remove all
The recursion selector value for the JsonRenderServlet is limited to
Integer.MAX_VALUE
--
Key: SLING-2324
URL: https://issues.apache.org/jira/browse/SLING-2324
[
https://issues.apache.org/jira/browse/SLING-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-2324:
---
Assignee: Carsten Ziegeler
The recursion selector value for the
[
https://issues.apache.org/jira/browse/SLING-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164415#comment-13164415
]
Carsten Ziegeler commented on SLING-2324:
-
I agree - it's better to handle this
[
https://issues.apache.org/jira/browse/SLING-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso updated SLING-2324:
-
Attachment: SLING-2324-patch.txt
Thanks Carsten, proposed patch attached.
I will happily
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1147/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1147/
See https://builds.apache.org/job/sling-trunk-1.6/changes
[
https://issues.apache.org/jira/browse/SLING-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2324.
-
Resolution: Fixed
Fix Version/s: Servlets Get 2.1.4
Thanks for your patch Antonio
See
https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing-war/1474/
See
https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1474/
See https://builds.apache.org/job/sling-trunk-1.5/changes
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1148/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1148/
See https://builds.apache.org/job/sling-trunk-1.6/changes
See
https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1475/
See
https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing-war/1475/
22 matches
Mail list logo