Re: [COLLECTION] ResoucreCollectionManager

2013-05-09 Thread Carsten Ziegeler
I took me some time to fully grasp this proposal :) (although it's pretty simple). Yes, I'm fine with removing the service + impl completely. What about having a util class like ResourceCollectionUtil.create(Resource parent, String name, Map optionalProperties) ? Carsten 2013/5/7 Amit.. Gupta.

Re: [VOTE] JCR Resource 2.2.8 and Servlets Post 2.3.0

2013-05-09 Thread Carsten Ziegeler
We're still missing one binding vote 2013/5/7 Carsten Ziegeler > +1 > > > 2013/5/7 Carsten Ziegeler > >> Anyone else? >> >> >> 2013/5/3 Antonio Sanso >> >>> +1 >>> >>> On May 3, 2013, at 12:51 PM, Carsten Ziegeler wrote: >>> >>> > Hi, >>> > >>> > we have some important bug fixes and impro

[jira] [Created] (SLING-2862) Firefox browser send text file mime type as plain/text instead of text/plain

2013-05-09 Thread Ondrej Florian (JIRA)
Ondrej Florian created SLING-2862: - Summary: Firefox browser send text file mime type as plain/text instead of text/plain Key: SLING-2862 URL: https://issues.apache.org/jira/browse/SLING-2862 Project:

[jira] [Updated] (SLING-2862) Firefox browser send text file mime type as plain/text instead of text/plain

2013-05-09 Thread Ondrej Florian (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ondrej Florian updated SLING-2862: -- Attachment: SlingFileUploadHandler.java.patch > Firefox browser send text file mime type as

[jira] [Created] (SLING-2863) unable to use taglib version 1.3 out of the box

2013-05-09 Thread Ondrej Florian (JIRA)
Ondrej Florian created SLING-2863: - Summary: unable to use taglib version 1.3 out of the box Key: SLING-2863 URL: https://issues.apache.org/jira/browse/SLING-2863 Project: Sling Issue Type: B

[jira] [Updated] (SLING-2862) Firefox browser send text file mime type as plain/text instead of text/plain

2013-05-09 Thread Ondrej Florian (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ondrej Florian updated SLING-2862: -- Attachment: (was: taglib13.tld.patch) > Firefox browser send text file mime type as pla

[jira] [Updated] (SLING-2863) unable to use taglib version 1.3 out of the box

2013-05-09 Thread Ondrej Florian (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ondrej Florian updated SLING-2863: -- Attachment: taglib13.tld.patch > unable to use taglib version 1.3 out of the box >

[jira] [Updated] (SLING-2862) Firefox browser send text file mime type as plain/text instead of text/plain

2013-05-09 Thread Ondrej Florian (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ondrej Florian updated SLING-2862: -- Attachment: taglib13.tld.patch > Firefox browser send text file mime type as plain/text ins

[jira] [Created] (SLING-2864) taglib 1.3 function's signature is invalid

2013-05-09 Thread Ondrej Florian (JIRA)
Ondrej Florian created SLING-2864: - Summary: taglib 1.3 function's signature is invalid Key: SLING-2864 URL: https://issues.apache.org/jira/browse/SLING-2864 Project: Sling Issue Type: Bug

[jira] [Updated] (SLING-2864) taglib 1.3 function's signature is invalid

2013-05-09 Thread Ondrej Florian (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ondrej Florian updated SLING-2864: -- Attachment: taglib13.tld.patch This patch contains all necessary changes to the taglib13.tld fi

[jira] [Commented] (SLING-2863) unable to use taglib version 1.3 out of the box

2013-05-09 Thread Ondrej Florian (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652940#comment-13652940 ] Ondrej Florian commented on SLING-2863: --- the patch attached to the SLING-2864 contai

Re: support for JSTL 1.2

2013-05-09 Thread Ondrej Florian
Hi Dan, I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly). The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864. I also provided a patch to fix

RE: support for JSTL 1.2

2013-05-09 Thread Dan Klco
Ondrej, Thank you for all of the investigation and patch. I have tested and committed the patch you provided, it looks good. Please let me know if you find anything else. This new Resource Access Tag API is still pretty new. Thanks again! -Dan -Original Message- From: Ondrej Flo

Re: support for JSTL 1.2

2013-05-09 Thread Ondrej Florian
Many Thanks Dan, just a little comment; shouldn't we make the naming of functions / tags more consistent? e.g. there is a function listChildResources but the tag is called listChildren I know this is small thing, but I would try to make the naming to fit the one used by the Resource API whenev

RE: support for JSTL 1.2

2013-05-09 Thread Dan Klco
Ondrej, Entirely agreed. The 1.3 version of the taglibs is not yet released, so we can make changes as necessary. Thanks, Dan -Original Message- From: Ondrej Florian [mailto:onfl...@gmail.com] Sent: Thursday, May 09, 2013 12:26 PM To: dev@sling.apache.org Subject: Re: support for JS

RE: [VOTE] JCR Resource 2.2.8 and Servlets Post 2.3.0

2013-05-09 Thread Mike Müller
+1 best regards mike > -Original Message- > From: Carsten Ziegeler [mailto:cziege...@apache.org] > Sent: Friday, May 03, 2013 12:51 PM > To: dev@sling.apache.org > Subject: [VOTE] JCR Resource 2.2.8 and Servlets Post 2.3.0 > > Hi, > > we have some important bug fixes and improvements to

Re: [COLLECTION] ResoucreCollectionManager

2013-05-09 Thread Alexander Klimetschek
On 09.05.2013, at 10:59, Carsten Ziegeler wrote: > I took me some time to fully grasp this proposal :) (although it's pretty > simple). > > Yes, I'm fine with removing the service + impl completely. What about > having a util class like > ResourceCollectionUtil.create(Resource parent, String nam

Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Event Support #23

2013-05-09 Thread Apache Jenkins Server
See

Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #23

2013-05-09 Thread Apache Jenkins Server
See -- [INFO] [INFO] ---

Build failed in Jenkins: sling-trunk-1.7 #23

2013-05-09 Thread Apache Jenkins Server
See Changes: [dklco] Adding a patch provided by Ondrej Florian to fix the method signatures in the taglib functions and fix a version mismatch between the taglib version and XSD -- [...truncated

Re: [VOTE] JCR Resource 2.2.8 and Servlets Post 2.3.0

2013-05-09 Thread Ian Boston
+1 Ian On 10 May 2013 04:55, Mike Müller wrote: > +1 > best regards > mike > > > -Original Message- > > From: Carsten Ziegeler [mailto:cziege...@apache.org] > > Sent: Friday, May 03, 2013 12:51 PM > > To: dev@sling.apache.org > > Subject: [VOTE] JCR Resource 2.2.8 and Servlets Post 2.3.

Build failed in Jenkins: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #1644

2013-05-09 Thread Apache Jenkins Server
See -- [INFO] [INFO]

Build failed in Jenkins: sling-trunk-1.6 #1644

2013-05-09 Thread Apache Jenkins Server
See Changes: [dklco] Adding a patch provided by Ondrej Florian to fix the method signatures in the taglib functions and fix a version mismatch between the taglib version and XSD -- [...truncate

Re: [COLLECTION] ResoucreCollectionManager

2013-05-09 Thread Carsten Ziegeler
I don't think so, the signature of the ResourceResolver#create method is already: create(Resource parent, String name, Map props), so what should a generic method in ResourceUtil do in addition? Looking at my proposal, the only thing the ResourceCollectionUtil method would do is making sure the cor

[jira] [Commented] (SLING-2861) Include Apache Commons Lang in Dependency Management

2013-05-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653552#comment-13653552 ] Carsten Ziegeler commented on SLING-2861: - I think we shouldn't do this; first of

[VOTE RESULT] JCR Resource 2.2.8 and Servlets Post 2.3.0

2013-05-09 Thread Carsten Ziegeler
Thanks everyone. The vote passed with four binding +1 votes from Ian Boston, Mike Müller, Carsten Ziegeler, and Felix Meschberger and one non binding +1 vote from Antonio Sanso. No other votes have been cast. Thansk and regards Carsten 2013/5/9 Ian Boston > +1 > Ian > > > On 10 May 2013 04:55