Re: HealthCheckExecutor.execute(ServiceReference) ??

2013-12-27 Thread Georg Henzler
I agree, I would definitely not force implementors to provide the method HealthCheck.getMetadata() - I believe it's rarely a good idea to provide meta data programmatically (if we really wanted to have a unique ID, we could add it as service properties like the name or the tags). Additionally,

Re: HealthCheckExecutor.execute(ServiceReference) ??

2013-12-27 Thread Bertrand Delacretaz
Hi Carsten and Georg, I was going to say that I still disagree, but being outnumbered I'd let it go if it's just about a single method that I don't like...and then I reviewed the org.apache.sling.hc.api package once again and it's worse than I thought. You guys both say you don't want metadata in

[jira] [Commented] (SLING-3278) Provide a HealthCheckExecutor service

2013-12-27 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857487#comment-13857487 ] Bertrand Delacretaz commented on SLING-3278: Also, for my use cases I'll need

Re: [RFC] YAMF - Yet Another Model Factory

2013-12-27 Thread Bertrand Delacretaz
Hi Justin, Finally found time to review YAMF. On Thu, Dec 19, 2013 at 6:07 PM, Justin Edelson wrote: > ...I'm calling this YAMF for now, although ideally > we'll just call it Sling Models... +1 for Sling Models, that's consistent with our general naming. My comments, after looking at the wiki

Re: [RT] New Feature Flags API / Impl

2013-12-27 Thread Bertrand Delacretaz
Hi Carsten, On Thu, Dec 19, 2013 at 6:02 AM, Carsten Ziegeler wrote: > ...Everything can be found at: > http://svn.apache.org/repos/asf/sling/whiteboard/feature-flags/ ... Today is Big Reviews Day, finally found time to look at that, thanks for it! It looks good to me for our current needs, her

[jira] [Comment Edited] (SLING-3278) Provide a HealthCheckExecutor service

2013-12-27 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857487#comment-13857487 ] Bertrand Delacretaz edited comment on SLING-3278 at 12/27/13 2:18 PM: --

[jira] [Updated] (SLING-3027) improve Launchpad Karaf features

2013-12-27 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-3027: Description: - break down sling-karaf feature into more fine-grained features for better reusabili

[jira] [Commented] (SLING-3234) Sling buildbot continuous integration

2013-12-27 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857557#comment-13857557 ] Bertrand Delacretaz commented on SLING-3234: http://ci.apache.org/builders/sli

Build failed in Jenkins: sling-contrib-1.6 ยป Apache Sling JCR Resource Security #1111

2013-12-27 Thread Apache Jenkins Server
See -- [INFO] [INFO]

Build failed in Jenkins: sling-contrib-1.6 #1111

2013-12-27 Thread Apache Jenkins Server
See Changes: [olli] SLING-3027 update Karaf to 3.0.0 and Pax Exam to 3.4.0 -- [...truncated 4571 lines...] [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you

Re: [RFC] YAMF - Yet Another Model Factory

2013-12-27 Thread Justin Edelson
Hi Bertrand, On Fri, Dec 27, 2013 at 5:48 AM, Bertrand Delacretaz wrote: > Hi Justin, > > Finally found time to review YAMF. > > On Thu, Dec 19, 2013 at 6:07 PM, Justin Edelson > wrote: >> ...I'm calling this YAMF for now, although ideally >> we'll just call it Sling Models... > > +1 for Sling