Re: SLING-3203 - rejecting POST/delete if any selector, extension or suffix?

2014-01-22 Thread Felix Meschberger
Hi As noted in the issue: I agree that we should do this. I am not sure about the 404 response. How about 409/CONFLICT or 403/FORBIDDEN ? Finally: Lets consider not allowing selector, extension, and suffix on all requests handled by the SlingPostServlet ? Regards Felix Am 21.01.2014 um 14:44

[jira] [Commented] (SLING-3203) Post servlet's delete operation deletes parent of nonexisting node

2014-01-22 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878438#comment-13878438 ] Bertrand Delacretaz commented on SLING-3203: I agree that something worse than

Re: [VOTE] Apache Sling Event 3.3.4

2014-01-22 Thread Felix Meschberger
+1 Regards Felix Am 21.01.2014 um 20:45 schrieb Carsten Ziegeler cziege...@apache.org: Hi, I just discovery a regression bug in the eventing (SLING-3329). Therefore I would like to call for a vote with a fix: Staging repository:

Re: Health Check Core Release?

2014-01-22 Thread Bertrand Delacretaz
Hi, On Wed, Jan 22, 2014 at 2:18 AM, Carsten Ziegeler cziege...@apache.org wrote: I'm planning to cut a health check core release, do we have any open issues? There's SLING-3321, I'm not happy with the current executor behavior w.r.t slow health checks and caching. We can release without

Re: [VOTE] Apache Sling Event 3.3.4

2014-01-22 Thread Ian Boston
+1 Ian On 22 January 2014 09:31, Tommaso Teofili tommaso.teof...@gmail.com wrote: +1 Tommaso 2014/1/21 Carsten Ziegeler cziege...@apache.org Hi, I just discovery a regression bug in the eventing (SLING-3329). Therefore I would like to call for a vote with a fix: Staging repository:

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

2014-01-22 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878558#comment-13878558 ] Chetan Mehrotra commented on SLING-3049: I need to rework the pull request.

[jira] [Resolved] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

2014-01-22 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved SLING-3049. Resolution: Won't Fix Fix Version/s: (was: Commons Log 4.0.0) Resolving as

Re: SLING-3203 - rejecting POST/delete if any selector, extension or suffix?

2014-01-22 Thread Dominik Süß
I just checked the RFC for statuscodes and 403 seems appropriate while 409 seems to be wrong. Although you could argue the user can resolve the conflict by changing the URI the new URI has a new target (since the URI does not know about concepts like selectors or suffixes) and therefore is a

Re: SLING-3203 - rejecting POST/delete if any selector, extension or suffix?

2014-01-22 Thread Felix Meschberger
Hi Am 22.01.2014 um 13:12 schrieb Dominik Süß dominik.su...@gmail.com: I just checked the RFC for statuscodes and 403 seems appropriate while 409 seems to be wrong. Although you could argue the user can resolve the conflict by changing the URI the new URI has a new target (since the URI does

[jira] [Resolved] (SLING-3203) Post servlet's delete operation deletes parent of nonexisting node

2014-01-22 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-3203. Resolution: Fixed Fix Version/s: Servlets Post 2.3.4 Assignee:

Re: SLING-3203 - rejecting POST/delete if any selector, extension or suffix?

2014-01-22 Thread Bertrand Delacretaz
Thanks everybody for your suggestions, I have now implemented SLING-3203 using status code 403 with a descriptive message. And an integration test. -Bertrand

buildbot failure in ASF Buildbot on sling-trunk

2014-01-22 Thread buildbot
The Buildbot has detected a new failure on builder sling-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/sling-trunk/builds/159 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: osiris_ubuntu Build Reason: scheduler Build Source

Re: Health Check Core Release?

2014-01-22 Thread Carsten Ziegeler
Thanks, ok I'll start the vote either on Friday or next Monday. Carsten 2014/1/22 Bertrand Delacretaz bdelacre...@apache.org Hi, On Wed, Jan 22, 2014 at 2:18 AM, Carsten Ziegeler cziege...@apache.org wrote: I'm planning to cut a health check core release, do we have any open issues?

Re: [FeatureFlags] Handling of sling:features property

2014-01-22 Thread Felix Meschberger
Hi I am ok, this is easy to implement and I am fine with using - as the indicator — we also use that prefix to indicate URLs which don't need authentication (AuthConstants.AUTH_REQUIREMENTS). Regards Felix Am 22.01.2014 um 15:04 schrieb Carsten Ziegeler cziege...@apache.org: @Felix, wdyt?

Re: [FeatureFlags] Handling of sling:features property

2014-01-22 Thread Carsten Ziegeler
Great, thanks, yeah I'm fine with - Final question, is this still an OR then? So if you have [-A, -B] or [-A, B] what does it mean? Carsten 2014/1/22 Felix Meschberger fmesc...@adobe.com Hi I am ok, this is easy to implement and I am fine with using - as the indicator — we also use that

Re: [FeatureFlags] Handling of sling:features property

2014-01-22 Thread Bertrand Delacretaz
On Wed, Jan 22, 2014 at 4:05 PM, Carsten Ziegeler cziege...@apache.org wrote: ...Final question, is this still an OR then? So if you have [-A, -B] or [-A, B] what does it mean?... I think we agree on OR so to me [-A, -B] means this resource is visible if feature A is disabled OR feature B is

Re: [FeatureFlags] Handling of sling:features property

2014-01-22 Thread Carsten Ziegeler
Great, I'm fine with this - I just want to make sure that we're all on the same page :) Carsten 2014/1/22 Bertrand Delacretaz bdelacre...@apache.org On Wed, Jan 22, 2014 at 4:05 PM, Carsten Ziegeler cziege...@apache.org wrote: ...Final question, is this still an OR then? So if you have

RE: [VOTE] Apache Sling Event 3.3.4

2014-01-22 Thread Mike Müller
+1 best regards mike -Original Message- From: Carsten Ziegeler [mailto:cziege...@apache.org] Sent: Tuesday, January 21, 2014 8:45 PM To: dev@sling.apache.org Subject: [VOTE] Apache Sling Event 3.3.4 Hi, I just discovery a regression bug in the eventing (SLING-3329). Therefore I

Re: [FeatureFlags] Handling of sling:features property

2014-01-22 Thread Felix Meschberger
+1 to both. Regards Felix Am 22.01.2014 um 16:34 schrieb Carsten Ziegeler cziege...@apache.org: Great, I'm fine with this - I just want to make sure that we're all on the same page :) Carsten 2014/1/22 Bertrand Delacretaz bdelacre...@apache.org On Wed, Jan 22, 2014 at 4:05 PM,

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2014-01-22 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878876#comment-13878876 ] Justin Edelson commented on SLING-2938: --- Doing the same thing at build time would

[jira] [Assigned] (SLING-3313) Provide annotation-driven approach to create Model objects

2014-01-22 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-3313: - Assignee: Justin Edelson Provide annotation-driven approach to create Model objects

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2014-01-22 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878882#comment-13878882 ] Konrad Windszus commented on SLING-2938: I see, thanks for the explanation. When

[jira] [Resolved] (SLING-3313) Provide annotation-driven approach to create Model objects

2014-01-22 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3313. --- Resolution: Fixed initial version committed in r1560437 Provide annotation-driven approach

Re: [VOTE] Apache Sling API 2.5.0

2014-01-22 Thread Justin Edelson
+1 On Mon, Jan 20, 2014 at 8:57 PM, Carsten Ziegeler cziege...@apache.org wrote: Hi, its finally time for a new API release, we didn't have one for a long time: https://issues.apache.org/jira/browse/SLING/fixforversion/12324378 Staging repository:

Re: [jira] [Resolved] (SLING-3313) Provide annotation-driven approach to create Model objects

2014-01-22 Thread Bertrand Delacretaz
On Wed, Jan 22, 2014 at 6:39 PM, Justin Edelson (JIRA) j...@apache.org wrote: Justin Edelson resolved SLING-3313. .. Resolution: Fixed ... Are you planning to add some docs? Even something as basic as http://sling.apache.org/documentation/bundles/caching-services.html helps people find out

Re: rename YAMF to Sling Models

2014-01-22 Thread Justin Edelson
FYI - I have completed this move. On Fri, Jan 10, 2014 at 11:28 AM, Justin Edelson jus...@justinedelson.com wrote: I'd like to move YAMF from my whiteboard in to extensions and rename it as Sling Models. https://issues.apache.org/jira/browse/SLING-3313 Please speak up if you have an

Re: [jira] [Resolved] (SLING-3313) Provide annotation-driven approach to create Model objects

2014-01-22 Thread Justin Edelson
Hi, On Wed, Jan 22, 2014 at 1:26 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: On Wed, Jan 22, 2014 at 6:39 PM, Justin Edelson (JIRA) j...@apache.org wrote: Justin Edelson resolved SLING-3313. .. Resolution: Fixed ... Are you planning to add some docs? Even something as

Server Side Tests - do we need two separate projects?

2014-01-22 Thread Justin Edelson
Hi, I was setting up the server side tests for Sling Models in Subversion and wanted to raise this concern now that I have a concrete example to point to. When using Sling's JUnit Server Side support, I think you need two projects: The first project

Re: Health Check Core Release?

2014-01-22 Thread Carsten Ziegeler
I've just committed a potential fix for SLING-3321 (Jira is currently down so I'll update the issue later). The result is now only put into the cache, if it's a real result - a timeout result is never cached. As soon as the future now finishes, the result is put into the cache and the future is