[jira] [Updated] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-12 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-5721: - Description: At the moment it is already possible to map child resources via @ChildResource to a

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-12 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281945#comment-15281945 ] Georg Henzler commented on SLING-5721: -- There are two open questions from my side (also see comments

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-12 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281940#comment-15281940 ] Georg Henzler commented on SLING-5721: -- [~kwin] Thanks for your comments in the pull request. I

Re: Splitting up sling-testing-tools

2016-05-12 Thread Andrei Dulvac
Hi, I think the artifact name and the packages should stay different. my whole idea was for the org.apache.sling.testing namespace to be for functional or integration testing. the Junit rules are tied to the org.apache.testing.clients and they're meant to be used for IT tests. that's my 2 cents.

Re: Splitting up sling-testing-tools

2016-05-12 Thread Konrad Windszus
Now the junit/rules module has the artifact id "org.apache.sling.testing.rules" while all other artifacts in that location have something like "org.apache.sling.junit.*". I think we should consolidate that. Also the packages in the new junit/rules are named

[jira] [Commented] (SLING-5724) Teleporter: Use o.a.s.testing.clients instead of custom HTTP requests in TeleporterHttpClient

2016-05-12 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281539#comment-15281539 ] Bertrand Delacretaz commented on SLING-5724: I disagree - SLING-5715 is fixed AFAICS, and

Re: Splitting up sling-testing-tools

2016-05-12 Thread Andrei Dulvac
Hi Konrad, Absolutely these should be merged and the plan is to remove the sling-testing-tools dep altogether. I will take a look. - Andrei On Thu, May 12, 2016 at 3:01 PM Konrad Windszus wrote: > I also just observed that the WebconsoleClient still has a dependency > towards

Re: Splitting up sling-testing-tools

2016-05-12 Thread Konrad Windszus
I also just observed that the WebconsoleClient still has a dependency towards testing.tools. I created a bug report in https://issues.apache.org/jira/browse/SLING-5725 . > On 12 May 2016, at 14:14, Konrad Windszus wrote: > >

[jira] [Created] (SLING-5725) New artifact org.apache.sling.testing.clients still has dependency on org.apache.sling.testing.tools

2016-05-12 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-5725: -- Summary: New artifact org.apache.sling.testing.clients still has dependency on org.apache.sling.testing.tools Key: SLING-5725 URL:

[jira] [Commented] (SLING-5677) Provide default customizer for executing TeleporterRule tests

2016-05-12 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281480#comment-15281480 ] Bertrand Delacretaz commented on SLING-5677: bq. it would only make sense to split up between

[jira] [Commented] (SLING-5677) Provide default customizer for executing TeleporterRule tests

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281473#comment-15281473 ] Konrad Windszus commented on SLING-5677: [~bdelacretaz] Thanks for the review. Regarding splitting

[jira] [Commented] (SLING-5677) Provide default customizer for executing TeleporterRule tests

2016-05-12 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281462#comment-15281462 ] Bertrand Delacretaz commented on SLING-5677: I'll comment here to avoid spreading things

Re: Splitting up sling-testing-tools

2016-05-12 Thread Konrad Windszus
Just had a closer look at those classes and to me the difference between WebconsoleClient and OsgiConsoleClient is not really obvious. Shouldn't we rather merge those two? Konrad > On 04 May 2016, at 14:47, Andrei Dulvac wrote: > > Hi, > > Thanks Radu for applying the

[jira] [Commented] (SLING-5719) Missing isLive() test before closing ResourceResolver

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281449#comment-15281449 ] Konrad Windszus commented on SLING-5719: {{SlingContext.resourceResolver}} will always return the

[jira] [Resolved] (SLING-5715) Random NoRouteToHostException in Teleporter Client MultipartAdapter method

2016-05-12 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-5715. Resolution: Fixed Fix Version/s: JUnit Tests Teleporter 1.0.8 I have

[jira] [Updated] (SLING-5724) Teleporter: Use o.a.s.testing.clients instead of custom HTTP requests in TeleporterHttpClient

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5724: --- Description: Instead of having another client which deals with installing/uninstalling

[jira] [Updated] (SLING-5724) Teleporter: Use o.a.s.testing.clients instead of custom HTTP requests in TeleporterHttpClient

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5724: --- Summary: Teleporter: Use o.a.s.testing.clients instead of custom HTTP requests in

[jira] [Commented] (SLING-5724) Teleporter: Use o.a.s.testing.clients.osgi.OsgiConsoleClient instead of TeleporterHttpClient

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281438#comment-15281438 ] Konrad Windszus commented on SLING-5724: That change would also ease implementing SLING-5681. >

[jira] [Created] (SLING-5724) Teleporter: Use o.a.s.testing.clients.osgi.OsgiConsoleClient instead of TeleporterHttpClient

2016-05-12 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-5724: -- Summary: Teleporter: Use o.a.s.testing.clients.osgi.OsgiConsoleClient instead of TeleporterHttpClient Key: SLING-5724 URL: https://issues.apache.org/jira/browse/SLING-5724

[jira] [Commented] (SLING-5679) Move interface Customizer and customize() from junit.core to junit.teleporter

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281433#comment-15281433 ] Konrad Windszus commented on SLING-5679: The attached PR shows a backwards incompatible change.

[GitHub] sling pull request: SLING-5679 move Customizer to teleporter bundl...

2016-05-12 Thread kwin
GitHub user kwin opened a pull request: https://github.com/apache/sling/pull/140 SLING-5679 move Customizer to teleporter bundle You can merge this pull request into a Git repository by running: $ git pull https://github.com/kwin/sling SLING-5679-refactorcustomizer

[jira] [Assigned] (SLING-5679) Move interface Customizer and customize() from junit.core to junit.teleporter

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-5679: -- Assignee: Konrad Windszus > Move interface Customizer and customize() from junit.core

[jira] [Commented] (SLING-5677) Provide default customizer for executing TeleporterRule tests

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281415#comment-15281415 ] Konrad Windszus commented on SLING-5677: [~bdelacretaz] Could you have a look at the attached PR

[GitHub] sling pull request: SLING-5677 provide a default customizer levera...

2016-05-12 Thread kwin
GitHub user kwin opened a pull request: https://github.com/apache/sling/pull/139 SLING-5677 provide a default customizer leveraging system properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/kwin/sling

[jira] [Updated] (SLING-5723) includeDependencyPrefix(...), excludeDependencyPrefix(...) and embeddedClass(...) should be accessible from Teleporter

2016-05-12 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5723: --- Description: Similar to {{Teleporter.withResources(...)}} also the methods #

[jira] [Created] (SLING-5723) includeDependencyPrefix(...), excludeDependencyPrefix(...) and embeddedClass(...) should be accessible from Teleporter

2016-05-12 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-5723: -- Summary: includeDependencyPrefix(...), excludeDependencyPrefix(...) and embeddedClass(...) should be accessible from Teleporter Key: SLING-5723 URL:

[jira] [Commented] (SLING-5715) Random NoRouteToHostException in Teleporter Client MultipartAdapter method

2016-05-12 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281364#comment-15281364 ] Bertrand Delacretaz commented on SLING-5715: I have added a test at

[jira] [Assigned] (SLING-5701) ChunkCleanUpTask runs into an endless loop with empty chunks

2016-05-12 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-5701: --- Assignee: Carsten Ziegeler > ChunkCleanUpTask runs into an endless loop with empty

[jira] [Resolved] (SLING-5701) ChunkCleanUpTask runs into an endless loop with empty chunks

2016-05-12 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5701. - Resolution: Fixed Applied the patch > ChunkCleanUpTask runs into an endless loop with

[jira] [Resolved] (SLING-5722) Script engine factory is registered twice

2016-05-12 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-5722. - Resolution: Fixed SPI mapping file (and unnecessary {{LICENSE}} and {{NOTICE}} files) removed in

[jira] contributors need to be added to jira roles to be able do to things

2016-05-12 Thread Bertrand Delacretaz
Hi, AFAIK the ASF jira instance security was tightened recently due to spam attempts. As a result people might be unable to write to the SLING jira project unless they're added to that project's list of contributors in the SLING jira "roles" config. PMC members should be able to use

[jira] [Created] (SLING-5722) Script engine factory is registered twice

2016-05-12 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-5722: --- Summary: Script engine factory is registered twice Key: SLING-5722 URL: https://issues.apache.org/jira/browse/SLING-5722 Project: Sling Issue Type: Bug

[jira] [Commented] (SLING-5702) SlingFileUploadHandler creates unnecessary chunk when upload part is empty

2016-05-12 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281268#comment-15281268 ] Carsten Ziegeler commented on SLING-5702: - Looking at the code, I don't see how this can happen,

[GitHub] sling pull request: SLING-5721 Provide @ValueMapObject to inject c...

2016-05-12 Thread ghenzler
GitHub user ghenzler opened a pull request: https://github.com/apache/sling/pull/138 SLING-5721 Provide @ValueMapObject to inject custom types for a ValueMap value See https://issues.apache.org/jira/browse/SLING-5721 You can merge this pull request into a Git repository by

[GitHub] sling pull request: SLING-4417 now the the default for immediate i...

2016-05-12 Thread ghenzler
Github user ghenzler closed the pull request at: https://github.com/apache/sling/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-12 Thread Georg Henzler (JIRA)
Georg Henzler created SLING-5721: Summary: Extend Sling Models to allow mapping of ValueMap values to custom types Key: SLING-5721 URL: https://issues.apache.org/jira/browse/SLING-5721 Project: Sling