[jira] [Resolved] (SLING-8059) CMS - UI - Version Actions Broken

2018-10-29 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8059. - Resolution: Fixed Fixed with commit

[jira] [Created] (SLING-8059) CMS - UI - Version Actions Broken

2018-10-29 Thread Dan Klco (JIRA)
Dan Klco created SLING-8059: --- Summary: CMS - UI - Version Actions Broken Key: SLING-8059 URL: https://issues.apache.org/jira/browse/SLING-8059 Project: Sling Issue Type: Bug Affects Versions:

Re: [VOTE] Release Apache Sling Engine 2.6.16

2018-10-29 Thread Daniel Klco
+1 On Mon, Oct 29, 2018 at 10:47 AM Robert Munteanu wrote: > On Mon, 2018-10-29 at 15:29 +0100, Julian Sedding wrote: > > Please vote to approve this release: > > +1 > > Robert >

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-29 Thread Stefan Egli
Right, Sling Jobs can help in defining the deprecation, which is exactly what I've use it for now. (btw: I went even further in restricting the API, as I think retryJobById and getJobById are potentially expensive as well, thus lean towards deprecating those too - not sure about

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-29 Thread Carsten Ziegeler
Hi, we already have a job API 2.0 (in commons I think) - but that's another proprietary API which knowone outside of this circle knows about. Deprecating means reducing complexity and making eventually the implementation easier while at the same time having at least some form of

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-29 Thread Timothee Maret
Hi, This thread reminds me that Ian built Sling Jobs module [0]. IIUC from reading the project readme, Sling Jobs design focused on supporting the APIs from the Sling Events module that can be implemented efficiently on a messaging system. I am thinking that the Sling Jobs API could help

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-29 Thread Robert Munteanu
Hi Stefan, On Mon, 2018-10-29 at 14:47 +0100, Stefan Egli wrote: > Hi, > > I'd like to reactivate SLING-5884 and a related discussion [1] we > had > about deprecating the query part of the Sling Event API. > > TL;DR: Open question is exactly which of the JobManager methods do > we > want to

Re: [VOTE] Release Apache Sling Engine 2.6.16

2018-10-29 Thread Robert Munteanu
On Mon, 2018-10-29 at 15:29 +0100, Julian Sedding wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[VOTE] Release Apache Sling Engine 2.6.16

2018-10-29 Thread Julian Sedding
Hi, We solved 1 issue in the Sling Engine 2.6.16 release: https://issues.apache.org/jira/projects/SLING/versions/12343879 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2002/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Commented] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-10-29 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667273#comment-16667273 ] Julian Sedding commented on SLING-8047: --- [~mundt] could you please check if the fix on [my fork of

[jira] [Commented] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-10-29 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667243#comment-16667243 ] Karl Pauls commented on SLING-8058: --- We should make sure we clean-up the ArtifactsMojo as well (added

[jira] [Comment Edited] (SLING-8038) Allow the Repository MOJO specify including features from CLI

2018-10-29 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667239#comment-16667239 ] Karl Pauls edited comment on SLING-8038 at 10/29/18 1:54 PM: - I merged the PR

[jira] [Resolved] (SLING-8038) Allow the Repository MOJO specify including features from CLI

2018-10-29 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-8038. --- Resolution: Fixed I merged the PR from Dominik Suess:

[jira] [Assigned] (SLING-8038) Allow the Repository MOJO specify including features from CLI

2018-10-29 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-8038: - Assignee: Karl Pauls > Allow the Repository MOJO specify including features from CLI >

[GitHub] karlpauls closed pull request #15: Issue/sling 8038

2018-10-29 Thread GitBox
karlpauls closed pull request #15: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[jira] [Commented] (SLING-5884) Deprecate JobManager methods which allow to manage the queue

2018-10-29 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667228#comment-16667228 ] Stefan Egli commented on SLING-5884: Revived discussion in a new thread:

[DISCUSS] Deprecate query part of Sling Event API

2018-10-29 Thread Stefan Egli
Hi, I'd like to reactivate SLING-5884 and a related discussion [1] we had about deprecating the query part of the Sling Event API. TL;DR: Open question is exactly which of the JobManager methods do we want to deprecate. The idea is to deprecate (and sometime in the future - timing tbd -

[jira] [Resolved] (SLING-8051) Timing issue in SlingMainServlet

2018-10-29 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-8051. --- Resolution: Fixed Fix Version/s: Engine 2.6.16 > Timing issue in SlingMainServlet >

[jira] [Commented] (SLING-8051) Timing issue in SlingMainServlet

2018-10-29 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667205#comment-16667205 ] Julian Sedding commented on SLING-8051: --- Thanks [~rombert] for your comment. I have tested some

[GitHub] DominikSuess commented on issue #14: Issue/sling 8038

2018-10-29 Thread GitBox
DominikSuess commented on issue #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#issuecomment-433888619 @cziegeler - replacing with PR-15 with updated commit sequence (moving the abstraction into own subsequent commit for ease of reuse.

[GitHub] DominikSuess opened a new pull request #15: Issue/sling 8038

2018-10-29 Thread GitBox
DominikSuess opened a new pull request #15: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] DominikSuess closed pull request #14: Issue/sling 8038

2018-10-29 Thread GitBox
DominikSuess closed pull request #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

Re: Sling 12 themes

2018-10-29 Thread Radu Cotescu
Hi Robert, > On 29 Oct 2018, at 11:37, Robert Munteanu wrote: > > Wild idea: would it be possible to provide an optional extension point > for scripting engines where they could signal that a link is output? > Then we would have a central place for handling link rewriting. > > I guess for HTL

Re: Sling 12 themes

2018-10-29 Thread Robert Munteanu
On Wed, 2018-10-24 at 07:19 +0200, Carsten Ziegeler wrote: > In addition to that, it seems to me wrong to write a script which > creates an output (being that html or json or whatever) and then you > need an additional mechanism to modify this output. Wouldn't it be > much > better to create

[jira] [Updated] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-10-29 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-8058: Description: The slingfeature-maven-plugin as 2 goals: aggregate-features and repository

[jira] [Created] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-10-29 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8058: --- Summary: Make configuration of slingfeature-maven-plugin consistent Key: SLING-8058 URL: https://issues.apache.org/jira/browse/SLING-8058 Project: Sling