[jira] [Created] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Ashok Kumar (JIRA)
Ashok Kumar created SLING-8314: -- Summary: JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays Key: SLING-8314 URL: https://issues.apache.org/jira/brows

[jira] [Commented] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792450#comment-16792450 ] Konrad Windszus commented on SLING-8314: Please consider also the discussion at

[jira] [Comment Edited] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792450#comment-16792450 ] Konrad Windszus edited comment on SLING-8314 at 3/14/19 8:24 AM: --

[jira] [Comment Edited] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792450#comment-16792450 ] Konrad Windszus edited comment on SLING-8314 at 3/14/19 8:22 AM: --

[jira] [Created] (SLING-8315) Wrong calculation of factory config id in some cases

2019-03-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8315: --- Summary: Wrong calculation of factory config id in some cases Key: SLING-8315 URL: https://issues.apache.org/jira/browse/SLING-8315 Project: Sling Issu

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Konrad Windszus
I had a closer look in the source code. First of all the Configuration Admin spec doesn't limit in any way the types supported in the Dictionary, so a) primitive arrays b) object arrays c) collection of objects d) primitives and e) objects are all supported. IMHO write back should support all

[jira] [Commented] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792468#comment-16792468 ] Karl Pauls commented on SLING-8314: --- [~kwin], as I already said in the dev list discuss

[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2019-03-14 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792469#comment-16792469 ] Julian Sedding commented on SLING-8309: --- [~sdumitriu] could you please take a look

[jira] [Comment Edited] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2019-03-14 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792469#comment-16792469 ] Julian Sedding edited comment on SLING-8309 at 3/14/19 9:11 AM: ---

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Karl Pauls
> So I don't agree with > > The point that we for the writeback don't > > convert is hence, technically, a bug. It is - assuming we hold our documentation to be the source of what we support :-). > I would rather say the opposite: Write back and in general the .config file > format supports alm

[jira] [Resolved] (SLING-8315) Wrong calculation of factory config id in some cases

2019-03-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8315. - Resolution: Fixed Fixed in rev f0caf01. The rare case is where the alias starts with the

[VOTE] Release Apache Sling Installer Factory Configuration 1.2.2

2019-03-14 Thread Carsten Ziegeler
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12343871 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2055 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.o

Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.2

2019-03-14 Thread Carsten Ziegeler
+1 Carsten Ziegeler wrote Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12343871 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2055 You can use this UNIX script to download the release and verify the si

[GitHub] [sling-org-apache-sling-installer-provider-jcr] ashokpanghal opened a new pull request #1: SLING-8314 : JCR Installer writeback - convert primitive arrays to …

2019-03-14 Thread GitBox
ashokpanghal opened a new pull request #1: SLING-8314 : JCR Installer writeback - convert primitive arrays to … URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/1 …Object arrays This is an

Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.2

2019-03-14 Thread Robert Munteanu
On Thu, 2019-03-14 at 10:26 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.2

2019-03-14 Thread Karl Pauls
+1 regards, Karl On Thu, Mar 14, 2019 at 11:07 AM Robert Munteanu wrote: > > On Thu, 2019-03-14 at 10:26 +0100, Carsten Ziegeler wrote: > > Please vote to approve this release: > > +1 > > Robert > -BEGIN PGP SIGNATURE- > > iQFHBAABCAAxFiEECmZcRnC0eL8SI1zNM5UIZU9j7FQFAlyKJ70THHJvbWJlcnRA

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Konrad Windszus
> On 14. Mar 2019, at 10:19, Karl Pauls wrote: > >> So I don't agree with >>> The point that we for the writeback don't >>> convert is hence, technically, a bug. > > It is - assuming we hold our documentation to be the source of what we > support :-). Since the implementation was there first b

[jira] [Commented] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792532#comment-16792532 ] Konrad Windszus commented on SLING-8314: I would love to hear [~cziegeler] opinio

[jira] [Commented] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays

2019-03-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792579#comment-16792579 ] Carsten Ziegeler commented on SLING-8314: - [~kwin] I fixed a ClassCastException w

[GitHub] [sling-org-apache-sling-installer-provider-jcr] ashokpanghal commented on issue #1: SLING-8314 : JCR Installer writeback - convert primitive arrays to …

2019-03-14 Thread GitBox
ashokpanghal commented on issue #1: SLING-8314 : JCR Installer writeback - convert primitive arrays to … URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/1#issuecomment-472819655 Fix given in this patch converts all primitive arrays into respective Object

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Konrad Windszus
> On 14. Mar 2019, at 11:23, Konrad Windszus wrote: > > > >> On 14. Mar 2019, at 10:19, Karl Pauls > > wrote: >> >>> So I don't agree with The point that we for the writeback don't convert is hence, technically, a bug. >> >> It is - assuming we hold our

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Karl Pauls
On Thu, Mar 14, 2019 at 1:04 PM Konrad Windszus wrote: > > > > > On 14. Mar 2019, at 11:23, Konrad Windszus wrote: > > > > > > > >> On 14. Mar 2019, at 10:19, Karl Pauls >> > wrote: > >> > >>> So I don't agree with > The point that we for the writeback don't > >>

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Konrad Windszus
To me it felt, like you argued against fixing the documentation and rather restrict the types you want to accept. But obviously this is not the case... Ok, then I am going to fix the documentation and close https://issues.apache.org/jira/browse/SLING-8314

[jira] [Created] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-8316: -- Summary: Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr Key: SLING-8316 URL: https://issues.apache.org/jira/brows

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Karl Pauls
On Thu, Mar 14, 2019 at 1:53 PM Konrad Windszus wrote: > > To me it felt, like you argued against fixing the documentation and rather > restrict the types you want to accept. But obviously this is not the case... I just argued that with the current documentation it was a bug in the writeback (wh

[jira] [Commented] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792626#comment-16792626 ] Konrad Windszus commented on SLING-8316: Fixed in https://github.com/apache/slin

[jira] [Updated] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8316: --- Description: The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different bundles:

[jira] [Commented] (SLING-4724) Mock OSGI service does not work without bind and unbind methods.

2019-03-14 Thread Daniel (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792632#comment-16792632 ] Daniel commented on SLING-4724: --- There is a solution for running tests from IntelliJ (works

[jira] [Resolved] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-8316. Resolution: Fixed > Use the same version of o.a.felix.cm.file.ConfigurationHandler in > in

[jira] [Reopened] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reopened SLING-8316: > Use the same version of o.a.felix.cm.file.ConfigurationHandler in > installer.core and insta

[jira] [Commented] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792634#comment-16792634 ] Konrad Windszus commented on SLING-8316: Actually the version of the Configuratio

Re: OSGi Installer Configuration - Primitive Arrays

2019-03-14 Thread Konrad Windszus
I prepared an updated documentation in https://github.com/apache/sling-site/pull/34 . Please review and comment directly on the PR. AFAIK we don't have any conversion issues WRT primitives vs. objects except for the already fixed https://issues.apac

[GitHub] [sling-org-apache-sling-installer-provider-jcr] rombert commented on issue #1: SLING-8314 : JCR Installer writeback - convert primitive arrays to …

2019-03-14 Thread GitBox
rombert commented on issue #1: SLING-8314 : JCR Installer writeback - convert primitive arrays to … URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/1#issuecomment-472943130 A SonarQube report for the changes added _only by this pull request_ was generat

Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.2

2019-03-14 Thread David Bosschaert
+1 David On Thu, 14 Mar 2019 at 09:26, Carsten Ziegeler wrote: > Hi, > > We solved 2 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12343871 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2055 > > You can use this

[jira] [Updated] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8316: --- Description: The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different bundles:

[jira] [Updated] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8316: --- Description: The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different bundles:

[jira] [Commented] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792845#comment-16792845 ] Konrad Windszus commented on SLING-8316: Now upgraded the dependency to 1.8.6 in

[jira] [Resolved] (SLING-8316) Use the same version of o.a.felix.cm.file.ConfigurationHandler in installer.core and installer.provider.jcr

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-8316. Resolution: Fixed > Use the same version of o.a.felix.cm.file.ConfigurationHandler in > in

[jira] [Commented] (SLING-7757) Switch to ConfigurationHandler which supports user-friendly float/double values

2019-03-14 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792900#comment-16792900 ] Konrad Windszus commented on SLING-7757: Now that JSON format is fully supported