Re: [VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread Carsten Ziegeler
+1 Carsten On 02.03.2020 17:52, dav...@apache.org wrote: Hi all, I would like to call the release on the following Sling Apache components: slingfeature-maven-plugin 1.1.18 https://issues.apache.org/jira/projects/SLING/versions/12347340 Feature Model API Regions Extension 1.1.4 https://issue

[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox
cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r386827555 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo

Re: [VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread Karl Pauls
+1 regards, Karl On Mon, Mar 2, 2020 at 11:07 PM Andreas Schaefer wrote: > > +1 (non-binding) > > - Andy > > > On Mar 2, 2020, at 8:52 AM, dav...@apache.org wrote: > > > > Hi all, > > > > I would like to call the release on the following Sling Apache components: > > > > slingfeature-maven-plugi

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox
sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a clean set of changes URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-593651971 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-sl

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox
sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set of changes URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-593663635 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeatu

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox
sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set of changes URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-593651971 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeatu

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox
sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a clean set of changes URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-586042006 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-sl

Re: [VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Mar 2, 2020, at 8:52 AM, dav...@apache.org wrote: > > Hi all, > > I would like to call the release on the following Sling Apache components: > > slingfeature-maven-plugin 1.1.18 > https://issues.apache.org/jira/projects/SLING/versions/12347340 > > Feature Model AP

[GitHub] [sling-slingfeature-maven-plugin] schaefa commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox
schaefa commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r386677176 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.j

[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Jason E Bailey (Jira)
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049550#comment-17049550 ] Jason E Bailey edited comment on SLING-8243 at 3/2/20 6:50 PM:

[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Jason E Bailey (Jira)
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049550#comment-17049550 ] Jason E Bailey commented on SLING-8243: --- [~sseifert] yes, I'll take care of that.

[jira] [Closed] (SLING-9092) Remove unused export-packages analyser

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9092. - > Remove unused export-packages analyser > -- > >

[jira] [Closed] (SLING-9080) Support ArtifactProvider and FeatureProvider through ArtifactManager

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9080. - > Support ArtifactProvider and FeatureProvider through ArtifactManager >

[jira] [Closed] (SLING-9098) Provide support for directly downloading artifacts through mvn

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9098. - > Provide support for directly downloading artifacts through mvn > --

[jira] [Closed] (SLING-9087) Support creation of feature archives

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9087. - > Support creation of feature archives > > >

[jira] [Closed] (SLING-8676) Prototype does not allow to remove requirements and capabilities

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-8676. - > Prototype does not allow to remove requirements and capabilities >

[jira] [Closed] (SLING-9097) Mark ArtifactProvider and FeatureProvider as FunctionalInterface

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9097. - > Mark ArtifactProvider and FeatureProvider as FunctionalInterface >

[jira] [Closed] (SLING-9096) Provide methods to create a new id by just changing version, type or classifier

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9096. - > Provide methods to create a new id by just changing version, type or > classifier

[jira] [Closed] (SLING-9063) Provide convenience methods to handle factory configurations

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9063. - > Provide convenience methods to handle factory configurations >

[jira] [Closed] (SLING-9137) Add method to ArtifactId to create an id based on the mvn path

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9137. - > Add method to ArtifactId to create an id based on the mvn path > --

[VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread davidb
Hi all, I would like to call the release on the following Sling Apache components: slingfeature-maven-plugin 1.1.18 https://issues.apache.org/jira/projects/SLING/versions/12347340 Feature Model API Regions Extension 1.1.4 https://issues.apache.org/jira/projects/SLING/versions/12346855 Staging r

[jira] [Resolved] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-9136. - Resolution: Fixed > Check if a feature model exports overlapping packages with an API Reg

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] bosschaert merged pull request #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox
bosschaert merged pull request #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6 This is an aut

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] removed a comment on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox
sonarcloud[bot] removed a comment on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6#issuecomment-593480602 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox
sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6#issuecomment-593486632 Kudos, SonarCloud Quality Gate passed! [](https

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox
sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6#issuecomment-593480602 Kudos, SonarCloud Quality Gate passed! [](https

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] bosschaert opened a new pull request #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox
bosschaert opened a new pull request #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6 Checks if a feature model that does not participate in the API Regions e

[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049314#comment-17049314 ] Stefan Seifert edited comment on SLING-8243 at 3/2/20 3:22 PM:

[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049314#comment-17049314 ] Stefan Seifert commented on SLING-8243: --- [~jebailey] can you update the documentati

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049273#comment-17049273 ] Angela Schreiber commented on SLING-9090: - [~bdelacretaz], just had a quick look

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049217#comment-17049217 ] Angela Schreiber commented on SLING-9090: - [~mohiaror], IMHO the remove should re

[jira] [Issue Comment Deleted] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-9090: Comment: was deleted (was: Hi Mohit I don't think you have to worry about the extra with-p

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread angela (Jira)
[ https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049212#comment-17049212 ] angela commented on SLING-9090: --- Hi Mohit I don't think you have to worry about the extra

[RESULT][VOTE] Release Sling Feature Model 1.1.4, Feature Model IO 1.3.0, Feature Model Analyser 1.2.6, slingfeature-maven-plugin 1.1.16

2020-03-02 Thread davidb
Hi all, We received the following +1 votes: Binding +1s: Carsten Ziegeler, Stefan Seifert, David Bosschaert Non-binding +1s: Andreas Schaefer -1s: A -1 vote was received for the slingfeature-maven-plugin part only from me (David) as explained in the accompanying email. I have removed the slingfea

[jira] [Updated] (SLING-9095) Create a mojo that is able to create a feature archive

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9095: -- Fix Version/s: (was: slingfeature-maven-plugin 1.1.16) sl

[jira] [Updated] (SLING-9093) Add info mojo to generate a file with exported packages

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9093: -- Fix Version/s: (was: slingfeature-maven-plugin 1.1.16) sl

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Fix Version/s: Feature Model API Regions Extension 1.1.4 > Check if a feature m

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Affects Version/s: Feature Model API Regions Extension 1.1.2 > Check if a featu

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Component/s: Feature Model Analyser > Check if a feature model exports overlapp

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Description: If a feature model that doesn't opt-in to the api-regions exports

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Fix Version/s: (was: slingfeature-maven-plugin 1.1.16) > Check if a feature

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Affects Version/s: (was: slingfeature-maven-plugin 1.1.14) > Check if a fea

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Component/s: (was: Maven Plugins and Archetypes) > Check if a feature model

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9136: -- Summary: Check if a feature model exports overlapping packages with an API Regi

[jira] [Reopened] (SLING-9136) Provide a Mojo that can check if there is overlap between exports from different feature models

2020-03-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert reopened SLING-9136: --- > Provide a Mojo that can check if there is overlap between exports from > diffe

Re: [Starter] Startup detection not working reliable anymore

2020-03-02 Thread Carsten Ziegeler
Thanks Konrad, I'm struggling a little bit here as this worked with the initial version we had - that was not a sophisticated implementation but did the trick and most importantly did not present exceptions on startup to potentially new users. It seems we now have switched to a general appro

Re: [VOTE] Release Sling Feature Model 1.1.4, Feature Model IO 1.3.0, Feature Model Analyser 1.2.6, slingfeature-maven-plugin 1.1.16

2020-03-02 Thread davidb
Hi all, It turns out that there is a better way to implement the functionality from the api-regions-crossfeature-duplicates Mojo in the apiregions extension component. This would mean that the api-regions-crossfeature-duplicates Mojo becomes obsolete really soon. Rather than releasing something th

Re: [Starter] Startup detection not working reliable anymore

2020-03-02 Thread Konrad Windszus
This has been adjusted in the context of https://issues.apache.org/jira/browse/SLING-8418 . I think the exceptions are related to the order: https://issues.apache.org/jira/browse/SLING-8355 . May

[Starter] Startup detection not working reliable anymore

2020-03-02 Thread Carsten Ziegeler
Hi, some time back we added a mechanism that - on startup of the starter application - display a screen telling the user that the server is starting up. Over time this mechanism got changed - I don't know what exactly it is using today - but it is not working reliable anymore. If you hit ref

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048856#comment-17048856 ] Mohit Arora commented on SLING-9090: [~bdelacretaz], [~angela] We do have a usecase f