[GitHub] [sling-org-apache-sling-commons-log] bdelacretaz commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-06-15 Thread GitBox
bdelacretaz commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-643971148 SLING-9085 has more info on the Maven/https issue, and in SLING-9111 it was fixed by upgrading to pax exam 4.13.2. Which might require a few changes to

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread David Bosschaert
I found that page as well and tried it on one of my personal repos on github. It works and was pretty easy. The only not easily scripted thing for github is the selection of the default branch. I'm not sure how the default branch could be changed for Apache repos. Maybe it needs help from infra? I

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Robert Munteanu
On Sat, 2020-06-13 at 09:57 +0100, dav...@apache.org wrote: > Hi all, > > What would others think about renaming the 'master' branches to > 'main' in > Sling? > > I know that there is discussion going on at members@ where people > think > that 'master' on its own is not problematic, with suggesti

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Bertrand Delacretaz
Hi, On Sat, Jun 13, 2020 at 10:58 AM wrote: > ...What would others think about renaming the 'master' branches to 'main' in > Sling?.. I don't think it's useful. I know it is related to the "master/slave is a bad concept" discussion but I fail to see how "master" by itself is a problem. There's

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Nicolas Peltier
i guess we would need opinions of people that are on the wrong side of the domination Le lun. 15 juin 2020 à 10:29, Bertrand Delacretaz a écrit : > Hi, > > On Sat, Jun 13, 2020 at 10:58 AM wrote: > > ...What would others think about renaming the 'master' branches to > 'main' in > > Sling?.. > >

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Bertrand Delacretaz
On Mon, Jun 15, 2020 at 11:00 AM Nicolas Peltier wrote: > > i guess we would need opinions of people that are on the wrong side of the > domination.. I see what you mean but I'm not sure if anyone is dominated by Git master branches...that's my point ;-) Let me just quote https://en.wikipedia.or

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread David Bosschaert
Hi all, I think it would be worthwhile to remove any potential problematic language. I don't think Java has been identified as being problematic. And I agree with Robert that it would be good to look inside the code as well. Best regards, David On Mon, 15 Jun 2020 at 10:14, Bertrand Delacretaz

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Bertrand Delacretaz
Hi David, On Mon, Jun 15, 2020 at 1:22 PM David Bosschaert wrote: > ...I think it would be worthwhile to remove any potential problematic > language... As mentioned I am not opposed if others want to do the work. All the work - because renaming things often has subtle unwanted effects. > I don

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.4

2020-06-15 Thread Daniel Klco
+1 On Sat, Jun 13, 2020 at 2:53 AM Carsten Ziegeler wrote: > +1 > > Carsten > > Am 12.06.2020 um 16:56 schrieb dav...@apache.org: > > Hi all, > > > > I would like to call the release on the Sling Feature Model API Regions > > Runtime Fragment 1.1.4 > > > > Resolved issues: > > https://issues.apa

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.4

2020-06-15 Thread Karl Pauls
+1 regards, Karl On Mon, Jun 15, 2020 at 2:29 PM Daniel Klco wrote: > > +1 > > On Sat, Jun 13, 2020 at 2:53 AM Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > Am 12.06.2020 um 16:56 schrieb dav...@apache.org: > > > Hi all, > > > > > > I would like to call the release on the Sling Fe

Any modules to add to SonarCloud?

2020-06-15 Thread Bertrand Delacretaz
Hi, I'm about to make a request like https://issues.apache.org/jira/browse/SLING-9471 for the graphql-core module. If anyone sees other missing modules, please let me know in the next 24 hours and I'll group those requests. -Bertrand

[GitHub] [sling-org-apache-sling-commons-log] DominikSuess commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-06-15 Thread GitBox
DominikSuess commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-644159053 @cziegeler, @bdelacretaz - bumped the pax exam version which caused a bit of trouble wrt tinybundles which doesn't work with the latest versions of e

[GitHub] [sling-org-apache-sling-commons-log] sonarcloud[bot] commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-06-15 Thread GitBox
sonarcloud[bot] commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-644159807 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=6&reso

Re: Any modules to add to SonarCloud?

2020-06-15 Thread Nicolas Peltier
Hi Bertrand, i'd be grateful to have sling-pipes too please ( https://github.com/apache/sling-org-apache-sling-pipes) thanks! Le lun. 15 juin 2020 à 15:53, Bertrand Delacretaz a écrit : > Hi, > > I'm about to make a request like > https://issues.apache.org/jira/browse/SLING-9471 for the graphq

[jira] [Created] (SLING-9519) Modules to add to SonarCloud

2020-06-15 Thread Bertrand Delacretaz (Jira)
Bertrand Delacretaz created SLING-9519: -- Summary: Modules to add to SonarCloud Key: SLING-9519 URL: https://issues.apache.org/jira/browse/SLING-9519 Project: Sling Issue Type: Task

Re: Any modules to add to SonarCloud?

2020-06-15 Thread Bertrand Delacretaz
Hi Nicolas, On Mon, Jun 15, 2020 at 4:29 PM Nicolas Peltier wrote: >... i'd be grateful to have sling-pipes too please ( > https://github.com/apache/sling-org-apache-sling-pipes) .. Ok, added to https://issues.apache.org/jira/browse/SLING-9519 - as mentioned I'l wait a bit more before asking Fab

[VOTE] Release Apache Sling GraphQL Core 0.0.2, Servlet Helpers 1.4.2

2020-06-15 Thread Bertrand Delacretaz
Hi, It's the first release of the GraphQL Core module, and for the servlet helpers we fixed 4 issues: https://issues.apache.org/jira/projects/SLING/versions/12346473 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2279/ You can use this UNIX script to downl

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Robert Munteanu
On Mon, 2020-06-15 at 12:22 +0100, David Bosschaert wrote: > And I agree with Robert that it would be good to look inside the code > as > well. All changes have pros and cons. Let's please make sure that changing the default git remote name is not a net negative due to the effort it includes: -

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Bertrand Delacretaz
On Mon, Jun 15, 2020 at 5:30 PM Robert Munteanu wrote: > ...Let's please start by collecting all the required changes in a wiki > page and seeing whether we have consensus on the change and whether we > think it has a positive impact for the project... Big +1 to this, thank you Robert for spellin

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.2, Servlet Helpers 1.4.2

2020-06-15 Thread Robert Munteanu
On Mon, 2020-06-15 at 17:25 +0200, Bertrand Delacretaz wrote: > Please vote to approve this release: +1 FTR, the graphql core job is unstable due to not being enrolled in SonarCloud, and there is a open task for that already: https://issues.apache.org/jira/browse/SLING-9519 Thanks, Robert s

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread David Bosschaert
I just tried to create a wiki page where we can collaborate on this, but found out that I have no rights to create a page on the SLING wiki... Best regards, David On Mon, 15 Jun 2020 at 16:37, Bertrand Delacretaz wrote: > On Mon, Jun 15, 2020 at 5:30 PM Robert Munteanu > wrote: > > ...Let's p

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread Robert Munteanu
On Mon, 2020-06-15 at 17:10 +0100, David Bosschaert wrote: > I just tried to create a wiki page where we can collaborate on this, > but > found out that I have no rights to create a page on the SLING wiki... Hm. Can you please ask Infra? Permissions are managed via groups, which (I think) are sync

[jira] [Closed] (SLING-9496) Dead code in the API Regions runtime

2020-06-15 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9496. - > Dead code in the API Regions runtime > > >

[jira] [Closed] (SLING-9494) Always log which candidates where removed by the API Regions

2020-06-15 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9494. - > Always log which candidates where removed by the API Regions >

[RESULT][VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.4

2020-06-15 Thread davidb
With 4 binding +1 votes this release is successful. I've promoted the artifacts. Best regards, David On Fri, 12 Jun 2020 at 15:56, wrote: > Hi all, > > I would like to call the release on the Sling Feature Model API Regions > Runtime Fragment 1.1.4 > > Resolved issues: > https://issues.apache

[jira] [Closed] (SLING-9501) Packages provided by a non-api-region enabled feature should be on par with the global region

2020-06-15 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9501. - > Packages provided by a non-api-region enabled feature should be on par with > the

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-15 Thread David Bosschaert
I've created the wiki page to list actions take: https://cwiki.apache.org/confluence/display/SLING/Removal+of+problematic+language Best regards, David On Mon, 15 Jun 2020 at 17:14, Robert Munteanu wrote: > On Mon, 2020-06-15 at 17:10 +0100, David Bosschaert wrote: > > I just tried to create a