[jira] [Created] (SLING-9918) Keep origins for framework properties and variables

2020-11-17 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9918: --- Summary: Keep origins for framework properties and variables Key: SLING-9918 URL: https://issues.apache.org/jira/browse/SLING-9918 Project: Sling

[jira] [Created] (SLING-9917) Allow to store metadata alongside framework properties and variables

2020-11-17 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9917: --- Summary: Allow to store metadata alongside framework properties and variables Key: SLING-9917 URL: https://issues.apache.org/jira/browse/SLING-9917 Project:

Precompiled JSP's / HTLs

2020-11-17 Thread Roy Teeuwen
Hey devs, I saw the talk about precompiled JSP’s and HTL’s on adaptTo (also the last years) and when I saw the performance impact I was really amazed! I have some questions about it. We are running an existing on-premise application. Would it be possible to somehow extract the jsp's / htl's

[jira] [Assigned] (SLING-9915) Remove deprecated flags for SlingAnnotationsTestRunner and TestReference

2020-11-17 Thread Cris Rockwell (Jira)
[ https://issues.apache.org/jira/browse/SLING-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cris Rockwell reassigned SLING-9915: Assignee: Cris Rockwell > Remove deprecated flags for SlingAnnotationsTestRunner and

[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on pull request #10: SLING-9901 - switch Oak for tests, but no new tests so far

2020-11-17 Thread GitBox
anchela commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/10#issuecomment-729046031 @bdelacretaz , i originally only added tests for actualy system-users which were missing and actually would have been the most important piece of all of

[jira] [Commented] (SLING-9901) JcrSystemUserValidatorTest contains not tests for system users

2020-11-17 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233694#comment-17233694 ] Bertrand Delacretaz commented on SLING-9901: Thank you very much for this! Do you have a

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.20

2020-11-17 Thread Daniel Klco
+1 On Tue, Nov 17, 2020 at 10:51 AM wrote: > > +1 > > David > > On Tue, 17 Nov 2020 at 15:44, Carsten Ziegeler wrote: > > > +1 > > > > Carsten > > > > Am 17.11.2020 um 16:41 schrieb Karl Pauls: > > > Hi all, > > > > > > I would like to call the release on the Content-Package to Feature Model >

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.20

2020-11-17 Thread davidb
+1 David On Tue, 17 Nov 2020 at 15:44, Carsten Ziegeler wrote: > +1 > > Carsten > > Am 17.11.2020 um 16:41 schrieb Karl Pauls: > > Hi all, > > > > I would like to call the release on the Content-Package to Feature Model > > Converter 1.0.20 > >

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.20

2020-11-17 Thread Carsten Ziegeler
+1 Carsten Am 17.11.2020 um 16:41 schrieb Karl Pauls: Hi all, I would like to call the release on the Content-Package to Feature Model Converter 1.0.20 https://issues.apache.org/jira/projects/SLING/versions/12349401 Staging repository:

[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.0.20

2020-11-17 Thread Karl Pauls
Hi all, I would like to call the release on the Content-Package to Feature Model Converter 1.0.20 https://issues.apache.org/jira/projects/SLING/versions/12349401 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2380 You can use this UNIX script to download

[jira] [Updated] (SLING-9692) Add support for principal-based access control entries

2020-11-17 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/SLING-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-9692: -- Fix Version/s: (was: Content-Package to Feature Model Converter 1.1.2)

[jira] [Resolved] (SLING-9916) Content package converter produces broken configs for typed configuration entries.

2020-11-17 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9916. - Resolution: Fixed Fixed in [1] by removing all type information - the conversion to the

[jira] [Created] (SLING-9916) Content package converter produces broken configs for typed configuration entries.

2020-11-17 Thread Karl Pauls (Jira)
Karl Pauls created SLING-9916: - Summary: Content package converter produces broken configs for typed configuration entries. Key: SLING-9916 URL: https://issues.apache.org/jira/browse/SLING-9916 Project:

[jira] [Commented] (SLING-9901) JcrSystemUserValidatorTest contains not tests for system users

2020-11-17 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233646#comment-17233646 ] Angela Schreiber commented on SLING-9901: - [~bdelacretaz], i expanded/adjusted existing test

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #10: SLING-9901 - switch Oak for tests, but no new tests so far

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/10#issuecomment-728986905 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=10=false=BUG)

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] removed a comment on pull request #10: SLING-9901 - switch Oak for tests, but no new tests so far

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/10#issuecomment-727877917 Kudos, SonarCloud Quality Gate passed!

Re: Can we Un-deprecate SlingAnnotationsTestRunner ?

2020-11-17 Thread Bertrand Delacretaz
On Tue, Nov 17, 2020 at 9:18 AM Julian Sedding wrote: > ...If you want to enhance @TestReference, I would suggest supporting the > "target" attribute that is also present in the SCR @Reference > annotation[0].. +1 -Bertrand

Re: [VOTE] Release Apache Sling slingfeature-maven-plugin 1.4.16

2020-11-17 Thread Karl Pauls
+1 regards, Karl On Tue, Nov 17, 2020 at 11:43 AM wrote: > > +1 > > David > > On Mon, 16 Nov 2020 at 20:23, Carsten Ziegeler wrote: > > > +1 > > > > Carsten > > > > Am 16.11.2020 um 18:58 schrieb dav...@apache.org: > > > Hi all, > > > > > > I would like to call the release on the

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #217 is BROKEN

2020-11-17 Thread Apache Jenkins Server
ING] The requested profile "ci" could not be activated because it does not exist. [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavenaa29e699/maven-spy-20201117-111727-2396427284117190590529.log [ERROR] Failed to execute goal org.a

Re: [VOTE] Release Apache Sling slingfeature-maven-plugin 1.4.16

2020-11-17 Thread davidb
+1 David On Mon, 16 Nov 2020 at 20:23, Carsten Ziegeler wrote: > +1 > > Carsten > > Am 16.11.2020 um 18:58 schrieb dav...@apache.org: > > Hi all, > > > > I would like to call the release on the slingfeature-maven-plugin 1.4.16 > > https://issues.apache.org/jira/projects/SLING/versions/12349397

Re: Can we Un-deprecate SlingAnnotationsTestRunner ?

2020-11-17 Thread Robert Munteanu
Hi Cris, On Mon, 2020-11-16 at 12:54 -0500, Cris Rockwell wrote: > Thanks for your response. I created Jira ticket > https://issues.apache.org/jira/browse/SLING-9915 he.org/jira/browse/SLING-9915> This can be assigned to me. You should be able to assign the Jira issue to

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on a change in pull request #24: SLING-9535 - Improve performance of sling:alias

2020-11-17 Thread GitBox
rombert commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#discussion_r525034842 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java ## @@ -149,6 +149,12

Re: SonarQube: new code definition?

2020-11-17 Thread Robert Munteanu
Hi Betrand, On Tue, 2020-11-17 at 10:28 +0100, Bertrand Delacretaz wrote: > Hi, > > https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-adapter-annotations > (a recently created module, just released) says: > > > We can't display your Quality Gate without a New Code definition. > >

SonarQube: new code definition?

2020-11-17 Thread Bertrand Delacretaz
Hi, https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-adapter-annotations (a recently created module, just released) says: > We can't display your Quality Gate without a New Code definition. > ... > Ask your admin to set a New Code definition. As a result the Sonar-related badges

[GitHub] [sling-org-apache-sling-resourceresolver] jsedding commented on a change in pull request #24: SLING-9535 - Improve performance of sling:alias

2020-11-17 Thread GitBox
jsedding commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#discussion_r524989721 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java ## @@ -149,6 +149,12

[GitHub] [sling-org-apache-sling-resourceresolver] jsedding commented on a change in pull request #24: SLING-9535 - Improve performance of sling:alias

2020-11-17 Thread GitBox
jsedding commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#discussion_r524988723 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java ## @@ -304,6

[GitHub] [sling-org-apache-sling-resourceresolver] jsedding commented on a change in pull request #24: SLING-9535 - Improve performance of sling:alias

2020-11-17 Thread GitBox
jsedding commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#discussion_r524986775 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java ## @@ -128,6

Re: Can we Un-deprecate SlingAnnotationsTestRunner ?

2020-11-17 Thread Julian Sedding
Hi Chris If you want to enhance @TestReference, I would suggest supporting the "target" attribute that is also present in the SCR @Reference annotation[0]. It accepts an LDAP filter expression as is commonly used in OSGi. This would allow you to select your service by "component.name" or by any