[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-02-08 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-775513544 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=69=false=BUG)

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-02-08 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-775543233 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=69=false=BUG)

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-02-08 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-775513544 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=69=false=BUG)

[GitHub] [sling-whiteboard] cmrockwell opened a new pull request #69: Sling 9397/update removed saml config service

2021-02-08 Thread GitBox
cmrockwell opened a new pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69 This PR removed SAML2ConfigService and SAML2ConfigServiceImpl these were not needed, and exposing the information thru the service was not a good idea as mentioned in the ticket. -

[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]

2021-02-08 Thread Cris Rockwell (Jira)
[ https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281415#comment-17281415 ] Cris Rockwell commented on SLING-9397: -- Nope. Prefer to keep it on the ticket. Thanks > SAML2

[jira] [Commented] (SLING-10127) Keep modified content packages of type "content"

2021-02-08 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281414#comment-17281414 ] Konrad Windszus commented on SLING-10127: - [~dsuess] What is your opinion on this one? Are the

[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]

2021-02-08 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281413#comment-17281413 ] Robert Munteanu commented on SLING-9397: Can we please keep the conversation at

[jira] [Commented] (SLING-10120) Upgrade event to parent 40

2021-02-08 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281378#comment-17281378 ] Oliver Lietz commented on SLING-10120: -- Parent 40 contains a SNAPSHOT and I can only recommend to

[jira] [Commented] (SLING-10120) Upgrade event to parent 40

2021-02-08 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281303#comment-17281303 ] Stefan Egli commented on SLING-10120: - * started work on parent 40 switch see [this

[GitHub] [sling-org-apache-sling-event] stefan-egli opened a new pull request #10: SLING-10120 : switch to parent 40

2021-02-08 Thread GitBox
stefan-egli opened a new pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10 PS: still requires java8 - with java11 there are currently missing dependencies in ITs (osgi.ee) This is an

Re: [jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]

2021-02-08 Thread Daniel Klco
Have you looked into Sling Commons Crypto? https://sling.apache.org/documentation/bundles/commons-crypto.html It would not be complete prevention, but at least that way the secrets aren't stored plain-text. Of course even with that a malicious bundle could retrieve the private configuration from

[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]

2021-02-08 Thread Cris Rockwell (Jira)
[ https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281261#comment-17281261 ] Cris Rockwell commented on SLING-9397: -- {quote}Who are you trying to protect the sensitive data

[jira] [Closed] (SLING-10060) Substitutions for the "replacePropertyVariables" values should prefer the system property value

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10060. -- > Substitutions for the "replacePropertyVariables" values should prefer the >

[jira] [Closed] (SLING-10125) Reduce dependecy of slingfeature maven plugin on apiregions

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10125. -- > Reduce dependecy of slingfeature maven plugin on apiregions >

[jira] [Closed] (SLING-10076) Make sure no files are written during lifecycle participant run

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10076. -- > Make sure no files are written during lifecycle participant run >

[jira] [Closed] (SLING-10069) The generated features target dir is created in the wrong place

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10069. -- > The generated features target dir is created in the wrong place >

[jira] [Closed] (SLING-9419) JCR Repoinit integration tests fail on Windows

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9419. - > JCR Repoinit integration tests fail on Windows >

[jira] [Closed] (SLING-9857) Intermediate path is ignored if user/group already exists

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9857. - > Intermediate path is ignored if user/group already exists >

[jira] [Closed] (SLING-9325) Update to Sling Bundle Parent 38

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9325. - > Update to Sling Bundle Parent 38 > > >

[jira] [Closed] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-9449. - > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists

[jira] [Updated] (SLING-10126) Repository Initializer should support Empty or Single Value Lists

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-10126: --- Fix Version/s: (was: Repoinit Parser 1.6.4) Repoinit

[jira] [Closed] (SLING-10086) Validate configuration properties case-insensitive

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10086. -- > Validate configuration properties case-insensitive >

[jira] [Closed] (SLING-10005) Document the ExtensionHandler interface

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10005. -- > Document the ExtensionHandler interface >

[jira] [Closed] (SLING-10106) Update to Apache Felix cm.json 1.0.6

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10106. -- > Update to Apache Felix cm.json 1.0.6 > > >

[jira] [Closed] (SLING-10084) Prevent the creation of configuration properties with duplicate keys

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10084. -- > Prevent the creation of configuration properties with duplicate keys >

[jira] [Closed] (SLING-10091) ConfigurationJSONReader returns empty list

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10091. -- > ConfigurationJSONReader returns empty list >

[jira] [Closed] (SLING-10100) Internal configuration properties are not handled correctly

2021-02-08 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10100. -- > Internal configuration properties are not handled correctly >

Re: OSGi Configs

2021-02-08 Thread Robert Munteanu
Hi Cris, On Fri, 2021-02-05 at 12:44 -0500, Cris Rockwell wrote: > Hi Sling devs, > > Maybe you saw this already in the dev email feed from my Jira > comment. But here’s the comment I posted to the SAML Jira ticket [1] > > > One of the open items identified in the ticket description regards >

[RESULT][VOTE] Release Apache Sling Feature Model 1.2.20, Feature Model Analyser 1.3.22, Feature Model Launcher 1.1.16, Feature Model API Regions Extension 1.1.20, Repoinit Parser 1.6.4, Repoinit JCR

2021-02-08 Thread davidb
Hi all, We received binding +1 votes from Eric Norman, Daniel Klco, Carsten Ziegeler and me. We also received a non-binding +1 from Andreas Schaefer. This release is successful. I've promoted the artifacts. Kind regards, David On Fri, 5 Feb 2021 at 15:03, wrote: > Hi all, > > I would like

[jira] [Created] (SLING-10129) Introduce version statement

2021-02-08 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-10129: --- Summary: Introduce version statement Key: SLING-10129 URL: https://issues.apache.org/jira/browse/SLING-10129 Project: Sling Issue Type: Improvement

[jira] [Created] (SLING-10128) Document feature per language version

2021-02-08 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-10128: --- Summary: Document feature per language version Key: SLING-10128 URL: https://issues.apache.org/jira/browse/SLING-10128 Project: Sling Issue Type:

[jira] [Assigned] (SLING-10128) Document feature per language version

2021-02-08 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10128: --- Assignee: Konrad Windszus > Document feature per language version >

Re: Backwards-compatibility of repoinit features

2021-02-08 Thread Konrad Windszus
Hi Carsten, yes indeed I see https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/473d8b976c8d4c9c3a01bdc70e501c7a74b1959b/bnd.bnd#L4 and the related

Re: Backwards-compatibility of repoinit features

2021-02-08 Thread Carsten Ziegeler
Hi didn't we add a provide capability to the parser bundle which versions the language? Keep in mind that repoinit might be aggregated, for example through the feature model and each individual feature file might define a different minimum version. So if we add a version statement to the

[jira] [Commented] (SLING-10012) Lookup of precompiled template files does not work

2021-02-08 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281141#comment-17281141 ] Radu Cotescu commented on SLING-10012: -- [~Slyshkova], aren't you in the exact same situation like

SLING-9741: Invalid path decomposition in case of multiple dots

2021-02-08 Thread Akanksha
Hi Developers I was working on JIRA SLING-9741. Related PR: https://github.com/apache/sling-org-apache-sling-engine/pull/11 Approach: Mark Request invalid if it contains continuous dots. Request you all to review my approach or is there any better approach to address this issue Regards

Re: Questions surfaced by SLING-9999

2021-02-08 Thread Radu Cotescu
Hi Olli, Which of the two options below do you prefer? 1. The API from o.a.s.servlets.resolver.api bundle [0] gets moved to the o.a.s.scripting.api bundle, in the o.a.s.scripting.api.bundle package. That means that we’ll have the following import chains: o.a.s.scripting.api

[jira] [Closed] (SLING-10089) PackageInit Extension should fail when errors occur in ExecutionPlan

2021-02-08 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10089. --- > PackageInit Extension should fail when errors occur in ExecutionPlan >

[RESULT] [VOTE] Release Apache Sling JCR Package Init 1.0.2

2021-02-08 Thread Robert Munteanu
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Carsten Ziegeler, Dan Klco, Stefan Seifert +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu