Re: [VOTE] Release Apache Sling Parent 41 and Bundle Parent 41

2021-02-25 Thread Carsten Ziegeler
+1 Carsten Am 26.02.2021 um 08:28 schrieb Konrad Windszus: Hi, We solved some issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12349251 https://issues.apache.org/jira/projects/SLING/versions/12349252 Staging repository:

Re: PAX Help

2021-02-25 Thread Bertrand Delacretaz
Hi, On Fri, Feb 26, 2021 at 12:09 AM Cris Rockwell wrote: > I was wondering if someone knowledgable about PAX testing in Sling could help > me out with my Sling Whiteboard project (saml-handler) [1] on branch > SLING-9397/improve-test-coverage... FWIW,

[VOTE] Release Apache Sling Parent 41 and Bundle Parent 41

2021-02-25 Thread Konrad Windszus
Hi, We solved some issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12349251 https://issues.apache.org/jira/projects/SLING/versions/12349252 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2415 You can use this UNIX script to

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #16: remove duplicat arg line

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16#issuecomment-786463185 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #16: remove duplicat arg line

2021-02-25 Thread GitBox
stbischof opened a new pull request #16: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (SLING-10170) Update animal-sniffer-maven-plugin to 1.20

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10170. - Resolution: Fixed Fixed in

[jira] [Resolved] (SLING-10160) Create source-release.zip for pom artifacts

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10160. - Resolution: Fixed Fixed in

[GitHub] [sling-parent] kwin merged pull request #15: SLING-10160 generate source-release.zip for both parent poms

2021-02-25 Thread GitBox
kwin merged pull request #15: URL: https://github.com/apache/sling-parent/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (SLING-10170) Update animal-sniffer-maven-plugin to 1.20

2021-02-25 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-10170: --- Summary: Update animal-sniffer-maven-plugin to 1.20 Key: SLING-10170 URL: https://issues.apache.org/jira/browse/SLING-10170 Project: Sling Issue Type:

[jira] [Updated] (SLING-10027) Update JUnit to 4.13.2

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10027: Summary: Update JUnit to 4.13.2 (was: Update JUnit to 4.13.1) > Update JUnit to 4.13.2 >

[jira] [Comment Edited] (SLING-10027) Update JUnit to 4.13.1

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255593#comment-17255593 ] Konrad Windszus edited comment on SLING-10027 at 2/26/21, 7:07 AM: ---

[jira] [Updated] (SLING-10027) Update JUnit to 4.13.1

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10027: Description: The managed version should be updated from 4.12 to 4.13.2

[jira] [Commented] (SLING-10027) Update JUnit to 4.13.1

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291433#comment-17291433 ] Konrad Windszus commented on SLING-10027: - Updated to JUnit 4.13.2 in

[jira] [Commented] (SLING-10160) Create source-release.zip for pom artifacts

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291429#comment-17291429 ] Konrad Windszus commented on SLING-10160: - PR: https://github.com/apache/sling-parent/pull/15 >

[jira] [Updated] (SLING-9611) Enforce setting the "project.build.outputTimestamp" property

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9611: --- Fix Version/s: (was: Parent 41) Parent 42 Parent 42

[jira] [Updated] (SLING-9463) Document reproducible builds and check automatically via check-staged-release

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9463: --- Fix Version/s: (was: Parent 41) Parent 42 Parent 42

[jira] [Updated] (SLING-10053) Replace Ianal Maven Plugin

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10053: Fix Version/s: (was: Parent 41) Parent 42 Parent

[jira] [Updated] (SLING-9189) release:perform issues [WARNING] The requested profile "pom.xml" could not be activated because it does not exist.

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9189: --- Fix Version/s: (was: Parent 41) Parent 42 > release:perform issues

[jira] [Updated] (SLING-7534) Release policy - stop providing MD5 and start providing SHA-512 checksums

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7534: --- Fix Version/s: (was: Parent 41) Parent 42 Parent 42

[jira] [Updated] (SLING-9729) Bundle-Parent: Check if resolvable against latest Sling Starter

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9729: --- Fix Version/s: (was: Bundle Parent 41) Bundle Parent 42

[jira] [Updated] (SLING-8738) Trigger an error during build if an API uses a private reference in its public methods' signatures

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8738: --- Fix Version/s: (was: Bundle Parent 41) Bundle Parent 42 > Trigger an

[jira] [Commented] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291415#comment-17291415 ] Carsten Ziegeler commented on SLING-10159: -- There is no fixed timeline, I suggest to ask on the

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is no

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-786364570 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-servlets-post] sdumitriu opened a new pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not acce

2021-02-25 Thread GitBox
sdumitriu opened a new pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12 Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (SLING-10169) Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not accessible

2021-02-25 Thread Sergiu Dumitriu (Jira)
Sergiu Dumitriu created SLING-10169: --- Summary: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not accessible Key: SLING-10169 URL:

Re: PAX Help

2021-02-25 Thread Eric Norman
Also, you'll need to add a version of the felix framework as a dependency with something like this: org.apache.felix org.apache.felix.framework 6.0.3 test On Thu, Feb 25, 2021 at 3:18 PM Eric Norman wrote: > Hi, > I think you might be

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #18: SLING-10143 - update dependencies to latest release versions

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/18#issuecomment-786297691 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=18=false=BUG)

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #18: SLING-10143 - update dependencies to latest release versions

2021-02-25 Thread GitBox
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/18#issuecomment-780562539 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=18=false=BUG)

Re: PAX Help

2021-02-25 Thread Eric Norman
Hi, I think you might be missing the annotation declaring that you want to use the PaxExam test runner for the test class. For example, something like this may get you further: import org.ops4j.pax.exam.junit.PaxExam; import org.junit.runner.RunWith; @RunWith(PaxExam.class) On Thu, Feb 25,

PAX Help

2021-02-25 Thread Cris Rockwell
Hello it’s me again I was wondering if someone knowledgable about PAX testing in Sling could help me out with my Sling Whiteboard project (saml-handler) [1] on branch SLING-9397/improve-test-coverage The project uses Java 11, but I think that’s supported and should be fine. The pom [2] should

Re: [VOTE] Release Apache Sling XSS Protection API 2.2.12

2021-02-25 Thread Karl Pauls
+1 regards, Karl On Thursday, February 25, 2021, Eric Norman wrote: > +1 > > On Thu, Feb 25, 2021 at 5:04 AM Radu Cotescu wrote: > > > Hi, > > > > We solved 1 issue in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12349722 > > > > Staging repository: > >

[jira] [Comment Edited] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Muzaffar Nurmukhammadov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291252#comment-17291252 ] Muzaffar Nurmukhammadov edited comment on SLING-10159 at 2/25/21, 10:03 PM:

[jira] [Commented] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Muzaffar Nurmukhammadov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291252#comment-17291252 ] Muzaffar Nurmukhammadov commented on SLING-10159: - [~cziegeler] Thanks for merging. A

[jira] [Comment Edited] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Muzaffar Nurmukhammadov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291252#comment-17291252 ] Muzaffar Nurmukhammadov edited comment on SLING-10159 at 2/25/21, 10:02 PM:

[jira] [Comment Edited] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291181#comment-17291181 ] Eric Norman edited comment on SLING-10155 at 2/25/21, 8:29 PM: --- [~olli] I

[jira] [Comment Edited] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291181#comment-17291181 ] Eric Norman edited comment on SLING-10155 at 2/25/21, 8:25 PM: --- [~olli] I

[jira] [Comment Edited] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291181#comment-17291181 ] Eric Norman edited comment on SLING-10155 at 2/25/21, 8:24 PM: --- [~olli] I

[jira] [Comment Edited] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291181#comment-17291181 ] Eric Norman edited comment on SLING-10155 at 2/25/21, 8:12 PM: --- [~olli] I

[jira] [Commented] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291181#comment-17291181 ] Eric Norman commented on SLING-10155: - [~olli] I couldn't say with any certainty why someone would

Re: [VOTE] Release Apache Sling Engine 2.7.4

2021-02-25 Thread Daniel Klco
+1 On Thu, Feb 25, 2021 at 2:12 PM Stefan Seifert wrote: > +1 >

[jira] [Commented] (SLING-10147) scripting variables implementation details are exposed to not authorized users

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291179#comment-17291179 ] Eric Norman commented on SLING-10147: - [~jsedding] Oh, that makes more sense.  Sorry I misunderstood

[jira] [Commented] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-02-25 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291177#comment-17291177 ] Oliver Lietz commented on SLING-10155: -- [~enorman], This configuration makes sense only for

[GitHub] [sling-org-apache-sling-resourcemerger] kwin opened a new pull request #5: SLING-5469 add mixin for resource merger properties

2021-02-25 Thread GitBox
kwin opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [VOTE] Release Apache Sling XSS Protection API 2.2.12

2021-02-25 Thread Eric Norman
+1 On Thu, Feb 25, 2021 at 5:04 AM Radu Cotescu wrote: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12349722 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2414/ > > You can use this UNIX

[jira] [Assigned] (SLING-5469) Resource Merger: Add some name prefixing mechanism for properties which are used by the resource merger itself

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-5469: -- Assignee: Konrad Windszus > Resource Merger: Add some name prefixing mechanism for

[jira] [Comment Edited] (SLING-5469) Resource Merger: Add some name prefixing mechanism for properties which are used by the resource merger itself

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291163#comment-17291163 ] Konrad Windszus edited comment on SLING-5469 at 2/25/21, 7:23 PM: -- Let's

[jira] [Commented] (SLING-5469) Resource Merger: Add some name prefixing mechanism for properties which are used by the resource merger itself

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291163#comment-17291163 ] Konrad Windszus commented on SLING-5469: Let's go for a simple mixin approach here. The new mixin

[GitHub] [sling-org-apache-sling-scripting-core] enapps-enorman commented on a change in pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-02-25 Thread GitBox
enapps-enorman commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#discussion_r583103189 ## File path: src/main/java/org/apache/sling/scripting/core/impl/SlingBindingsVariablesListJsonServlet.java ## @@ -91,6

[jira] [Updated] (SLING-5469) Resource Merger: Add some name prefixing mechanism for properties which are used by the resource merger itself

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5469: --- Fix Version/s: Resource Merger 1.4.0 > Resource Merger: Add some name prefixing mechanism

[jira] [Resolved] (SLING-6968) Resource Merger: Add another resource picker which merges two arbitrary resources given by path

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-6968. Resolution: Won't Fix > Resource Merger: Add another resource picker which merges two

[GitHub] [sling-org-apache-sling-scripting-core] enapps-enorman commented on a change in pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-02-25 Thread GitBox
enapps-enorman commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#discussion_r583100054 ## File path: src/main/java/org/apache/sling/scripting/core/impl/SlingBindingsVariablesListJsonServlet.java ## @@ -91,6

[jira] [Updated] (SLING-10150) Sling Resource Merger completely hides parent when whitelisting in combination with asterisk is used for sling:hideChildren

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10150: Fix Version/s: Resource Merger 1.4.0 > Sling Resource Merger completely hides parent when

[jira] [Created] (SLING-10168) Migrate to Bundle Parent 40 and OSGi annotations

2021-02-25 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-10168: --- Summary: Migrate to Bundle Parent 40 and OSGi annotations Key: SLING-10168 URL: https://issues.apache.org/jira/browse/SLING-10168 Project: Sling Issue

[jira] [Commented] (SLING-10150) Sling Resource Merger completely hides parent when whitelisting in combination with asterisk is used for sling:hideChildren

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291156#comment-17291156 ] Konrad Windszus commented on SLING-10150: - [~jsedding][~Henry Kuijpers] Please have a look at

RE: [VOTE] Release Apache Sling Engine 2.7.4

2021-02-25 Thread Stefan Seifert
+1

[GitHub] [sling-org-apache-sling-resourcemerger] kwin opened a new pull request #4: SLING-10150 improve handling of multivalue hides

2021-02-25 Thread GitBox
kwin opened a new pull request #4: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/4 affects both hideChildren and hideProperties This is an automated message from the Apache Git Service. To respond

RE: [VOTE] Release Apache Sling XSS Protection API 2.2.12

2021-02-25 Thread Stefan Seifert
+1

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for loading

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42#issuecomment-786129481 Kudos, SonarCloud Quality Gate passed!

[jira] [Commented] (SLING-10167) MapEntries.loadAliases generets JCR queries with illegal absolute paths

2021-02-25 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291146#comment-17291146 ] Stefan Seifert commented on SLING-10167: i've provided a PR to fix the problem:

[GitHub] [sling-org-apache-sling-resourceresolver] stefanseifert opened a new pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for loading e

2021-02-25 Thread GitBox
stefanseifert opened a new pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42 see https://issues.apache.org/jira/browse/SLING-10167 This is an automated message from the Apache

[jira] [Commented] (SLING-10167) MapEntries.loadAliases generets JCR queries with illegal absolute paths

2021-02-25 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291143#comment-17291143 ] Stefan Seifert commented on SLING-10167: for some reason these illegal paths in the JCR query do

[jira] [Created] (SLING-10167) MapEntries.loadAliases generets JCR queries with illegal absolute paths

2021-02-25 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-10167: -- Summary: MapEntries.loadAliases generets JCR queries with illegal absolute paths Key: SLING-10167 URL: https://issues.apache.org/jira/browse/SLING-10167 Project:

Re: [VOTE] Release Apache Sling XSS Protection API 2.2.12

2021-02-25 Thread Daniel Klco
+1 On Thu, Feb 25, 2021 at 8:04 AM Radu Cotescu wrote: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12349722 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2414/ > > You can use this UNIX

[jira] [Commented] (SLING-10158) XSSFilter fails with a classloading error with the TreeWalker class

2021-02-25 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291129#comment-17291129 ] Eric Norman commented on SLING-10158: - [~radu] Not a problem.  I noticed the troubles right away

[jira] [Resolved] (SLING-10116) Add Maintenance Job to Starter and CMS

2021-02-25 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10116. -- Resolution: Fixed Done in

[jira] [Assigned] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-10159: Assignee: Carsten Ziegeler > Handle framework properties after the feature is

[jira] [Resolved] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10159. -- Resolution: Fixed Thanks [~NMuzaffar] - i've applied your PR > Handle framework

[GitHub] [sling-org-apache-sling-feature-launcher] cziegeler merged pull request #15: SLING-10159: Remove handling of framework properties before the feature is processed

2021-02-25 Thread GitBox
cziegeler merged pull request #15: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SLING-10123) Distribution agent queue processor should implement a backoff in case of retries for processing an item

2021-02-25 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290925#comment-17290925 ] Mohit Arora commented on SLING-10123: - [~ashishc], [~marett], should we implement an

Re: No OSGi SCR metadata in Unit Tests

2021-02-25 Thread Radu Cotescu
Hi Roy, > On 25 Feb 2021, at 10:37, Roy Teeuwen wrote: > > Is there an easy way in intellij to get those OSGi SCR xmls in a junit run > configuration without having to triggering a maven install / bundle execution > plugin first? Not that I know of. I usually do a mvn clean package when I’m

Re: Questions surfaced by SLING-9999

2021-02-25 Thread Radu Cotescu
Hi Olli, > On 22 Feb 2021, at 14:18, Oliver Lietz wrote: > > On Thursday, 18 February 2021 10:21:05 CET Radu Cotescu wrote: >> Hi, > > Hi Karl, hi Radu, > > Sorry for coming back late, I was again hit by severe bugs in Akonadi and > still trying to fully recover. > >> If nobody opposes in

[VOTE] Release Apache Sling XSS Protection API 2.2.12

2021-02-25 Thread Radu Cotescu
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12349722 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2414/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Commented] (SLING-10158) XSSFilter fails with a classloading error with the TreeWalker class

2021-02-25 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290901#comment-17290901 ] Radu Cotescu commented on SLING-10158: -- Thanks for fixing this, [~enorman]. I didn't see the error

Re: Cleanup of dist (https://dist.apache.org/repos/dist/release/sling/)

2021-02-25 Thread Bertrand Delacretaz
Hi, On Thu, Feb 25, 2021 at 12:56 PM Konrad Windszus wrote: > > The biggest difference is that without binaries it becomes possible again to > checkout > dist again and clean it up without solely relying on svn import/export... What kind of cleanup is needed? If we write some sanity check

[jira] [Comment Edited] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-02-25 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290856#comment-17290856 ] Angela Schreiber edited comment on SLING-10164 at 2/25/21, 12:17 PM: -

Re: Cleanup of dist (https://dist.apache.org/repos/dist/release/sling/)

2021-02-25 Thread Konrad Windszus
The biggest difference is that without binaries it becomes possible again to checkout dist again and clean it up without solely relying on svn import/export. That is way more comfortable and allows to use other tools than CLI for that. Regarding filtering what needs to be put to dist, that can

[jira] [Comment Edited] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Muzaffar Nurmukhammadov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290872#comment-17290872 ] Muzaffar Nurmukhammadov edited comment on SLING-10159 at 2/25/21, 11:49 AM:

[jira] [Commented] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Muzaffar Nurmukhammadov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290872#comment-17290872 ] Muzaffar Nurmukhammadov commented on SLING-10159: - [~cziegeler] Reverted back handling

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #15: SLING-10159: Remove handling of framework properties before the feature is processed

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/15#issuecomment-785835699 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #15: SLING-10159: Remove handling of framework properties before the feature is processed

2021-02-25 Thread GitBox
sonarcloud[bot] removed a comment on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/15#issuecomment-785025362 Kudos, SonarCloud Quality Gate passed!

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-02-25 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290856#comment-17290856 ] Angela Schreiber commented on SLING-10164: -- [~cziegeler], i wasn't planning to add more metrics

Re: Cleanup of dist (https://dist.apache.org/repos/dist/release/sling/)

2021-02-25 Thread Carsten Ziegeler
You should have automation in place to detect issues - that used to be in place, not sure if it still is. As soon as its more than 10 files any manual process will fail. If we start to exclude files from being put into dist, I think the release process is even harder than today - as I need to

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-02-25 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290851#comment-17290851 ] Carsten Ziegeler commented on SLING-10164: -- [~angela] The patch looks good to me, thanks - are

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-02-25 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290843#comment-17290843 ] Angela Schreiber commented on SLING-10164: -- [~cziegeler], as discussed. very basic (and

[jira] [Commented] (SLING-10159) Handle framework properties after the feature is processed

2021-02-25 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290842#comment-17290842 ] Carsten Ziegeler commented on SLING-10159: -- Maybe we could reduce the change to just not set

[jira] [Updated] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-02-25 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10164: - Attachment: SLING-10164.patch > Add basic metrics to SlingAuthenticator >

[GitHub] [sling-parent] sonarcloud[bot] commented on pull request #15: SLING-10160 generate source-release.zip for both parent poms

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #15: URL: https://github.com/apache/sling-parent/pull/15#issuecomment-785801590 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-parent=15=false=BUG)

Re: [VOTE] SLING-10147 Require WebConsoleSecurityProvider2 service to exist?

2021-02-25 Thread Bertrand Delacretaz
Hi Eric, Thanks for presenting both options! On Wed, Feb 24, 2021 at 10:00 PM Eric Norman wrote: ... > B. PR #7 > ... > [X ] +1B Approve the solution from PR #7 .. I'm in favor of that one as it's less code. The only

Re: Cleanup of dist (https://dist.apache.org/repos/dist/release/sling/)

2021-02-25 Thread Bertrand Delacretaz
On Thu, Feb 25, 2021 at 9:54 AM Konrad Windszus wrote: >... It is close to impossible to detect issues like these with 6k files >without tooling. Assuming we have 300 modules, the minimum number of files in there is N*300 which IMHO doesn't work anyway for manual inspection. At least not at

RE: No OSGi SCR metadata in Unit Tests

2021-02-25 Thread Stefan Seifert
to be honest if have very little knowledge on the IntelliJ side as i'm mostly an eclipse user. i tried it today in IntelliJ and it worked, probably because the generated metadata was already there. perhaps a more experienced IntelliJ user can provide more information here. stefan

[GitHub] [sling-parent] kwin opened a new pull request #15: SLING-10160 generate source-release.zip for both parent poms

2021-02-25 Thread GitBox
kwin opened a new pull request #15: URL: https://github.com/apache/sling-parent/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: No OSGi SCR metadata in Unit Tests

2021-02-25 Thread Roy Teeuwen
Interesting that you mention Intellij Stefan? Because If i wouldn't do a mvn install first before executing the unit tests from the Intellij junit run configuration, it will fail with the exact reason stated. Is there an easy way in intellij to get those OSGi SCR xmls in a junit run

[jira] [Created] (SLING-10166) Fix vulnerabilities, bugs and code smells reported by Sonar

2021-02-25 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10166: Summary: Fix vulnerabilities, bugs and code smells reported by Sonar Key: SLING-10166 URL: https://issues.apache.org/jira/browse/SLING-10166 Project: Sling

[jira] [Assigned] (SLING-10160) Create source-release.zip for pom artifacts

2021-02-25 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10160: --- Assignee: Konrad Windszus > Create source-release.zip for pom artifacts >

[jira] [Created] (SLING-10165) Add nullable/notnull annotations to sling.auth.core

2021-02-25 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10165: Summary: Add nullable/notnull annotations to sling.auth.core Key: SLING-10165 URL: https://issues.apache.org/jira/browse/SLING-10165 Project: Sling

[GitHub] [sling-site] kwin commented on a change in pull request #55: download binaries (incl. hashes and signatures) from ASF Maven

2021-02-25 Thread GitBox
kwin commented on a change in pull request #55: URL: https://github.com/apache/sling-site/pull/55#discussion_r582653800 ## File path: src/main/jbake/templates/downloads.tpl ## @@ -324,6 +324,19 @@ def downloadLink(label, artifact, version, suffix) { newLine() } +def

[jira] [Commented] (SLING-10147) scripting variables implementation details are exposed to not authorized users

2021-02-25 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290791#comment-17290791 ] Julian Sedding commented on SLING-10147: [~enorman] it seems I didn't explain my suggestion

Re: Cleanup of dist (https://dist.apache.org/repos/dist/release/sling/)

2021-02-25 Thread Konrad Windszus
> What exact problems are you seeing? https://issues.apache.org/jira/browse/SLING-10153 https://issues.apache.org/jira/browse/SLING-10152 https://issues.apache.org/jira/browse/SLING-10151 In general I doubt that dist is very often used for downloading binaries and I want to reduce effort for

[jira] [Created] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-02-25 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10164: Summary: Add basic metrics to SlingAuthenticator Key: SLING-10164 URL: https://issues.apache.org/jira/browse/SLING-10164 Project: Sling Issue Type:

[GitHub] [sling-site] bdelacretaz commented on pull request #55: download binaries (incl. hashes and signatures) from ASF Maven

2021-02-25 Thread GitBox
bdelacretaz commented on pull request #55: URL: https://github.com/apache/sling-site/pull/55#issuecomment-785728056 Ok, I have commented on our dev list - I ask that you do not merge this PR for now, while we discuss there. I think it's good to use the ASF mirrors for all downloads and as

  1   2   >