[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher

stbischof commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r591862497 ## File path: Dockerfile ## @@ -0,0 +1,50 @@ +#

[jira] [Comment Edited] (SLING-10127) Keep modified content packages of type "content"

[ https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299381#comment-17299381 ] Angela Schreiber edited comment on SLING-10127 at 3/11/21, 7:43 AM:

[jira] [Updated] (SLING-10127) Keep modified content packages of type "content"

[ https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10127: - Issue Type: Bug (was: Improvement) > Keep modified content packages of type "content"

[jira] [Commented] (SLING-10127) Keep modified content packages of type "content"

[ https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299381#comment-17299381 ] Angela Schreiber commented on SLING-10127: -- [~kwin], thanks for highlighting that. very good

[jira] [Commented] (SLING-10127) Keep modified content packages of type "content"

[ https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299371#comment-17299371 ] Konrad Windszus commented on SLING-10127: - [~angela] This is somewhat related to SLING-10070. Is

[jira] [Updated] (SLING-10127) Keep modified content packages of type "content"

[ https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10127: Description: Currently in

[jira] [Commented] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299356#comment-17299356 ] Konrad Windszus commented on SLING-10205: - Before I come up with a PR a few other questions: Was

[jira] [Commented] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299337#comment-17299337 ] Carsten Ziegeler commented on SLING-10205: -- There are different things here: * Should the

[jira] [Commented] (SLING-10123) Distribution agent queue processor should implement a backoff in case of retries for processing an item

[ https://issues.apache.org/jira/browse/SLING-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299334#comment-17299334 ] Ashish Chopra commented on SLING-10123: --- hi [~mohiaror] bq. should we implement an

RE: [VOTE] Release Apache Sling Resource Merger 1.4.0

+1

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher

stbischof commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r591862497 ## File path: Dockerfile ## @@ -0,0 +1,50 @@ +#

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-795970691 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-795390576 Kudos, SonarCloud Quality Gate passed!

[jira] [Resolved] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10155. - Resolution: Fixed Feedback from the reviews has been integrated and no objections remain, so I

[GitHub] [sling-org-apache-sling-scripting-core] enapps-enorman merged pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

enapps-enorman merged pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Comment Edited] (SLING-9871) Specifying order of ACEs through repoinit directives

[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299018#comment-17299018 ] Eric Norman edited comment on SLING-9871 at 3/10/21, 5:56 PM: --

[jira] [Comment Edited] (SLING-9871) Specifying order of ACEs through repoinit directives

[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299018#comment-17299018 ] Eric Norman edited comment on SLING-9871 at 3/10/21, 5:55 PM: --

[jira] [Comment Edited] (SLING-9871) Specifying order of ACEs through repoinit directives

[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299018#comment-17299018 ] Eric Norman edited comment on SLING-9871 at 3/10/21, 5:53 PM: --

[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives

[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299018#comment-17299018 ] Eric Norman commented on SLING-9871: [~bdelacretaz] That may be workable for a simple flat set of

[jira] [Commented] (SLING-10206) Install content packages with import option strict

[ https://issues.apache.org/jira/browse/SLING-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298833#comment-17298833 ] Timothee Maret commented on SLING-10206: I agree, we should enable strict mode by default.

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-792336653 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-795390576 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-795388674 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-792336824 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

sonarcloud[bot] removed a comment on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#issuecomment-792336503 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

sonarcloud[bot] commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#issuecomment-795385390 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-790865953 SonarCloud Quality Gate failed.

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-795384783 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #11: SLING-10087 convert more persistenceexceptions

sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-795380882 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=11=false=BUG)

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #11: SLING-10087 convert more persistenceexceptions

sonarcloud[bot] removed a comment on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-789699262 SonarCloud Quality Gate failed.

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298784#comment-17298784 ] Stefan Egli commented on SLING-10204: - I'm a bit hesitant to silence these exceptions. They can

[jira] [Updated] (SLING-10206) Install content packages with import option strict

[ https://issues.apache.org/jira/browse/SLING-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10206: Description: Currently content packages are only installed in a best effort manner

[jira] [Updated] (SLING-10206) Install content packages with import option strict

[ https://issues.apache.org/jira/browse/SLING-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10206: Description: Currently content packages are only installed in a best effort manner

[jira] [Commented] (SLING-10206) Install content packages with import option strict

[ https://issues.apache.org/jira/browse/SLING-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298772#comment-17298772 ] Konrad Windszus commented on SLING-10206: - [~marett] WDYT? > Install content packages with

[jira] [Created] (SLING-10206) Install content packages with import option strict

Konrad Windszus created SLING-10206: --- Summary: Install content packages with import option strict Key: SLING-10206 URL: https://issues.apache.org/jira/browse/SLING-10206 Project: Sling

[jira] [Comment Edited] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298758#comment-17298758 ] Konrad Windszus edited comment on SLING-10205 at 3/10/21, 11:40 AM:

[jira] [Commented] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298758#comment-17298758 ] Konrad Windszus commented on SLING-10205: - [~cziegeler] You once said in the context of

[jira] [Updated] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10205: Description: Currently only specific properties are being transferred to the converted

[jira] [Updated] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10205: Description: Currently only specific properties are being transferred to the converted

[jira] [Updated] (SLING-10205) Support converting packages with custom properties

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10205: Description: Currently only specific properties are being tekan > Support converting

[jira] [Updated] (SLING-10205) Support converting packages with custom properties and install hooks

[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10205: Summary: Support converting packages with custom properties and install hooks (was:

[jira] [Created] (SLING-10205) Support converting packages with custom properties

Konrad Windszus created SLING-10205: --- Summary: Support converting packages with custom properties Key: SLING-10205 URL: https://issues.apache.org/jira/browse/SLING-10205 Project: Sling

Re: Coverage difference local and with SonarQube

True - I should have just pasted these lines from my run (probably need another coffee): [INFO] Running org.apache.sling.resourcemerger.impl.CommonMergedResourceProviderTest [main] WARN org.apache.sling.resourcemerger.impl.HideItemPredicate - Negated and non-negated values mixed in

Re: Coverage difference local and with SonarQube

Now we are at 75% in SonarCloud as well: https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourcemerger=coverage=list Thanks again for the pointer, Konrad > On 10.

Re: Coverage difference local and with SonarQube

HI Radu, thanks for that hint. Most of the coverage comes from MergedResourceProviderTestForSearchPathBasedPicker. That is just not executed by Maven Surefire because it is not compliant with the naming pattern (https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#includes).

Re: Coverage difference local and with SonarQube

Hi Konrad, For what it’s worth I do get a 2% line coverage for org.apache.sling.resourcemerger.impl.CRUDMergingResourceProvider when running org.apache.sling.resourcemerger.impl.CommonMergedResourceProviderTest in IntelliJ. Same when I run mvn clean verify -Pjacoco-report. Regards, Radu

[jira] [Updated] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10204: Description: The following exception has been witnessed during resource resolver factory

[jira] [Updated] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10204: Description: The following exception has been witnessed during resource resolver factory

[jira] [Updated] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10204: Description: The following exception has been witnessed during resource resolver factory

Re: [VOTE] Release Apache Sling Resource Merger 1.4.0

On Wed, 2021-03-10 at 10:13 +0100, Konrad Windszus wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[VOTE] Release Apache Sling Resource Merger 1.4.0

Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12349943 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2419/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Commented] (SLING-10143) bundles referenced in sling starter are out of date

[ https://issues.apache.org/jira/browse/SLING-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298667#comment-17298667 ] Robert Munteanu commented on SLING-10143: - FWIW, we now have an issue for the oak.discovery

Re: March 2021 board report draft

On Tue, 2021-03-09 at 11:02 +0100, Robert Munteanu wrote: > Sorry, sent to soon. The statement 'I think' if hopefully not needed :- > ) > > On Tue, 2021-03-09 at 10:57 +0100, Robert Munteanu wrote: > > Hi Cris, > > > > On Fri, 2021-03-05 at 07:57 -0500, Cris Rockwell wrote: > > > Hi Robert > > >

[jira] [Created] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

Stefan Egli created SLING-10204: --- Summary: Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository Key: SLING-10204 URL: https://issues.apache.org/jira/browse/SLING-10204

[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives

[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298643#comment-17298643 ] Bertrand Delacretaz commented on SLING-9871: bq. the order in which set ACL statements

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher

rombert commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r591218694 ## File path: Dockerfile ## @@ -0,0 +1,50 @@ +#

[jira] [Resolved] (SLING-10186) Enhance cli parsing on sling-feature-launcher

[ https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-10186. - Fix Version/s: Feature Model Launcher 1.1.18 Resolution: Fixed PR applied,

[jira] [Assigned] (SLING-10186) Enhance cli parsing on sling-feature-launcher

[ https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-10186: --- Assignee: Robert Munteanu > Enhance cli parsing on sling-feature-launcher >

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on pull request #17: SLING-10186 - Enhance cli parsing on sling-feature-launcher

rombert commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-795088698 Thanks @stbischof for the contribution ant @bosschaert for the review! This is an

[GitHub] [sling-org-apache-sling-feature-launcher] rombert merged pull request #17: SLING-10186 - Enhance cli parsing on sling-feature-launcher

rombert merged pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [VOTE] Release Apache Sling Testing JCR Mock 1.5.2, OSGi Mock 3.1.0, Sling Mock 3.0.2

On Tue, 2021-03-09 at 19:29 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[jira] [Resolved] (SLING-10201) Unclosed session in ExecutionPlanRepoInitializer

[ https://issues.apache.org/jira/browse/SLING-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10201. - Assignee: Konrad Windszus Resolution: Fixed Fixed in

[GitHub] [sling-org-apache-sling-jcr-packageinit] kwin merged pull request #4: SLING-10201 fix unclosed JCR session

kwin merged pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use