[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin merged pull request #63: SLING-10221 don't add package metadata below jcr_root

2021-03-17 Thread GitBox
kwin merged pull request #63: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Resolved] (SLING-10221) Package metadata appears below jcr_root in transformed packages

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10221. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-feature-cpc

[jira] [Created] (SLING-10227) Improvement in distribution logging to log id generated for binary reference and not log reference

2021-03-17 Thread Amit Jain (Jira)
Amit Jain created SLING-10227: - Summary: Improvement in distribution logging to log id generated for binary reference and not log reference Key: SLING-10227 URL: https://issues.apache.org/jira/browse/SLING-10227

[jira] [Commented] (SLING-10227) Improvement in distribution logging to log id generated for binary reference and not log reference

2021-03-17 Thread Amit Jain (Jira)
[ https://issues.apache.org/jira/browse/SLING-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303195#comment-17303195 ] Amit Jain commented on SLING-10227: --- Ok I think the changes are not misaligned as I no

[jira] [Comment Edited] (SLING-10227) Improvement in distribution logging to log id generated for binary reference and not log reference

2021-03-17 Thread Amit Jain (Jira)
[ https://issues.apache.org/jira/browse/SLING-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303195#comment-17303195 ] Amit Jain edited comment on SLING-10227 at 3/17/21, 8:41 AM: -

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela merged pull request #61: SLING-10210 : Option to enforce service-user-mapping with principal names

2021-03-17 Thread GitBox
anchela merged pull request #61: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (SLING-10210) Option to enforce service-user-mapping with principal names

2021-03-17 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-10210. -- Assignee: Angela Schreiber Resolution: Fixed > Option to enforce service-user-ma

[jira] [Commented] (SLING-10224) Feature-Launcher: Substitute variables without commons-lang3 and commons-text

2021-03-17 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303236#comment-17303236 ] Bertrand Delacretaz commented on SLING-10224: - bq. commons-lang3 and common

[GitHub] [sling-org-apache-sling-feature-launcher] bdelacretaz commented on pull request #20: SLING-10224: Substitute variables without commons-lang3 and commons-text

2021-03-17 Thread GitBox
bdelacretaz commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/20#issuecomment-800942846 See my comment in https://issues.apache.org/jira/browse/SLING-10224 about more specific `-conditionalpackage` instructions. ---

[jira] [Updated] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10207: Description: Namespace and node type definitions can not only be given in {{/META-INF/vau

[jira] [Reopened] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reopened SLING-10207: - Assignee: Konrad Windszus > NodeTypesEntryHandler does not consider CND files outside

[jira] [Updated] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10207: Description: Namespace and node type definitions can not only be given in {{/META-INF/vau

[jira] [Issue Comment Deleted] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10207: Comment: was deleted (was: This actually not true, as custom NodeTypesEntryHandlers are re

[jira] [Updated] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10207: Fix Version/s: Content-Package to Feature Model Converter 1.0.26 > NodeTypesEntryHandler d

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin opened a new pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
kwin opened a new pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65#issuecomment-800972602 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65#issuecomment-800972602 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpco

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65#issuecomment-800979919 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[jira] [Commented] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303292#comment-17303292 ] Carsten Ziegeler commented on SLING-10207: -- [~kwin] If I read the code correctl

[jira] [Commented] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303294#comment-17303294 ] Konrad Windszus commented on SLING-10207: - [~cziegeler] Right, that is another b

[jira] [Comment Edited] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303294#comment-17303294 ] Konrad Windszus edited comment on SLING-10207 at 3/17/21, 11:07 AM: --

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65#issuecomment-800997465 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65#issuecomment-800979919 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpco

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #390 is BROKEN

2021-03-17 Thread Apache Jenkins Server
n: 0 generated: 0 approved: 5 licence. [INFO] [INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ org.apache.sling.launchpad.testing --- [INFO] [INFO] BUILD FAILURE [INFO] ---- [INFO] Total time: 03:21

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #391 is FIXED

2021-03-17 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/391/ for details. No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin merged pull request #65: SLING-10207 correctly extract CND files below jcr_root

2021-03-17 Thread GitBox
kwin merged pull request #65: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Resolved] (SLING-10207) NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

2021-03-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10207. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-feature-cpc

[jira] [Created] (SLING-10228) Unused property PROP_NODETYPES in AclLine

2021-03-17 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10228: Summary: Unused property PROP_NODETYPES in AclLine Key: SLING-10228 URL: https://issues.apache.org/jira/browse/SLING-10228 Project: Sling Issue Type:

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #20: SLING-10224: Substitute variables without commons-lang3 and commons-text

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/20#issuecomment-800718147 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #20: SLING-10224: Substitute variables without commons-lang3 and commons-text

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/20#issuecomment-801041356 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe

[jira] [Commented] (SLING-10224) Feature-Launcher: Substitute variables without commons-lang3 and commons-text

2021-03-17 Thread Stefan Bischof (Jira)
[ https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303352#comment-17303352 ] Stefan Bischof commented on SLING-10224: I will have a look at. My first guess

[jira] [Updated] (SLING-10224) Feature-Launcher: Copy only used Classes from apache-commons

2021-03-17 Thread Stefan Bischof (Jira)
[ https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bischof updated SLING-10224: --- Summary: Feature-Launcher: Copy only used Classes from apache-commons (was: Feature-Launche

[GitHub] [sling-org-apache-sling-feature-launcher] bdelacretaz commented on pull request #20: SLING-10224: Copy only used Classes from apache-commons

2021-03-17 Thread GitBox
bdelacretaz commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/20#issuecomment-801046080 Good idea to use `maven-dependency-plugin`, I think that works! I'm much more comfortable with this than adding more non-specific code to the Sli

[jira] [Created] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-03-17 Thread Stefan Bischof (Jira)
Stefan Bischof created SLING-10229: -- Summary: [LauncherContainer]Set up automated builds for this Docker image Key: SLING-10229 URL: https://issues.apache.org/jira/browse/SLING-10229 Project: Sling

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #11: SLING-10087 convert more persistenceexceptions

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-801062390 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&reso

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #11: SLING-10087 convert more persistenceexceptions

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-795380882 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest

[jira] [Created] (SLING-10230) DeleteServiceUser, DisableServiceUser extend from OperationWithPathOptions

2021-03-17 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10230: Summary: DeleteServiceUser, DisableServiceUser extend from OperationWithPathOptions Key: SLING-10230 URL: https://issues.apache.org/jira/browse/SLING-10230 Pr

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-801065985 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-797003615 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-797006568 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-801067477 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-03-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-797009273 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-801068984 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[jira] [Created] (SLING-10231) CreatePath/PathSegmentDefinition don't allow to extract the original repo-init statements

2021-03-17 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10231: Summary: CreatePath/PathSegmentDefinition don't allow to extract the original repo-init statements Key: SLING-10231 URL: https://issues.apache.org/jira/browse/SLING-10231

[jira] [Created] (SLING-10232) CreatePath doesn't allow to add node without explicit primary type

2021-03-17 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10232: Summary: CreatePath doesn't allow to add node without explicit primary type Key: SLING-10232 URL: https://issues.apache.org/jira/browse/SLING-10232 Project: S

[jira] [Updated] (SLING-10232) CreatePath doesn't allow to add node without explicit primary type

2021-03-17 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10232: - Component/s: Repoinit > CreatePath doesn't allow to add node without explicit primary ty

[GitHub] [sling-org-apache-sling-testing-jcr-mock] royteeuwen opened a new pull request #6: Add possibility to update the jcr primary type of nodes

2021-03-17 Thread GitBox
royteeuwen opened a new pull request #6: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/6 I am not sure why you can't set the primary type yet, so thats why I have this PR to see if there are any objections -

[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #6: Add possibility to update the jcr primary type of nodes

2021-03-17 Thread GitBox
sonarcloud[bot] commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/6#issuecomment-801083739 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequ

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-03-17 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303456#comment-17303456 ] Angela Schreiber commented on SLING-10164: -- [~cziegeler], subtle reminder wrt t

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-03-17 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303475#comment-17303475 ] Carsten Ziegeler commented on SLING-10164: -- [~angela] It's probably better if s

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-03-17 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303507#comment-17303507 ] Angela Schreiber commented on SLING-10164: -- [~cziegeler], [~rombert] who would

[GitHub] [sling-org-apache-sling-auth-core] bdelacretaz commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
bdelacretaz commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596178215 ## File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java ## @@ -457,6 +465,13 @@ private void deactivat

[GitHub] [sling-org-apache-sling-auth-core] bdelacretaz commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
bdelacretaz commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596179124 ## File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java ## @@ -492,15 +507,17 @@ public boolean handle

[GitHub] [sling-org-apache-sling-auth-core] bdelacretaz commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
bdelacretaz commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596180981 ## File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java ## @@ -492,15 +507,17 @@ public boolean handle

[GitHub] [sling-org-apache-sling-auth-core] bdelacretaz commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
bdelacretaz commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596181527 ## File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticationMetrics.java ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [sling-org-apache-sling-auth-core] bdelacretaz commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
bdelacretaz commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596183777 ## File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorOsgiTest.java ## @@ -0,0 +1,89 @@ +/* + * Licensed

[jira] [Commented] (SLING-10164) Add basic metrics to SlingAuthenticator

2021-03-17 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303548#comment-17303548 ] Bertrand Delacretaz commented on SLING-10164: - I'm not a specialist in eithe

[GitHub] [sling-org-apache-sling-auth-core] anchela commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
anchela commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596205108 ## File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java ## @@ -492,15 +507,17 @@ public boolean handleSecu

[GitHub] [sling-org-apache-sling-auth-core] anchela commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
anchela commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596205470 ## File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java ## @@ -492,15 +507,17 @@ public boolean handleSecu

[GitHub] [sling-org-apache-sling-auth-core] anchela commented on a change in pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-17 Thread GitBox
anchela commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596206299 ## File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorOsgiTest.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to t

[jira] [Commented] (SLING-10224) Feature-Launcher: Copy only used Classes from apache-commons

2021-03-17 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303631#comment-17303631 ] Bertrand Delacretaz commented on SLING-10224: - I have pushed to a new branch

[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives

2021-03-17 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303658#comment-17303658 ] Eric Norman commented on SLING-9871: [~bdelacretaz] If we are going to support ACL or

[jira] [Comment Edited] (SLING-9871) Specifying order of ACEs through repoinit directives

2021-03-17 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303658#comment-17303658 ] Eric Norman edited comment on SLING-9871 at 3/17/21, 7:02 PM: -

[GitHub] [sling-site] kwin merged pull request #57: SLING-10150 clarify handling of multivalue properties sling:hideChildren

2021-03-17 Thread GitBox
kwin merged pull request #57: URL: https://github.com/apache/sling-site/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (SLING-10233) Optionally split mixed content packages into mutable and immutable ones

2021-03-17 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-10233: --- Summary: Optionally split mixed content packages into mutable and immutable ones Key: SLING-10233 URL: https://issues.apache.org/jira/browse/SLING-10233 Project