kwin edited a comment on pull request #70:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818556608
@karlpauls `dropContent` is only an internal field name and can imho be
renamed to reflect that this is only about not referencing it in the
kwin edited a comment on pull request #70:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818556608
@karlpauls `dropContent` is only an internal flag and can imho be renamed to
reflect that this is only about not referencing it in the
kwin commented on pull request #70:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818556608
@karlpauls `dropContent` is only an internal flag and can imho be renamed to
reflect that this is only about not referencing it in the feature
sonarcloud[bot] removed a comment on pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#issuecomment-818552028
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#issuecomment-818552714
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#issuecomment-818552028
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#issuecomment-818549249
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#issuecomment-818549249
Kudos, SonarCloud Quality Gate passed!
kwin opened a new pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
[
https://issues.apache.org/jira/browse/SLING-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1732#comment-1732
]
Robert Munteanu commented on SLING-10289:
-
Good catch [~AndreasWurm]. Would you have the time to
[
https://issues.apache.org/jira/browse/SLING-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10289:
Fix Version/s: Dynamic Include 3.2.2
> Sling Dynamic Include 3.2.0 configuration of
[
https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-10278.
-
Resolution: Fixed
Fixed in
kwin merged pull request #72:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
sonarcloud[bot] removed a comment on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-816482290
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-818518285
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=14=false=BUG)
karlpauls commented on pull request #70:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818516741
@kwin, I don't disagree that it might be a mistake to ignore "content"
content packages - however, that is what this option is specifically for
sonarcloud[bot] commented on pull request #70:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818516185
SonarCloud Quality Gate failed.
sonarcloud[bot] removed a comment on pull request #70:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817685935
SonarCloud Quality Gate failed.
sonarcloud[bot] removed a comment on pull request #72:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-818502836
SonarCloud Quality Gate failed.
sonarcloud[bot] commented on pull request #72:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-818516063
SonarCloud Quality Gate failed.
[
https://issues.apache.org/jira/browse/SLING-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10297:
Description: To ease parsing the {{Sling-Initial-Content}} header outside
the OSGi
Konrad Windszus created SLING-10297:
---
Summary: Expose
org.apache.sling.jcr.contentloader.internal.PathEntry as API
Key: SLING-10297
URL: https://issues.apache.org/jira/browse/SLING-10297
Project:
sonarcloud[bot] removed a comment on pull request #72:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-817970182
SonarCloud Quality Gate failed.
sonarcloud[bot] commented on pull request #72:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-818502836
SonarCloud Quality Gate failed.
kwin commented on pull request #72:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-818499494
@cziegeler Incorporated your feedback in
[
https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319949#comment-17319949
]
Carsten Ziegeler commented on SLING-10278:
--
Thanks, PR looks basically good to me - can we
I tend to agree that there is not that much value in moving this to the
api. I don't see any use cases for users of Sling's resource api to also
use this class.
Apart from the reasons mentioned, ResourceType talks about versioning -
a concept we currently don't have in the api.
In addition
101 - 127 of 127 matches
Mail list logo
