Re: Sling Declarative Dynamic Resources

2021-04-22 Thread Carsten Ziegeler
Thanks Ruben, in my opinion /apps belongs to developers. In our case its immutable for good reasons. Drilling a hole into this and allowing non developers contribute to /apps, especially in a dynamic fashion circumventing the immutability sounds very risky and can result in security problems.

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #438 is FIXED

2021-04-22 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/438/ for details. No further emails will be sent until the status of the build is changed.

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329466#comment-17329466 ] Eric Norman commented on SLING-10204: - [~stefanegli] I can confirm that the changes

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-22 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-824045589 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-22 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-825121992 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329310#comment-17329310 ] Stefan Egli commented on SLING-10204: - Attached an example patch that would fix it (

[jira] [Updated] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10204: Attachment: SLING-10204-2.git.patch > Make OakDiscoveryService.updatedPropertyProvider tolerate de

Re: Sling Declarative Dynamic Resources

2021-04-22 Thread Ruben Reusser
Carsten,  see inline On 4/22/2021 6:55 AM, Carsten Ziegeler wrote: Am 21.04.2021 um 15:30 schrieb Ruben Reusser: - for each website that is created we have to create a corresponding /apps folder for rendering purposes I assume the ddr solution is temporary and eventually the information is

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329208#comment-17329208 ] Stefan Egli commented on SLING-10204: - bq. Perhaps you intended to wrap the whole se

[GitHub] [sling-aggregator] klcodanr commented on pull request #3: fix badged link for groups

2021-04-22 Thread GitBox
klcodanr commented on pull request #3: URL: https://github.com/apache/sling-aggregator/pull/3#issuecomment-824850746 Looks like the effected projects are: ```org-apache-sling-scripting-javascript org-apache-sling-installer-provider-jcr org-apache-sling-karaf-features org-apache-

Re: Sling Declarative Dynamic Resources

2021-04-22 Thread Carsten Ziegeler
Am 21.04.2021 um 15:30 schrieb Ruben Reusser: Bertrand, Carsten, On 4/20/2021 10:57 PM, Carsten Ziegeler wrote: I totally agree that we should try to avoid overlapping solutions and as mentioned superimposing and ddr sound pretty similar. I understand the use cases on a higher level. However

[jira] [Comment Edited] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329102#comment-17329102 ] Eric Norman edited comment on SLING-10204 at 4/22/21, 1:12 PM: ---

[jira] [Comment Edited] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329102#comment-17329102 ] Eric Norman edited comment on SLING-10204 at 4/22/21, 1:13 PM: ---

[GitHub] [sling-aggregator] klcodanr merged pull request #3: fix badged link for groups

2021-04-22 Thread GitBox
klcodanr merged pull request #3: URL: https://github.com/apache/sling-aggregator/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #437 is BROKEN

2021-04-22 Thread Apache Jenkins Server
file "ci" could not be activated because it does not exist. [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven96b2293f/maven-spy-20210422-112659-5162997852325259085861.log [ERROR] Failed to execute goal org.apache.ma

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329102#comment-17329102 ] Eric Norman commented on SLING-10204: - [~stefanegli] Yes, there was definitely broke

[GitHub] [sling-aggregator] klcodanr commented on pull request #3: fix badged link for groups

2021-04-22 Thread GitBox
klcodanr commented on pull request #3: URL: https://github.com/apache/sling-aggregator/pull/3#issuecomment-824817904 Thanks for the patch @stbischof! IMO it'd be better to identify and fix the affected projects to avoid having broken links. -- This is an automated message from the Apach

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327244#comment-17327244 ] Stefan Egli commented on SLING-10204: - * tempered this log.error to warn similar to

[jira] [Reopened] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reopened SLING-10204: - > Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated > repository >

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository

2021-04-22 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327221#comment-17327221 ] Stefan Egli commented on SLING-10204: - Thx [~enorman] for reporting. Besides the fac

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof edited a comment on pull request #28: Badge-Link fix

2021-04-22 Thread GitBox
stbischof edited a comment on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/28#issuecomment-824668818 fix script PR: https://github.com/apache/sling-aggregator/pull/3 An other option would be to move the docs/groups folder in aggregate

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #28: Badge-Link fix

2021-04-22 Thread GitBox
stbischof commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/28#issuecomment-824668818 fix script PR: https://github.com/apache/sling-aggregator/pull/3 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [sling-aggregator] stbischof opened a new pull request #3: fix badged link for groups

2021-04-22 Thread GitBox
stbischof opened a new pull request #3: URL: https://github.com/apache/sling-aggregator/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [sling-org-apache-sling-feature-launcher] rombert edited a comment on pull request #28: Badge-Link fix

2021-04-22 Thread GitBox
rombert edited a comment on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/28#issuecomment-824663422 @stbischof - do you think you can then send a PR for the aggregator? I am not sure how many projects need a rebuild, but all the _feature_ on

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on pull request #28: Badge-Link fix

2021-04-22 Thread GitBox
rombert commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/28#issuecomment-824663422 @stbischof - I think you can then send a PR for the aggregator? I am not sure how many projects need a rebuild, but all the _feature_ ones I checked

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #28: Badge-Link fix

2021-04-22 Thread GitBox
stbischof commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/28#issuecomment-824661382 Ok, good to know that a script does this. The line with the missing `s`. https://github.com/apache/sling-aggregator/blob/59881f915e3a1b7f

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on pull request #28: Badge-Link fix

2021-04-22 Thread GitBox
rombert commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/28#issuecomment-824651435 Thanks for the PR @stbischof . IIRC we generate these badges with the scripts from https://github.com/apache/sling-aggregator . @klcodanr - is this

[CANCEL}[VOTE] Release Apache Sling Oak-Based Discovery Service 1.2.32

2021-04-22 Thread Stefan Egli
Hi Eric, Thanks, and appologies for this! I'm cancelling the release then. Seems the fix in SLING-10204 was not enough. I will look into reproducing this, ideally with a pax-exam, which this bundle doesn't have yet unfortunately. But it might be good to have anyway. Cheers, Stefan On 21.04

[jira] [Commented] (SLING-10321) Deprecate service mapping by userID

2021-04-22 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327160#comment-17327160 ] Angela Schreiber commented on SLING-10321: -- Sling Site updated to reflect the d

[jira] [Resolved] (SLING-10324) ServiceUserMapper documentation is incomplete

2021-04-22 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-10324. -- Resolution: Fixed > ServiceUserMapper documentation is incomplete > --

[GitHub] [sling-site] anchela merged pull request #58: SLING-10324 : ServiceUserMapper documentation is incomplete

2021-04-22 Thread GitBox
anchela merged pull request #58: URL: https://github.com/apache/sling-site/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [sling-site] anchela commented on pull request #58: SLING-10324 : ServiceUserMapper documentation is incomplete

2021-04-22 Thread GitBox
anchela commented on pull request #58: URL: https://github.com/apache/sling-site/pull/58#issuecomment-824596020 @karlpauls , unless you have any concerns or objections, i would go ahead and merge the doc changes. -- This is an automated message from the Apache Git Service. To respond to