[GitHub] [sling-org-apache-sling-auth-core] sagarmiglani commented on pull request #14: SLING-11867 - Empty mapping from ResourceMapper breaks authentication…

2023-05-09 Thread via GitHub
sagarmiglani commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/14#issuecomment-1541394770 @reschke @cziegeler Could you please review? Is it fine to change the "" to "/" or it should be skipped? Any suggestion? -- This is an automated message

[jira] [Resolved] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

2023-05-09 Thread Sagar Miglani (Jira)
[ https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Miglani resolved SLING-11861. --- Resolution: Won't Fix Marking this as won't fix, as suggestion here and in PR is to handle

[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #14: SLING-11867 - Empty mapping from ResourceMapper breaks authentication…

2023-05-09 Thread via GitHub
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/14#issuecomment-1541392835 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-auth-core] sagarmiglani opened a new pull request, #14: SLING-11867 - Empty mapping from ResourceMapper breaks authentication…

2023-05-09 Thread via GitHub
sagarmiglani opened a new pull request, #14: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/14 … requirement updates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (SLING-11867) Empty mapping from ResourceMapper breaks authentication requirement updates

2023-05-09 Thread Sagar Miglani (Jira)
Sagar Miglani created SLING-11867: - Summary: Empty mapping from ResourceMapper breaks authentication requirement updates Key: SLING-11867 URL: https://issues.apache.org/jira/browse/SLING-11867

[jira] [Updated] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

2023-05-09 Thread Sagar Miglani (Jira)
[ https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Miglani updated SLING-11861: -- Description: When a resource has a path less url as vanity path (eg:

Call for Presentations, Community Over Code 2023

2023-05-09 Thread Rich Bowen
(Note: You are receiving this because you are subscribed to the dev@ list for one or more Apache Software Foundation projects.) The Call for Presentations (CFP) for Community Over Code (formerly Apachecon) 2023 is open at https://communityovercode.org/call-for-presentations/, and will close Thu,

Re: [VOTE] Release Apache Sling Event API version 1.0.4 and Event 4.3.12

2023-05-09 Thread Jörg Hoh
+1 Jörg Am Mo., 8. Mai 2023 um 20:30 Uhr schrieb Daniel Klco : > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12353216 > https://issues.apache.org/jira/projects/SLING/versions/12353196 > > There are still some outstanding issues: >

[GitHub] [sling-org-apache-sling-installer-factory-configuration] cziegeler commented on pull request #9: SLING-11864 Add new exported interface for filtering default properties

2023-05-09 Thread via GitHub
cziegeler commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/9#issuecomment-1540795999 why not simply move the console code to this module? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (SLING-11864) Configuration merge/default values not considered in OSGi Installer Configuration Printer Web Console

2023-05-09 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721054#comment-17721054 ] Konrad Windszus commented on SLING-11864: - I think it makes sense to at least optionally only

[jira] [Commented] (SLING-11864) Configuration merge/default values not considered in OSGi Installer Configuration Printer Web Console

2023-05-09 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721047#comment-17721047 ] Carsten Ziegeler commented on SLING-11864: -- I think default values (metatype) are correctly

[GitHub] [sling-org-apache-sling-installer-factory-configuration] sonarcloud[bot] commented on pull request #9: SLING-11864 Add new exported interface for filtering default properties

2023-05-09 Thread via GitHub
sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/9#issuecomment-1540718442 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Commented] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-09 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721045#comment-17721045 ] Konrad Windszus commented on SLING-10771: - How is this used in the WebConsole? When exactly does

[jira] [Commented] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-09 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721043#comment-17721043 ] Carsten Ziegeler commented on SLING-10771: -- no, config admin has no clue about metatype. all

[GitHub] [sling-org-apache-sling-event-api] sonarcloud[bot] commented on pull request #1: SLING-5884 : deprecate job queries, introduce query-free JobManager2,…

2023-05-09 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-event-api/pull/1#issuecomment-1540630993 SonarCloud Quality Gate failed. [![Quality Gate

Re: [VOTE] Release Apache Sling Event API version 1.0.4 and Event 4.3.12

2023-05-09 Thread Daniel Klco
+1 On Tue, May 9, 2023 at 1:38 PM Stefan Seifert wrote: > > +1 > > stefan

RE: [VOTE] Release Apache Sling Event API version 1.0.4 and Event 4.3.12

2023-05-09 Thread Stefan Seifert
+1 stefan

[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin commented on a diff in pull request #9: SLING-11864 Add new exported interface for filtering default properties

2023-05-09 Thread via GitHub
kwin commented on code in PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/9#discussion_r1188920636 ## src/main/java/org/apache/sling/installer/factories/configuration/ConfigurationMerger.java: ## @@ -0,0 +1,50 @@ +/* + *

[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin opened a new pull request, #9: SLING-11864 Add new exported interface for filtering default properties

2023-05-09 Thread via GitHub
kwin opened a new pull request, #9: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/9 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

RE: SLING-11865 - Conversion fails when initial content document does not include namespace declaration

2023-05-09 Thread Stefan Seifert
1 is definitely the better approach. as konrad mentioned as well, 1 could be combined with improved defaults in the downstream-tooling (e.g. aem analyser plugin). it should be possible to register the well-known namespaces used in AEM context there as default, that should cover most of the

[jira] [Commented] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-09 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720861#comment-17720861 ] Konrad Windszus commented on SLING-10771: - [~cziegeler] Does this imply that Felix internally

[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-09 Thread via GitHub
cziegeler commented on code in PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1188295311 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java: ## @@ -397,8 +397,8 @@ public void