[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #11: Issues/sling 11741

2023-09-19 Thread via GitHub
cziegeler commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1726968834 @jsedding I'll have a look to see what we can do at runtime *without* creating/deleting configurations -- This is an automated message from the Apache Git

[jira] [Commented] (SLING-10417) Create execution plans with "strict" import option

2023-09-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766933#comment-17766933 ] Robert Munteanu commented on SLING-10417: - [~kwin] - I plan to release a new version of the

[GitHub] [sling-org-apache-sling-feature-extension-content] rombert merged pull request #19: SLING-12028 - Content Deployment Extension tests fail on Windows

2023-09-19 Thread via GitHub
rombert merged PR #19: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-feature-extension-content] sonarcloud[bot] commented on pull request #19: SLING-12028 - Content Deployment Extension tests fail on Windows

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/19#issuecomment-1726442077 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-extension-content] rombert opened a new pull request, #19: SLING-12028 - Content Deployment Extension tests fail on Windows

2023-09-19 Thread via GitHub
rombert opened a new pull request, #19: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/19 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (SLING-12028) Content Deployment Extension tests fail on Windows

2023-09-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12028: Description: {noformat} [ERROR]

[jira] [Created] (SLING-12028) Content Deployment Extension tests fail on Windows

2023-09-19 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-12028: --- Summary: Content Deployment Extension tests fail on Windows Key: SLING-12028 URL: https://issues.apache.org/jira/browse/SLING-12028 Project: Sling

[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17

2023-09-19 Thread via GitHub
schaefa commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1726383479 @rombert I will check it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[RESULT] [VOTE] Release Apache Sling GraphQL Core version 0.0.24

2023-09-19 Thread Andreas Schaefer
Hi Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Joerg Hoh, Robert Munteanu +1 (non binding): none Can a PMC push the release to https://dist.apache.org/repos/dist/release/sling/. I will finish the rest afterwards. Cheers - Andy

Re: Vote on latest Sling GraphQL Core release 0.0.24

2023-09-19 Thread Andreas Schaefer
Hi Robert I will do that next time. Regarding Java 17 - I saw your updated the Wiki page related to that but I did not have time to check it out yet. I will try to solve this ASAP but Pax Exam so far is not cooperating. Cheers - Andy > On Sep 19, 2023, at 2:33 AM, Robert Munteanu wrote: > >

RE: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.4

2023-09-19 Thread Stefan Seifert
+1 stefan

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1725643620 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1725636036 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.4

2023-09-19 Thread Daniel Klco
+1 On Tue, Sep 19, 2023 at 4:45 AM Robert Munteanu wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353201 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2783/ > > You can use this

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #11: Issues/sling 11741

2023-09-19 Thread via GitHub
cziegeler commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1725470467 I think we have two options: we do a clever implementation like we have here which does the conversion behind the scenes and warns users to switch to the new

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #84: SLING-11352 - Fix parsing of path-only mappings

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1725352847 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: Simpler Feature flags for sling

2023-09-19 Thread Robert Munteanu
Hi Christian, On Mon, 2023-09-18 at 16:57 +0200, Christian Schneider wrote: > I propose that we expose feature toggles using a prefix + the toggle > name. > So for example it could be "org.apache.sling.toggle.FT-SLING-1234". > > I have already experimented with this and it seems feasible. This

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #78: Various improvements for the webconsole plugin

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1725350633 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1725350231 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #41: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41#issuecomment-1725349711 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Updated] (SLING-11778) Test that the feature models generated by the CPConverter are deployable

2023-09-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11778: Fix Version/s: Content-Package to Feature Model Converter 1.3.6

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #171: Update to parent version 52

2023-09-19 Thread via GitHub
rombert merged PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #171: Update to parent version 52

2023-09-19 Thread via GitHub
rombert commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725175368 Thanks @kwin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #171: Update to parent version 52

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725163418 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: Vote on latest Sling GraphQL Core release 0.0.24

2023-09-19 Thread Robert Munteanu
Hi Andy, On Mon, 2023-09-18 at 09:53 -0700, Andreas Schaefer wrote: > Hi > > I need one more vote to release Sling GraphQL Core 0.0.24. This has > an important update to handle fields with the same simple name aka > name. Right now previous fields are dropped and so I moved that to a > Multi

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #171: Update to parent version 52

2023-09-19 Thread via GitHub
kwin commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725152174 @rombert Done in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171/commits/f829e5a9d322e7029195169e761ae644026fa3c5. -- This

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.24

2023-09-19 Thread Robert Munteanu
On Mon, 2023-09-11 at 11:23 -0700, Andreas Schaefer wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[GitHub] [sling-org-apache-sling-graphql-core] rombert commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17

2023-09-19 Thread via GitHub
rombert commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1725134314 @raducotescu @schaefa - I think this is mostly done, but one test fails and it requires more GraphQL insight > [ERROR] Failures: > [ERROR]

[GitHub] [sling-org-apache-sling-graphql-core] rombert opened a new pull request, #38: SLING-12027 - GraphQL core fails to build with Java 17

2023-09-19 Thread via GitHub
rombert opened a new pull request, #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (SLING-12027) GraphQL core fails to build with Java 17

2023-09-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12027: --- Assignee: Robert Munteanu > GraphQL core fails to build with Java 17 >

[jira] [Created] (SLING-12027) GraphQL core fails to build with Java 17

2023-09-19 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-12027: --- Summary: GraphQL core fails to build with Java 17 Key: SLING-12027 URL: https://issues.apache.org/jira/browse/SLING-12027 Project: Sling Issue Type:

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #171: Update to parent version 52

2023-09-19 Thread via GitHub
rombert commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725081765 @kwin - there seems to be a conflict with Parent 52 and the changes you made in ccae72b792745600ceac75aeff444da43bb284c5 for SLING-11396. Can you

[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.4

2023-09-19 Thread Robert Munteanu
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12353201 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2783/ You can use this UNIX script to download the release and verify the signatures:

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert opened a new pull request, #171: Update to parent version 52

2023-09-19 Thread via GitHub
rombert opened a new pull request, #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (SLING-11844) Index definitions must not be extracted from empty nodes

2023-09-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11844. - Resolution: Fixed PR applied, thanks [~abhigarg]! > Index definitions must not be

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #170: SLING-11844 handling empty index definitions

2023-09-19 Thread via GitHub
rombert merged PR #170: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #235: chore(deps): update dependency org.apache.felix:org.apache.felix.healthcheck.core to v2.2.0

2023-09-19 Thread via GitHub
renovate-bot opened a new pull request, #235: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/235 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #234: chore(deps): update dependency com.h2database:h2-mvstore to v2.2.224

2023-09-19 Thread via GitHub
renovate-bot opened a new pull request, #234: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/234 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-19 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329754434 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software

[GitHub] [sling-org-apache-sling-jcr-base] bdelacretaz commented on a diff in pull request #11: Issues/sling 11741

2023-09-19 Thread via GitHub
bdelacretaz commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329749920 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software

[GitHub] [sling-org-apache-sling-jcr-base] bdelacretaz commented on a diff in pull request #11: Issues/sling 11741

2023-09-19 Thread via GitHub
bdelacretaz commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329745936 ## src/main/java/org/apache/sling/jcr/base/internal/AllowListFragment.java: ## @@ -32,59 +32,58 @@ import static java.util.Arrays.asList;

[jira] [Assigned] (SLING-11844) Index definitions must not be extracted from empty nodes

2023-09-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11844: --- Assignee: Abhishek Garg > Index definitions must not be extracted from empty nodes

[jira] [Updated] (SLING-12026) Check for implementation/extension of provider types

2023-09-19 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12026: Description: OSGi distinguishes between

[jira] [Updated] (SLING-12026) Check for implementation/extension of provider types

2023-09-19 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12026: Summary: Check for implementation/extension of provider types (was: Check for

Re: ASM library to parse class files?

2023-09-19 Thread Carsten Ziegeler
I don't see any concern with using asm. However, the analyser bundle has already quiet a few dependencies (mainly due to the native support for content packages). So maybe we can add such an analyser in a separate module or at least make the dependencies optional? I think it would be great to

Re: Sling Feature Analyser: CLI

2023-09-19 Thread Carsten Ziegeler
Hi, I think the initial version had a CLI, but it was removed and obviously the docs were not updated accordingly. Regards Carsten On 18.09.2023 19:56, Konrad Windszus wrote: Hi, Despite the fact that a CLI is mentioned in