sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/17#issuecomment-1335873679
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
tomaszmichalak commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1335317665
Rebased changes and verified with command: `mvn clean package
-Ddocker.skip=false -Ddocker.skip.push=false
-Ddocker.image.name=tomaszmichalak/sling-starter
tomaszmichalak commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1335296201
https://issues.apache.org/jira/browse/SLING-11714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rombert commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1335113674
> @cziegeler Can you please create the ASF Jira account for me?
@tomaszmichalak - as per https://infra.apache.org/jira-guidelines.html#who ,
can you please
tomaszmichalak commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1037878931
##
RELEASING.md:
##
@@ -0,0 +1,12 @@
+# Releasing
Review Comment:
@rombert GH Actions supports `buildx` well. You may push images from
tomaszmichalak commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1037876015
##
RELEASING.md:
##
@@ -0,0 +1,12 @@
+# Releasing
Review Comment:
There is no support for the multi-platform Docker images on DockerHub
tomaszmichalak commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1334871993
@cziegeler Can you please create the ASF Jira account for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/17#issuecomment-1334753774
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/17#issuecomment-1334735956
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/17#issuecomment-1334675432
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/17#issuecomment-1334628226
SonarCloud Quality Gate failed. [![Quality Gate
enapps-enorman opened a new pull request, #17:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/17
to be less ambiguous for restrictions
The restriction details in the security:acl contentloader json input can be
ambiguous in some situations.
This
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1334234427
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1334233639
SonarCloud Quality Gate failed. [![Quality Gate
enapps-enorman commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1332657972
> junit5 migration would be a larger topic on its own
FYI: I opened the SLING-11708 ticket for tracking junit5 compatibility
separately.
--
This
rombert merged PR #81:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert opened a new pull request, #81:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/81
Use random container names to prevent naming conflicts while running CI
builds concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the
rombert commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1034993977
##
RELEASING.md:
##
@@ -0,0 +1,12 @@
+# Releasing
Review Comment:
The actual Docker images are built through DockerHub, I don't think we need
rombert commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1034993977
##
RELEASING.md:
##
@@ -0,0 +1,12 @@
+# Releasing
Review Comment:
The actual Docker images are built through DockerHub, I don't think we need
rombert commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1330929963
Thanks for the PR @tomaszmichalak ! Can you please raise a Jira issue
tracking this enhancement? It's significant enough to need one :-)
--
This is an automated
kwin merged PR #19:
URL: https://github.com/apache/sling-ide-tooling/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kwin merged PR #101:
URL: https://github.com/apache/sling-site/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert commented on PR #101:
URL: https://github.com/apache/sling-site/pull/101#issuecomment-1329238486
@kwin - looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bdelacretaz commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1329216914
Thanks for merging this, sorry that I missed your previous message @dulvac
And thanks @Kronnox for this contribution!
--
This is an automated message
kwin commented on PR #101:
URL: https://github.com/apache/sling-site/pull/101#issuecomment-1329181348
@rombert WDYT about the disclaimer added in
https://github.com/apache/sling-site/pull/101/commits/697a13e41a2b8668f5a578c89823513b457e46b9
--
This is an automated message from the Apache
dulvac merged PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaszmichalak commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1329046368
Validation steps:
```bash
docker run -p 8080:8080 tomaszmichalak/sling-starter:13-20221128-2
```
--
This is an automated message from the Apache Git
tomaszmichalak commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1033506624
##
pom.xml:
##
@@ -254,9 +258,9 @@
io.fabric8
docker-maven-plugin
-0.39.0
+
tomaszmichalak commented on PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#issuecomment-1329025104
The result
(https://hub.docker.com/repository/docker/tomaszmichalak/sling-starter) for the
following commands:
```bash
docker login
mvn clean install
kwin commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/80#discussion_r1033494129
##
pom.xml:
##
@@ -254,9 +258,9 @@
io.fabric8
docker-maven-plugin
-0.39.0
+
tomaszmichalak opened a new pull request, #80:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/80
Support for `buildx` in Docker.
I can provide GH Action for building Docker images with buildx if you wish.
--
This is an automated message from the Apache Git
tomaszmichalak commented on PR #79:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/79#issuecomment-1328840009
Merge with the latest changes around running launcher java process.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1328361181
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/10#issuecomment-1328102283
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1328102253
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1328102259
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1328102232
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1328102228
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1327944592
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1327941482
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1327930946
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
enapps-enorman merged PR #63:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaszmichalak closed pull request #78: Enable java options for Docker image
via envs
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rombert commented on PR #101:
URL: https://github.com/apache/sling-site/pull/101#issuecomment-1327166140
@kwin - thanks for the links. I think we should be good to go with a clear
disclaimer then.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] closed pull request #3: Bump commons-io from 2.4 to 2.7
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/3#issuecomment-1327144656
Looks like commons-io:commons-io is up-to-date now, so this is no longer
needed.
--
This is an automated message from the Apache Git Service.
enapps-enorman commented on PR #63:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/63#issuecomment-1327063485
> I suppose this MR could be merged now?
Yes, I'll do a final verification in the next day or two and merge it it all
looks good with the latest code.
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1326763864
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1326761407
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1326760860
SonarCloud Quality Gate failed. [![Quality Gate
dalbani commented on PR #63:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/63#issuecomment-1326118691
Now that
https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4 has been
merged and the newly released plugin has been put into the POM with
sonarcloud[bot] commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-app-cms/pull/28#issuecomment-1325735949
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
dependabot[bot] closed pull request #21: Bump engine.io from 3.5.0 to 3.6.0 in
/it
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on PR #21:
URL:
https://github.com/apache/sling-org-apache-sling-app-cms/pull/21#issuecomment-1325721138
Superseded by #28.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] opened a new pull request, #28:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28
Bumps [engine.io](https://github.com/socketio/engine.io) and
[socket.io](https://github.com/socketio/socket.io). These dependencies needed
to be updated together.
kwin commented on PR #101:
URL: https://github.com/apache/sling-site/pull/101#issuecomment-1325116910
Not sure, but for me similar to pushing Maven Snapshots to
repository.apache.org. It also states there:
> ... and may use it to distribute snapshots containing unreleased materials
JEBailey closed pull request #13: example of sling resource filter usage
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Kronnox commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1325065432
> I don't have any specific concerns with this solution. I'd just point out
that this solution would be only for consumers who are still using junit4.
>
>
sonarcloud[bot] commented on PR #32:
URL: https://github.com/apache/sling-parent/pull/32#issuecomment-1324891794
Kudos, SonarCloud Quality Gate passed! [
and release of [Apache Sling Testing Clients
kwin merged PR #18:
URL: https://github.com/apache/sling-ide-tooling/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#issuecomment-1323633256
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#issuecomment-1323632374
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
github-code-scanning[bot] commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#discussion_r1029283069
##
src/main/java/org/apache/sling/tooling/support/install/impl/InstallServlet.java:
##
@@ -89,89 +81,21 @@
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#issuecomment-1323624656
SonarCloud Quality Gate failed. [![Quality Gate
kwin opened a new pull request, #5:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5
This is provided by the Felix Web Console ReST endpoint already and should
require authentication
--
This is an automated message from the Apache Git Service.
To
rombert merged PR #31:
URL: https://github.com/apache/sling-parent/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1321267491
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/20#issuecomment-1320974072
SonarCloud Quality Gate failed. [![Quality Gate
JLLeitschuh opened a new pull request, #20:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/20
# Security Vulnerability Fix
This pull request fixes a Temporary File Information Disclosure
Vulnerability, which existed in this project.
## Preamble
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-feature-resolver/pull/2#issuecomment-1320972457
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
JLLeitschuh opened a new pull request, #2:
URL: https://github.com/apache/sling-org-apache-sling-feature-resolver/pull/2
# Security Vulnerability Fix
This pull request fixes a Temporary File Information Disclosure
Vulnerability, which existed in this project.
## Preamble
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1320954366
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1320954323
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/10#issuecomment-1320954172
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1320954096
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1320954080
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert commented on code in PR #31:
URL: https://github.com/apache/sling-parent/pull/31#discussion_r1027128292
##
sling-parent/pom.xml:
##
@@ -891,7 +891,8 @@
-120
+
120
Review Comment:
It's
sonarcloud[bot] commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41#issuecomment-1320792273
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
JLLeitschuh opened a new pull request, #41:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41
# Security Vulnerability Fix
This pull request fixes a Temporary File Information Disclosure
Vulnerability, which existed in this project.
## Preamble
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-installer-it/pull/3#issuecomment-1320770226
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-paxexam-util/pull/1#issuecomment-1320769068
SonarCloud Quality Gate failed. [![Quality Gate
JLLeitschuh opened a new pull request, #3:
URL: https://github.com/apache/sling-org-apache-sling-installer-it/pull/3
# Security Vulnerability Fix
This pull request fixes a Temporary File Information Disclosure
Vulnerability, which existed in this project.
## Preamble
JLLeitschuh opened a new pull request, #1:
URL: https://github.com/apache/sling-org-apache-sling-paxexam-util/pull/1
# Security Vulnerability Fix
This pull request fixes a Temporary File Information Disclosure
Vulnerability, which existed in this project.
## Preamble
sonarcloud[bot] commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/10#issuecomment-1320754497
Kudos, SonarCloud Quality Gate passed! [