sonarcloud[bot] commented on PR #82:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/82#issuecomment-1300851325
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #82:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/82#issuecomment-1300299861
SonarCloud Quality Gate failed. [![Quality Gate
cziegeler merged PR #86:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #86:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/86#issuecomment-1300020182
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #86:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/86#issuecomment-1300017659
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
reschke commented on PR #82:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/82#issuecomment-1299882688
will look at improving test coverage...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sonarcloud[bot] commented on PR #82:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/82#issuecomment-1299870073
SonarCloud Quality Gate failed. [![Quality Gate
cziegeler merged PR #85:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#issuecomment-1299700133
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
anchela commented on code in PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/38#discussion_r1011301674
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/AccessMetrics.java:
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
cziegeler commented on code in PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#discussion_r1011234227
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -341,7 +342,8 @@ private void execute() {
sonarcloud[bot] commented on PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#issuecomment-1298708806
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
reschke commented on code in PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#discussion_r1010561380
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -329,7 +329,8 @@ private void execute() {
rombert commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-models-api/pull/8#issuecomment-1297343495
With this annotation processor the following code
```
@SlingObject
private static ResourceResolver resourceResolver;
```
causes a
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-models-api/pull/8#issuecomment-1297317418
SonarCloud Quality Gate failed. [![Quality Gate
rombert opened a new pull request, #8:
URL: https://github.com/apache/sling-org-apache-sling-models-api/pull/8
Create a ValidatingAnnotationProcessor that enforces required behaviours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] opened a new pull request, #17:
URL: https://github.com/apache/sling-ide-tooling/pull/17
Bumps commons-io from 2.6 to 2.7.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #16:
URL: https://github.com/apache/sling-ide-tooling/pull/16
Bumps [gson](https://github.com/google/gson) from 2.8.0 to 2.8.9.
Release notes
Sourced from https://github.com/google/gson/releases;>gson's
releases.
Gson 2.8.9
dependabot[bot] opened a new pull request, #15:
URL: https://github.com/apache/sling-ide-tooling/pull/15
Bumps [gson](https://github.com/google/gson) from 2.8.0 to 2.8.9.
Release notes
Sourced from https://github.com/google/gson/releases;>gson's
releases.
Gson 2.8.9
kwin merged PR #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert commented on PR #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1297102820
@kwin - all tests ( shared/cli/eclipse) pass locally for me as well, with
```
Apache Maven 3.8.6 (SUSE 3.8.6-2.1)
Maven home: /usr/share/maven
Java version: 17.0.5,
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/38#issuecomment-1296901553
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1296371027
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1295948975
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1295948853
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1295949004
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1295948847
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
kwin commented on PR #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1295831829
@rombert The ITs are still intermittently unstable on Jenkins (but not worse
than in master), therefore I would like to merge and rather do subsequent fixes
separately. Locally they
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1295670321
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1295665018
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1295645022
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295542361
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295434280
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295409026
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295390488
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295379553
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008390405
##
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##
@@ -152,6 +165,29 @@ public void testProvider2() throws
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008390217
##
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##
@@ -152,6 +165,29 @@ public void testProvider2() throws
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008389902
##
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##
@@ -152,6 +165,29 @@ public void testProvider2() throws
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008389741
##
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##
@@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008388948
##
src/main/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImpl.java:
##
@@ -166,9 +166,17 @@ public void registerMimeType(String
kwin commented on PR #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1295268565
@rombert Can you try locally. For me the tests locally always succeed with
```
Maven home: /opt/homebrew/Cellar/maven/3.8.6/libexec
Java version: 17.0.4, vendor: Eclipse
rombert commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008227094
##
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##
@@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest
rombert commented on PR #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1295134410
@kwin - one test might be related to your work
```org.apache.sling.ide.eclipse.m2e.internal.LegacyMavenBundleProjectTest.testLegacyMavenBundleProjectHasErrorMarker
Time
joerghoh merged PR #19:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
enapps-enorman merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1293869101
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
agangam commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1293814344
> Thanks for the contribution @agangam . Can you please resubmit a version
without formatting/whitespace changes?
Reverted the formatting changes
--
This
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1293810130
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1293809604
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1293797976
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
joerghoh commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1293764832
@raducotescu @karlpauls can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
joerghoh merged PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-js-provider/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
joerghoh merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-scripting-api/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1293615751
@ashokmca07 I went ahead and merged as I would like to release this
--
This is an automated message from the Apache Git Service.
To respond to the
stefan-egli merged PR #11:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1293553014
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
anchela merged PR #148:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
niekraaijmakers commented on PR #148:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/148#issuecomment-1293323842
makes sense to me, but not sure if I know enough about this one to give a
seal of approval...
--
This is an automated message from the Apache
anchela commented on PR #148:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/148#issuecomment-1293174241
@niekraaijmakers , since i can't invite you for the review, here the
inofficial review request :)
--
This is an automated message from the Apache Git
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1292760237
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1292754655
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1292736472
SonarCloud Quality Gate failed. [![Quality Gate
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1006241569
##
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##
@@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest
agangam commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1006241408
##
src/main/resources/META-INF/mime.types:
##
@@ -24,3 +24,8 @@
application/compress z
image/pict pict
agangam opened a new pull request, #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5
Support multiple mime types to an extension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Buuhuu merged PR #100:
URL: https://github.com/apache/sling-site/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Buuhuu commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1292495709
I don't think documenting a minimum version actually makes sense as the API
we use here is stable since about 20 years:
sonarcloud[bot] commented on PR #148:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/148#issuecomment-1292361084
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-app-cms/pull/23#issuecomment-1291326104
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-app-cms/pull/24#issuecomment-1291323021
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
dependabot[bot] opened a new pull request, #24:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/24
Bumps commons-text from 1.9 to 1.10.0.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #23:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/23
Bumps commons-text from 1.9 to 1.10.0.
[![Dependabot compatibility
kwin commented on PR #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1291145870
@rombert Any idea why the ITs fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-commons-mime/pull/4#issuecomment-1290951676
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
klcodanr opened a new pull request, #4:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/4
Updating to get all of the new mime types since httpd v2.4.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Buuhuu merged PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/5#issuecomment-1290668118
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
Buuhuu merged PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Buuhuu merged PR #12:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1290574936
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/4#issuecomment-1290559795
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert merged PR #30:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/3#issuecomment-1290413804
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
dependabot[bot] opened a new pull request, #3:
URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/3
Bumps commons-io from 2.5 to 2.7.
[![Dependabot compatibility
kwin merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kwin commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1290295712
As ICU is self-contained (i.e. doesn't have any dependencies) and comes with
Bundle Manifest headers I don't see a reason for embedding or adding a wrapper.
dependabot[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/17#issuecomment-1290234473
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the
raducotescu closed pull request #17: Bump org.apache.sling.xss from 2.0.0 to
2.0.4
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dependabot[bot] commented on PR #19:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/19#issuecomment-1290234178
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the
raducotescu closed pull request #19: Bump commons-io from 2.5 to 2.7
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
raducotescu merged PR #21:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1290002463
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
Buuhuu commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1289979144
Sorry for the late reply. I am +1 to going ahead and merging this. The
discussion about semantic package versioning in icu did not lead to an outcome
and the
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1289196611
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1289184786
SonarCloud Quality Gate failed. [