sonarcloud[bot] commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/12#issuecomment-2152892209
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
kwin merged PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
csaboka commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2152095604
@kwin : Whoops, it didn't have a related JIRA ticket, but I have created one
now. I've also rebased the code as requested. Is it good to merge now?
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2152087287
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
kwin commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2151904113
@csaboka Can you rebase to only have 3 commits (parent update, reformat,
.git-blame-ignore-revs) and make sure that all commit messages have the prefix
csaboka commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2151601607
@kwin , can you merge this? Is there anything still missing?
--
This is an automated message from the Apache Git Service.
To respond to the
anchela merged PR #45:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2150393767
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1628016847
##
pom.xml:
##
@@ -173,6 +179,12 @@
1.9.0
provided
+
+org.apache.sling
+
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1628013962
##
pom.xml:
##
@@ -173,6 +179,12 @@
1.9.0
provided
+
+org.apache.sling
+
joerghoh merged PR #55:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cziegeler commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627625668
##
pom.xml:
##
@@ -173,6 +179,12 @@
1.9.0
provided
+
+org.apache.sling
+
joerghoh merged PR #52:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh merged PR #51:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
anchela commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149398028
@cziegeler , i did a few test with snapshot bundle in AEM verifying that an
invalid mapping is always spotted and deprecated mapping is spotted if
warn-only
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149323620
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149095776
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149093778
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality
anchela commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149092105
@cziegeler , thanks for the review. i refactored the code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627157822
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627144277
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the
cziegeler commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149040568
PR looks good to me, I added two minor comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cziegeler commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627109054
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149034404
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality
cziegeler commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627106283
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the
anchela opened a new pull request, #45:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45
hi @cziegeler , @karlpauls , i gave it a try to implement a feature analyser
for service user mapping configurations. that allows to spot invalid and
deprecated mappings.
sonarcloud[bot] commented on PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2148503993
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #51:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2148503219
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
rombert commented on PR #332:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/332#issuecomment-2146710774
```
[ERROR] [requirements-capabilities] org.freemarker:freemarker:2.3.33:
Artifact org.freemarker:freemarker:2.3.33 requires
renovate-bot opened a new pull request, #332:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/332
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age |
rombert merged PR #166:
URL: https://github.com/apache/sling-site/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh commented on PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2139338289
@kwin I checked the 2nd startup of an AEM SDK instance (with and without
that patch) and found an improvement of around 10% of the total runtime of all
468
renovate-bot opened a new pull request, #166:
URL: https://github.com/apache/sling-site/pull/166
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing |
joerghoh merged PR #52:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert merged PR #330:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert merged PR #331:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
renovate-bot opened a new pull request, #330:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/330
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age |
renovate-bot opened a new pull request, #331:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/331
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age |
sonarcloud[bot] commented on PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2136195077
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #51:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2136192090
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
joerghoh merged PR #48:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #48:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/48#issuecomment-2135211774
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
joerghoh opened a new pull request, #48:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/48
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jsedding merged PR #54:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsedding commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616876096
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class
jsedding commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616872112
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -567,7 +567,7 @@ private static String
jsedding commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616872388
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class
joerghoh commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616855141
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -567,7 +567,7 @@ private static String
joerghoh commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616847657
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class
jsedding opened a new pull request, #54:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sonarcloud[bot] commented on PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2134102353
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #51:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2134099708
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
rombert merged PR #165:
URL: https://github.com/apache/sling-site/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
paulochang opened a new pull request, #165:
URL: https://github.com/apache/sling-site/pull/165
The "Passing parameters to Javascript Use-Objects" section had some extra #
in its formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
joerghoh merged PR #47:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh merged PR #46:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh opened a new pull request, #47:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/47
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rombert merged PR #329:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsedding merged PR #49:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
renovate-bot opened a new pull request, #329:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/329
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age |
sonarcloud[bot] commented on PR #46:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/46#issuecomment-2132267402
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #51:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2131554764
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2131550683
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #49:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2131547814
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131368553
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
kwin commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614785674
##
pom.xml:
##
@@ -41,27 +41,133 @@
Apache Sling Scripting HTL Compiler
-
-The Apache Sling Scripting HTL
csaboka commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131315388
Well, now I get the blame for all the code duplication and missing coverage
on the code I "touched". I hope that isn't a blocker for merging this.
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131313550
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
csaboka commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614722374
##
pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.sling
sling-bundle-parent
-44
+52
Review
csaboka commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614720582
##
pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.sling
sling-bundle-parent
-44
+52
Review
kwin commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614687706
##
pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.sling
sling-bundle-parent
-44
+52
Review
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131264743
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
rishabhdaim commented on PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#issuecomment-2129190028
> @rishabhdaim I think once you remove the original.pid part of the code, we
could merge this PR.
Done in
sonarcloud[bot] commented on PR #49:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2128478041
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2128474929
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #51:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2128474359
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
jsedding commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611777912
##
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:
##
@@ -707,6 +716,7 @@ private UpdateResult
jsedding merged PR #53:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsedding commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1611600431
##
src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java:
##
@@ -92,6 +92,9 @@
jsedding commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611598811
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session
jsedding commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611596184
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,42 +116,25 @@ public NodePropertiesVisitor(Session
joerghoh commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611590909
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,42 +116,25 @@ public NodePropertiesVisitor(Session
joerghoh commented on code in PR #51:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#discussion_r1599049824
##
pom.xml:
##
@@ -158,6 +158,12 @@
4.3.1
test
+
+org.apache.sling
+
sonarcloud[bot] commented on PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126808416
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
jsedding commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611427296
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session
rishabhdaim commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611358227
##
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrUtil.java:
##
@@ -73,4 +75,21 @@ public static Node
reschke commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611357821
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session
sonarcloud[bot] commented on PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126642430
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126609772
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
jsedding opened a new pull request, #53:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
joerghoh opened a new pull request, #46:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
abhishekgarg18 closed pull request #14: SLING-12322 Stream Reader should Return
SC_OK if content length is le…
URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
abhishekgarg18 opened a new pull request, #14:
URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/14
…ss than specified range
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rombert commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2124809600
@joerghoh - all done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rombert merged PR #45:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert merged PR #44:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2124762983
@rombert would appreciate that. I plan to upgrade parent pom afterwards
(SLING-12321)
--
This is an automated message from the Apache Git Service.
To respond to the
jsedding commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1609457830
##
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrUtil.java:
##
@@ -73,4 +75,21 @@ public static Node createPath(final
rombert commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2124069446
@joerghoh - do you want to merge #44 first? I can then rebase, if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
rishabhdaim commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1608439188
##
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:
##
@@ -707,6 +716,7 @@ private UpdateResult
1 - 100 of 4254 matches
Mail list logo